aboutsummaryrefslogtreecommitdiffstats
path: root/src/gestures.c
Commit message (Collapse)AuthorAgeFilesLines
* Fix event flood in tap handlingDennis Jarosch2011-02-131-0/+1
| | | | | | | | Fixes the bug that flooded the X server with button events, by initializing the Gestures struct before handling taps. Signed-off-by: Dennis Jarosch <dennis.jarosch@gmx.de> Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
* Move tapping parameter to memory.cHenrik Rydberg2010-06-171-4/+0
| | | | | | | | The tapping was not properly turned off by the parameter, resulting in spurious clicks when typing. This patch moves the tapping parameter logic to memory.c, which fixes the problem. Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
* Add tapping logicHenrik Rydberg2010-06-161-0/+43
| | | | | | | | This patch adds tap-to-click, tap-and-hold for dragging, two-finger and three-finger taps. Turned on by default for touch screens only; switch on in gestures.c. Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
* Increase stability against thumb and edge touchesHenrik Rydberg2010-06-161-1/+1
| | | | | | | | | Sliding a thumb along the upper edge of the pad results in spurious pointer motion. This patch increases the delays before moving close to the pad edges, and increase the relaxation time after a thumb detection, reducing the effect somewhat. Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
* refactor: Replace hwdata by mtdevHenrik Rydberg2010-06-161-2/+24
| | | | | | | | This patch makes the switch, from using hwdata and the associated type A parser, to using mtdev and the associated type B parser. A command-line gesture test program is included. Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
* refactor: Use the bitmask_t typeHenrik Rydberg2010-06-161-1/+1
| | | | | | | Use the bitmask_t for all bitfields, to simplify future expansions to larger bit fields. Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
* Add rotation gestureHenrik Rydberg2010-05-141-2/+13
| | | | | | | | Moving two fingers around a center point will trigger the gesture. This patch computes the rotation gesture and maps it to mouse buttons 14 and 15. Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
* Add scale gestureHenrik Rydberg2010-05-141-1/+33
| | | | | | | | Moving two fingers apart or closer together will trigger the gesture. This patch computes the scaling gesture and maps it to mouse buttons 12 and 13. Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
* Hold movement while clickingHenrik Rydberg2010-05-141-1/+5
| | | | | | | | In particular for trackpads with integrated button, freezing the mouse movement while clicking is important for pointer precision. This patch holds the movement while clicking, obtaining the desired effect. Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
* Disable motion with resting thumbsHenrik Rydberg2010-05-141-0/+9
| | | | | | | | Disable motion gestures whenever one of the pointing fingers is a thumb. Movement is skipped rather than held, minimizing unpredictable movement after thumb release. Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
* Refactor parsor memory usageHenrik Rydberg2010-05-141-21/+31
| | | | | | | Add the bitmasks "fingers" and "added" to parsor memory, and extend time handling to use a hold time and a forget time. Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
* janitor: Split gesture code into memory refresh and parseHenrik Rydberg2010-05-141-131/+43
| | | | | | | | Split the gesture code into a lexical part, which updates the filtered motion state, and a parsing part, which translates the motion state to gestures. Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
* Introduce MTFinger structureHenrik Rydberg2010-05-141-5/+5
| | | | | | | Switch from the FingerData structure to the MTFinger structure, making room for more computed finger details in MTState. Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
* janitor: Move min/max and dist functions up to common.hHenrik Rydberg2010-05-141-2/+0
| | | | Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
* Simplify bit bookkeepingHenrik Rydberg2010-05-141-17/+13
| | | | | | | | In preparation of adding several additional finger bit registers, remove the redundant bit-counting variables and introduce fast bit-traversal functions instead. Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
* Only emit multi-finger button events for real button eventsHenrik Rydberg2010-04-181-3/+7
| | | | | | | | | The current implementation will emit additional multi-finger click events if, for instance, one finger is removed before releasing the button. This patch makes sure logical buttons events are only emitted as a result of a real button event. Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
* Make all movement computations work on pointing subsetHenrik Rydberg2010-04-181-0/+2
| | | | | | | | In the current implementation this patch has no effect, but with any change to the logic, it will. Add the lines missing in order to loop over pointing fingers. Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
* Unify detection of finger configuration changesHenrik Rydberg2010-04-151-13/+17
| | | | | | | | | | This patch simplifies and unifies the means by which finger configuration changes are detected. The logic is almost the same, except for the unlikely case of very quickly switching the clicking finger, after first having moved it above the clicking area. This case should now properly be detected as a pointing finger. Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
* Reset accumulated movement at finger configuration changeHenrik Rydberg2010-04-151-0/+2
| | | | | | | | | This bug crept in during the transition of the movement code from position differencing to delta accumulation. If briefly touching the trackpad in motion, then placing the finger calmly at another point, a jittery motion would occur. Fixed with this patch. Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
* Add memory debug convenience routinesHenrik Rydberg2010-04-151-0/+3
| | | | | | Output parsing memory values, switched off by default. Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
* Extract moving fingersHenrik Rydberg2010-04-151-17/+52
| | | | | | | | | | | | The current code determines the moving, scrolling and swiping gestures based on the number of fingers on the trackpad, including the resting fingers at the bottom of the pad. With information about all fingers at hand, it is possible to determine which fingers on the trackpad are participating in a moving gesture. This patch computes the movement based on the pointing fingers only, and uses that number to determine the type of moving gesture. Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
* Extract pointing fingersArturo Castro2010-04-151-2/+42
| | | | | | | | | | | | | | | Multi-finger clicks and taps are goverened by the number of pointing fingers on the trackpad. This number can be different from the actual number of fingers on the trackpad. For instance, a finger resting at the bottom of an integrated button, or a finger that accidentally touches the pad during a press, are not pointing fingers. This patch introduces extract_pointers(), which computes the number of pointing fingers on the trackpad, and uses that number to determine the logical button state. [rydberg@euromail.se: various cleanups] Signed-off-by: Arturo Castro <arturo@openframeworks.cc> Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
* Define swipe gesturesHenrik Rydberg2010-04-151-4/+12
| | | | | | | Define three-finger vertical and horizontal scroll as vertical and horizontal swipe gestures. Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
* Drop movement during gesture decayArturo Castro2010-04-151-2/+7
| | | | | | | | | | | With this patch, finger motion is divided into two phases; one attack phase where fingers are added to the trackpad, and one decay phase, where fingers leave the trackpad. The decay delay is set considerably larger than the attack delay. The prime effect is to ignore accidental pointer movement right after a two-finger scroll. Signed-off-by: Arturo Castro <arturo@openframeworks.cc> Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
* Add a gesture credits sectionHenrik Rydberg2010-04-151-0/+4
| | | | Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
* Delay movement after a finger configuration changeArturo Castro2010-04-151-8/+20
| | | | | | | | | | The current code responds to finger movement immediately after a finger has been placed on the trackpad, even if the touch is accidental. This patch delays the effect of the finger by 70 ms, resulting in fewer accidental movements. Signed-off-by: Arturo Castro <arturo@openframeworks.cc> Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
* Keep logical buttons separate from the hardware onesHenrik Rydberg2010-04-151-4/+8
| | | | | | | | | The button extraction currently modifies the MTState buttons, upsetting the semantics in a bad way. This patch adds the logical button state to the Memory structure, and uses it to compute the logical button change. Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
* Only extract movement from identical finger configurationsHenrik Rydberg2010-04-151-16/+21
| | | | | | | | | The current code would extract movement from a rapid change from one finger to the next, resulting in unwanted jumps. This patch first checks that the finger configuration is the same before attempting to extract movement. Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
* Reorganize gesture codeHenrik Rydberg2010-04-151-18/+32
| | | | | | | Break out extraction of movement, buttons and type. Only code traversal, no logical changes. Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
* Introduce the MTStateHenrik Rydberg2010-04-151-11/+12
| | | | | | | | | | | | | | | The HWState keeps, for good reason, both touching fingers and fingers going away. However, this implies that additional logic is needed to keep track of the number of actual touching fingers. In particular the test for touching fingers is somewhat misplaced in hwstate.c. Moreover, HWState should only exist in one instance, since it contains data which does not need to be referred to during gesture extraction. This patch introduces the MTState structure, which keeps more digested data for gesture extraction. In particular, it only keeps the actual touches. Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
* Rename State to HWStateHenrik Rydberg2010-04-151-11/+11
| | | | | | | Rename the hardware state struct State to HWState, to make room for additional state structures. Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
* janitor: remaining indentation fixedHenrik Rydberg2010-02-021-2/+2
|
* janitor: stick to kernel-style formattingHenrik Rydberg2010-02-011-1/+2
| | | | | | With this commit, the whole code base complies with the kernel format style, and patches can be checked against the kernel-provided ./scripts/checkpatch.pl
* button: simplify button handlingHenrik Rydberg2010-02-011-8/+2
| | | | | Make better use of the bit representation, reducing one layer of conversion.
* common: add some more bit utilitiesHenrik Rydberg2010-02-011-3/+3
|
* License and credits resolvedHenrik Rydberg2010-01-301-0/+21
| | | | | | All files are tagged as GPL, and a CREDIT file created with references to the synaptics X driver and the matching code, under their respective MIT and BSD licenses.
* Add multi-finger button and scroll from experimentalHenrik Rydberg2009-05-161-0/+10
| | | | Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
* Gesture interface in placeHenrik Rydberg2008-11-091-0/+39
Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-13 14:42:43 +0000