From ac84f4782964e36d064e0a517ed041cdaf8cd1a4 Mon Sep 17 00:00:00 2001 From: Robert Ou Date: Tue, 29 Aug 2017 14:55:45 -0700 Subject: coolrunner2: Combine some for loops together --- techlibs/coolrunner2/coolrunner2_sop.cc | 30 ++++++++++++++---------------- 1 file changed, 14 insertions(+), 16 deletions(-) (limited to 'techlibs') diff --git a/techlibs/coolrunner2/coolrunner2_sop.cc b/techlibs/coolrunner2/coolrunner2_sop.cc index eb8754de7..2d3961ee5 100644 --- a/techlibs/coolrunner2/coolrunner2_sop.cc +++ b/techlibs/coolrunner2/coolrunner2_sop.cc @@ -38,26 +38,24 @@ struct Coolrunner2SopPass : public Pass { log_header(design, "Executing COOLRUNNER2_SOP pass (break $sop cells into ANDTERM/ORTERM cells).\n"); extra_args(args, 1, design); - // Find all the $_NOT_ cells - dict> not_cells; for (auto module : design->selected_modules()) { + pool cells_to_remove; SigMap sigmap(module); + + // Find all the $_NOT_ cells + dict> not_cells; for (auto cell : module->selected_cells()) { if (cell->type == "$_NOT_") { - auto not_input = cell->getPort("\\A")[0]; - auto not_output = cell->getPort("\\Y")[0]; + auto not_input = sigmap(cell->getPort("\\A")[0]); + auto not_output = sigmap(cell->getPort("\\Y")[0]); not_cells[not_input] = tuple(not_output, cell); } } - } - pool> cells_to_remove; - for (auto module : design->selected_modules()) - { - SigMap sigmap(module); + // Process $sop cells for (auto cell : module->selected_cells()) { if (cell->type == "$sop") @@ -79,7 +77,7 @@ struct Coolrunner2SopPass : public Pass { sop_output = std::get<0>(not_cell); // remove the $_NOT_ cell because it gets folded into the xor - cells_to_remove.insert(tuple(module, std::get<1>(not_cell))); + cells_to_remove.insert(std::get<1>(not_cell)); } // Construct AND cells @@ -140,15 +138,15 @@ struct Coolrunner2SopPass : public Pass { } // Finally, remove the $sop cell - cells_to_remove.insert(tuple(module, cell)); + cells_to_remove.insert(cell); } } - } - // Actually do the removal now that we aren't iterating - for (auto mod_and_cell : cells_to_remove) - { - std::get<0>(mod_and_cell)->remove(std::get<1>(mod_and_cell)); + // Actually do the removal now that we aren't iterating + for (auto cell : cells_to_remove) + { + module->remove(cell); + } } } } Coolrunner2SopPass; -- cgit v1.2.3 From 7f08be430422c5fffc93cf0315e1894880b32b5b Mon Sep 17 00:00:00 2001 From: Robert Ou Date: Tue, 29 Aug 2017 14:56:02 -0700 Subject: coolrunner2: Fix mapping of flip-flops --- techlibs/coolrunner2/synth_coolrunner2.cc | 1 - 1 file changed, 1 deletion(-) (limited to 'techlibs') diff --git a/techlibs/coolrunner2/synth_coolrunner2.cc b/techlibs/coolrunner2/synth_coolrunner2.cc index ae4b84335..fa7d9ac78 100644 --- a/techlibs/coolrunner2/synth_coolrunner2.cc +++ b/techlibs/coolrunner2/synth_coolrunner2.cc @@ -153,7 +153,6 @@ struct SynthCoolrunner2Pass : public ScriptPass { run("abc -sop -I 40 -P 56"); run("coolrunner2_sop"); - run("opt -fast"); } if (check_label("map_cells")) -- cgit v1.2.3 From 6775177171e70c64292a78a5d860d7b82d5c64b9 Mon Sep 17 00:00:00 2001 From: Robert Ou Date: Wed, 30 Aug 2017 16:38:04 -0700 Subject: coolrunner2: Initial fixes for special p-terms Certain signals can only be controlled by a product term and not a sum-of-products. Do the initial work for fixing this. --- techlibs/coolrunner2/coolrunner2_sop.cc | 78 +++++++++++++++++++++++++++++++ techlibs/coolrunner2/synth_coolrunner2.cc | 4 +- 2 files changed, 81 insertions(+), 1 deletion(-) (limited to 'techlibs') diff --git a/techlibs/coolrunner2/coolrunner2_sop.cc b/techlibs/coolrunner2/coolrunner2_sop.cc index 2d3961ee5..d526f8036 100644 --- a/techlibs/coolrunner2/coolrunner2_sop.cc +++ b/techlibs/coolrunner2/coolrunner2_sop.cc @@ -55,6 +55,35 @@ struct Coolrunner2SopPass : public Pass { } } + // Find wires that need to become special product terms + dict>> special_pterms_no_inv; + dict>> special_pterms_inv; + for (auto cell : module->selected_cells()) + { + if (cell->type == "\\FDCP" || cell->type == "\\FDCP_N" || cell->type == "\\FDDCP" || + cell->type == "\\FTCP" || cell->type == "\\FTCP_N" || cell->type == "\\FTDCP" || + cell->type == "\\FDCPE" || cell->type == "\\FDCPE_N" || cell->type == "\\FDDCPE" || + cell->type == "\\LDCP" || cell->type == "\\LDCP_N") + { + if (cell->hasPort("\\PRE")) + special_pterms_no_inv[sigmap(cell->getPort("\\PRE")[0])].insert( + tuple(cell, "\\PRE")); + if (cell->hasPort("\\CLR")) + special_pterms_no_inv[sigmap(cell->getPort("\\CLR")[0])].insert( + tuple(cell, "\\PRE")); + if (cell->hasPort("\\CE")) + special_pterms_no_inv[sigmap(cell->getPort("\\CE")[0])].insert( + tuple(cell, "\\PRE")); + + if (cell->hasPort("\\C")) + special_pterms_inv[sigmap(cell->getPort("\\C")[0])].insert( + tuple(cell, "\\PRE")); + if (cell->hasPort("\\G")) + special_pterms_inv[sigmap(cell->getPort("\\G")[0])].insert( + tuple(cell, "\\PRE")); + } + } + // Process $sop cells for (auto cell : module->selected_cells()) { @@ -80,6 +109,16 @@ struct Coolrunner2SopPass : public Pass { cells_to_remove.insert(std::get<1>(not_cell)); } + // Check for special P-term usage + bool is_special_pterm = false; + bool special_pterm_can_invert = false; + if (special_pterms_no_inv.count(sop_output) || special_pterms_inv.count(sop_output)) + { + is_special_pterm = true; + if (!special_pterms_no_inv.count(sop_output)) + special_pterm_can_invert = true; + } + // Construct AND cells pool intermed_wires; for (int i = 0; i < sop_depth; i++) { @@ -118,6 +157,40 @@ struct Coolrunner2SopPass : public Pass { xor_cell->setParam("\\INVERT_OUT", has_invert); xor_cell->setPort("\\IN_PTC", *intermed_wires.begin()); xor_cell->setPort("\\OUT", sop_output); + + // Special P-term handling + if (is_special_pterm) + { + if (!has_invert) + { + // Can connect the P-term directly to the special term sinks + for (auto x : special_pterms_inv[sop_output]) { + log("%s %s", std::get<0>(x)->name.c_str(), std::get<1>(x).c_str()); + std::get<0>(x)->setPort(std::get<1>(x), *intermed_wires.begin()); + } + for (auto x : special_pterms_no_inv[sop_output]) { + log("%s %s", std::get<0>(x)->name.c_str(), std::get<1>(x).c_str()); + std::get<0>(x)->setPort(std::get<1>(x), *intermed_wires.begin()); + } + } + else + { + if (special_pterm_can_invert) + { + log_assert(special_pterms_no_inv.count(sop_output) == 0); + + // XXX TODO + log_assert(!"not implemented yet"); + } + else + { + // Need to construct a set of feed-through terms + + // XXX TODO + log_assert(!"not implemented yet"); + } + } + } } else { @@ -135,6 +208,11 @@ struct Coolrunner2SopPass : public Pass { xor_cell->setParam("\\INVERT_OUT", has_invert); xor_cell->setPort("\\IN_ORTERM", or_to_xor_wire); xor_cell->setPort("\\OUT", sop_output); + + if (is_special_pterm) + { + // Need to construct a set of feed-through terms + } } // Finally, remove the $sop cell diff --git a/techlibs/coolrunner2/synth_coolrunner2.cc b/techlibs/coolrunner2/synth_coolrunner2.cc index fa7d9ac78..562cce460 100644 --- a/techlibs/coolrunner2/synth_coolrunner2.cc +++ b/techlibs/coolrunner2/synth_coolrunner2.cc @@ -152,7 +152,7 @@ struct SynthCoolrunner2Pass : public ScriptPass if (check_label("map_pla")) { run("abc -sop -I 40 -P 56"); - run("coolrunner2_sop"); + run("clean"); } if (check_label("map_cells")) @@ -162,7 +162,9 @@ struct SynthCoolrunner2Pass : public ScriptPass run("dffinit -ff FDCP_N Q INIT"); run("dffinit -ff LDCP Q INIT"); run("dffinit -ff LDCP_N Q INIT"); + run("coolrunner2_sop"); run("iopadmap -bits -inpad IBUF O:I -outpad IOBUFE I:IO -inoutpad IOBUFE O:IO -toutpad IOBUFE E:I:IO -tinoutpad IOBUFE E:O:I:IO"); + run("clean"); } if (check_label("check")) -- cgit v1.2.3 From fa04366f38797f882d90c40dbcc3854a2f9140c9 Mon Sep 17 00:00:00 2001 From: Robert Ou Date: Wed, 30 Aug 2017 16:46:32 -0700 Subject: coolrunner2: Generate a feed-through AND term when necessary --- techlibs/coolrunner2/coolrunner2_sop.cc | 44 +++++++++++++++++++++++---------- 1 file changed, 31 insertions(+), 13 deletions(-) (limited to 'techlibs') diff --git a/techlibs/coolrunner2/coolrunner2_sop.cc b/techlibs/coolrunner2/coolrunner2_sop.cc index d526f8036..089d3b438 100644 --- a/techlibs/coolrunner2/coolrunner2_sop.cc +++ b/techlibs/coolrunner2/coolrunner2_sop.cc @@ -161,19 +161,16 @@ struct Coolrunner2SopPass : public Pass { // Special P-term handling if (is_special_pterm) { - if (!has_invert) + if (!has_invert || special_pterm_can_invert) { // Can connect the P-term directly to the special term sinks - for (auto x : special_pterms_inv[sop_output]) { - log("%s %s", std::get<0>(x)->name.c_str(), std::get<1>(x).c_str()); + for (auto x : special_pterms_inv[sop_output]) std::get<0>(x)->setPort(std::get<1>(x), *intermed_wires.begin()); - } - for (auto x : special_pterms_no_inv[sop_output]) { - log("%s %s", std::get<0>(x)->name.c_str(), std::get<1>(x).c_str()); + for (auto x : special_pterms_no_inv[sop_output]) std::get<0>(x)->setPort(std::get<1>(x), *intermed_wires.begin()); - } } - else + + if (has_invert) { if (special_pterm_can_invert) { @@ -184,10 +181,19 @@ struct Coolrunner2SopPass : public Pass { } else { - // Need to construct a set of feed-through terms - - // XXX TODO - log_assert(!"not implemented yet"); + // Need to construct a feed-through term + auto feedthrough_out = module->addWire(NEW_ID); + auto feedthrough_cell = module->addCell(NEW_ID, "\\ANDTERM"); + feedthrough_cell->setParam("\\TRUE_INP", 1); + feedthrough_cell->setParam("\\COMP_INP", 0); + feedthrough_cell->setPort("\\OUT", feedthrough_out); + feedthrough_cell->setPort("\\IN", sop_output); + feedthrough_cell->setPort("\\IN_B", SigSpec()); + + for (auto x : special_pterms_inv[sop_output]) + std::get<0>(x)->setPort(std::get<1>(x), feedthrough_out); + for (auto x : special_pterms_no_inv[sop_output]) + std::get<0>(x)->setPort(std::get<1>(x), feedthrough_out); } } } @@ -211,7 +217,19 @@ struct Coolrunner2SopPass : public Pass { if (is_special_pterm) { - // Need to construct a set of feed-through terms + // Need to construct a feed-through term + auto feedthrough_out = module->addWire(NEW_ID); + auto feedthrough_cell = module->addCell(NEW_ID, "\\ANDTERM"); + feedthrough_cell->setParam("\\TRUE_INP", 1); + feedthrough_cell->setParam("\\COMP_INP", 0); + feedthrough_cell->setPort("\\OUT", feedthrough_out); + feedthrough_cell->setPort("\\IN", sop_output); + feedthrough_cell->setPort("\\IN_B", SigSpec()); + + for (auto x : special_pterms_inv[sop_output]) + std::get<0>(x)->setPort(std::get<1>(x), feedthrough_out); + for (auto x : special_pterms_no_inv[sop_output]) + std::get<0>(x)->setPort(std::get<1>(x), feedthrough_out); } } -- cgit v1.2.3 From 5f65e24ccb7026fc7afa96c057766ae24f21d5f5 Mon Sep 17 00:00:00 2001 From: Robert Ou Date: Wed, 30 Aug 2017 17:02:28 -0700 Subject: coolrunner2: Finish fixing special-use p-terms --- techlibs/coolrunner2/coolrunner2_sop.cc | 28 ++++++++++++++++++++-------- 1 file changed, 20 insertions(+), 8 deletions(-) (limited to 'techlibs') diff --git a/techlibs/coolrunner2/coolrunner2_sop.cc b/techlibs/coolrunner2/coolrunner2_sop.cc index 089d3b438..b57214ccb 100644 --- a/techlibs/coolrunner2/coolrunner2_sop.cc +++ b/techlibs/coolrunner2/coolrunner2_sop.cc @@ -70,17 +70,17 @@ struct Coolrunner2SopPass : public Pass { tuple(cell, "\\PRE")); if (cell->hasPort("\\CLR")) special_pterms_no_inv[sigmap(cell->getPort("\\CLR")[0])].insert( - tuple(cell, "\\PRE")); + tuple(cell, "\\CLR")); if (cell->hasPort("\\CE")) special_pterms_no_inv[sigmap(cell->getPort("\\CE")[0])].insert( - tuple(cell, "\\PRE")); + tuple(cell, "\\CE")); if (cell->hasPort("\\C")) special_pterms_inv[sigmap(cell->getPort("\\C")[0])].insert( - tuple(cell, "\\PRE")); + tuple(cell, "\\C")); if (cell->hasPort("\\G")) special_pterms_inv[sigmap(cell->getPort("\\G")[0])].insert( - tuple(cell, "\\PRE")); + tuple(cell, "\\G")); } } @@ -115,7 +115,7 @@ struct Coolrunner2SopPass : public Pass { if (special_pterms_no_inv.count(sop_output) || special_pterms_inv.count(sop_output)) { is_special_pterm = true; - if (!special_pterms_no_inv.count(sop_output)) + if (!special_pterms_no_inv[sop_output].size()) special_pterm_can_invert = true; } @@ -174,10 +174,22 @@ struct Coolrunner2SopPass : public Pass { { if (special_pterm_can_invert) { - log_assert(special_pterms_no_inv.count(sop_output) == 0); + log_assert(special_pterms_no_inv[sop_output].size() == 0); - // XXX TODO - log_assert(!"not implemented yet"); + for (auto x : special_pterms_inv[sop_output]) + { + auto cell = std::get<0>(x); + // Need to invert the polarity of the cell + if (cell->type == "\\FDCP") cell->type = "\\FDCP_N"; + else if (cell->type == "\\FDCP_N") cell->type = "\\FDCP"; + else if (cell->type == "\\FTCP") cell->type = "\\FTCP_N"; + else if (cell->type == "\\FTCP_N") cell->type = "\\FTCP"; + else if (cell->type == "\\FDCPE") cell->type = "\\FDCPE_N"; + else if (cell->type == "\\FDCPE_N") cell->type = "\\FDCPE"; + else if (cell->type == "\\LDCP") cell->type = "\\LDCP_N"; + else if (cell->type == "\\LDCP_N") cell->type = "\\LDCP"; + else log_assert(!"Internal error! Bad cell type!"); + } } else { -- cgit v1.2.3