From c99fbde0eb0b1b9b725ba2fead13d3210ce961a7 Mon Sep 17 00:00:00 2001 From: Keith Rothman <537074+litghost@users.noreply.github.com> Date: Thu, 4 Feb 2021 14:47:45 -0800 Subject: Mark IdString and IdStringList single argument constructors explicit. Single argument constructors will silently convert to that type. This is typically not the right thing to do. For example, the nexus and ice40 arch_pybindings.h files were incorrectly parsing bel name strings, etc. Signed-off-by: Keith Rothman <537074+litghost@users.noreply.github.com> --- common/nextpnr.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'common/nextpnr.cc') diff --git a/common/nextpnr.cc b/common/nextpnr.cc index f7f368f1..fc70465c 100644 --- a/common/nextpnr.cc +++ b/common/nextpnr.cc @@ -805,9 +805,9 @@ void BaseCtx::attributesToArchInfo() std::string pip = strs[i * 3 + 1]; PlaceStrength strength = (PlaceStrength)std::stoi(strs[i * 3 + 2]); if (pip.empty()) - getCtx()->bindWire(getCtx()->getWireByName(id(wire)), ni, strength); + getCtx()->bindWire(getCtx()->getWireByName(IdStringList::parse(getCtx(), wire)), ni, strength); else - getCtx()->bindPip(getCtx()->getPipByName(id(pip)), ni, strength); + getCtx()->bindPip(getCtx()->getPipByName(IdStringList::parse(getCtx(), pip)), ni, strength); } } } -- cgit v1.2.3