From f9f15e79cdcd59ef4fc5cc3d12b9217d72b6177e Mon Sep 17 00:00:00 2001 From: Eddie Hung Date: Thu, 7 Feb 2019 09:26:41 -0800 Subject: Fix slack_histogram computation accessing num_bins+1 --- common/timing.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/common/timing.cc b/common/timing.cc index f3cb4306..194a0e00 100644 --- a/common/timing.cc +++ b/common/timing.cc @@ -930,8 +930,7 @@ void timing_analysis(Context *ctx, bool print_histogram, bool print_fmax, bool p unsigned bar_width = 60; auto min_slack = slack_histogram.begin()->first; auto max_slack = slack_histogram.rbegin()->first; - auto bin_size = std::max(1u, (max_slack - min_slack) / num_bins); - num_bins = std::min((max_slack - min_slack) / bin_size, num_bins) + 1; + auto bin_size = std::max(1, ceil((max_slack - min_slack) / float(num_bins))); std::vector bins(num_bins); unsigned max_freq = 0; for (const auto &i : slack_histogram) { -- cgit v1.2.3