From c0813e7eddc553c5f8348ed1e1e4c8b00db93857 Mon Sep 17 00:00:00 2001 From: Edward O'Callaghan Date: Sun, 30 Oct 2022 15:53:18 +1100 Subject: programmer: Drop dead fallback_map() boilerplate The fallback_{un}map() boilerplate code doesn't do anything, merely distracts away from otherwise linear control flow. Just drop it as anything in the future that could need such a thing is free to implement it when required. Change-Id: Ibb7760f807fae040416cef2797a7dbf6572f7df9 Signed-off-by: Edward O'Callaghan Reviewed-on: https://review.coreboot.org/c/flashrom/+/68963 Reviewed-by: Angel Pons Tested-by: build bot (Jenkins) Reviewed-by: Felix Singer --- programmer.c | 17 ----------------- 1 file changed, 17 deletions(-) (limited to 'programmer.c') diff --git a/programmer.c b/programmer.c index 939d8c2d..d4f15a13 100644 --- a/programmer.c +++ b/programmer.c @@ -17,23 +17,6 @@ #include "flash.h" #include "programmer.h" -/* Fallback map() for programmers which don't need special handling */ -void *fallback_map(const char *descr, uintptr_t phys_addr, size_t len) -{ - /* A result of NULL causes mapped addresses to be chip physical - * addresses, assuming only a single region is mapped (the entire flash - * space). Chips with a second region (like a register map) require a - * real memory mapping to distinguish the different ranges. Those chips - * are FWH/LPC, so the bus master provides a real mapping. - */ - return NULL; -} - -/* No-op/fallback unmap() for programmers which don't need special handling */ -void fallback_unmap(void *virt_addr, size_t len) -{ -} - /* Little-endian fallback for drivers not supporting 16 bit accesses */ void fallback_chip_writew(const struct flashctx *flash, uint16_t val, chipaddr addr) -- cgit v1.2.3