From e1dd0068c2f1d77d10d2da843f6b32b8f30fd788 Mon Sep 17 00:00:00 2001 From: Daniel Campello Date: Wed, 16 Mar 2022 07:05:48 -0600 Subject: helpers.c: use unsigned int for bit shifts (ASAN) This change addresses the following ASAN error detected in the chromium tree: * ASAN error detected: * ../flashrom-9999/helpers.c:28:13: runtime error: left shift of 1 by 31 places cannot be represented in type 'int' * #0 0x5589a94bb284 in address_to_bits /build/amd64-generic/tmp/portage/sys-apps/flashrom-9999/work/flashrom-9999-build/../flashrom-9999/helpers.c:28:13 * * SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../flashrom-9999/helpers.c:28:13 in BUG=b:224828279 TEST=./test_build.sh; FEATURES=test emerge-amd64-generic flashrom BRANCH=none Signed-off-by: Daniel Campello Change-Id: Ib595f13c29dd5c0775e074801756e4f920b4daaf Reviewed-on: https://review.coreboot.org/c/flashrom/+/62862 Reviewed-by: Anastasia Klimchuk Reviewed-by: Angel Pons Reviewed-by: Edward O'Callaghan Reviewed-by: Paul Menzel Tested-by: build bot (Jenkins) --- helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'helpers.c') diff --git a/helpers.c b/helpers.c index 289848d7..5b47b68c 100644 --- a/helpers.c +++ b/helpers.c @@ -25,7 +25,7 @@ uint32_t address_to_bits(uint32_t addr) { unsigned int lzb = 0; - while (((1 << (31 - lzb)) & ~addr) != 0) + while (((1u << (31 - lzb)) & ~addr) != 0) lzb++; return 32 - lzb; } -- cgit v1.2.3