From f136a2a69c649c785669496d8bbd04b900724e77 Mon Sep 17 00:00:00 2001 From: Daniel Campello Date: Mon, 6 Dec 2021 12:06:09 -0700 Subject: flashrom.c: extract operation only uses layout files This change fixes a bug on handling the extract operation. The extract operation reads out the layout regions to filenames corresponding to the respective layout region names. read_flash_to_file() does this work via write_buf_to_include_args(). This change makes the call to write_buf_to_file() optional as it is still required for -r (read operation) but not for -x (extract operation). BUG=b:209512852 TEST=flashrom -x Fixes: commit ce983bccaab450d358854494f15c2d8a1846d56b Change-Id: Ibc9a4e2966385863345f06662521d6d0e4685121 Signed-off-by: Daniel Campello Reviewed-on: https://review.coreboot.org/c/flashrom/+/59921 Tested-by: build bot (Jenkins) Reviewed-by: Edward O'Callaghan --- flashrom.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/flashrom.c b/flashrom.c index bd34676f..dd443b93 100644 --- a/flashrom.c +++ b/flashrom.c @@ -1098,7 +1098,8 @@ int read_flash_to_file(struct flashctx *flash, const char *filename) goto out_free; } - ret = write_buf_to_file(buf, size, filename); + if (filename) + ret = write_buf_to_file(buf, size, filename); out_free: free(buf); msg_cinfo("%s.\n", ret ? "FAILED" : "done"); -- cgit v1.2.3