From d46fc3740bbfc3bac0b1133a3e9d47c7ce3e06e2 Mon Sep 17 00:00:00 2001 From: Vincent Breitmoser Date: Wed, 18 Mar 2015 21:12:31 +0100 Subject: yubikey certifications! --- OpenKeychain/src/main/res/values/strings.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'OpenKeychain/src/main/res') diff --git a/OpenKeychain/src/main/res/values/strings.xml b/OpenKeychain/src/main/res/values/strings.xml index f1c14bd32..2eb167c8c 100644 --- a/OpenKeychain/src/main/res/values/strings.xml +++ b/OpenKeychain/src/main/res/values/strings.xml @@ -1099,9 +1099,9 @@ "Master key not found!" "No keys certified!" "Error unlocking master key!" - "Certification with NFC is not (yet) supported!" "Certifying keyrings" "Fetching certifying master key" + "Returning for NFC input" "Saving certified key %s" "Saving keyrings" "Unlocking master key" -- cgit v1.2.3 From 3b04636f5daf3d171449296a5d9a67440abfbf75 Mon Sep 17 00:00:00 2001 From: Vincent Breitmoser Date: Fri, 20 Mar 2015 02:27:05 +0100 Subject: support yubikeys in (some) edit key operations --- OpenKeychain/src/main/res/values/strings.xml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'OpenKeychain/src/main/res') diff --git a/OpenKeychain/src/main/res/values/strings.xml b/OpenKeychain/src/main/res/values/strings.xml index 2eb167c8c..e8bcbcc31 100644 --- a/OpenKeychain/src/main/res/values/strings.xml +++ b/OpenKeychain/src/main/res/values/strings.xml @@ -897,6 +897,7 @@ "Modifying keyring %s" + "Will divert to card/nfc for crypto operations" "The serial number of a divert-to-card key must be 16 bytes! This is a programming error, please file a bug report!" "Encoding exception!" "Actual key fingerprint does not match the expected one!" @@ -911,6 +912,7 @@ "Fatal error decrypting master key! This is likely a programming error, please file a bug report!" "Internal OpenPGP error!" "Signature exception!" + "Diverting to card/nfc for crypto operations" "Modifying master certifications" "Adding empty notation packet" "Adding PIN notation packet" @@ -987,7 +989,6 @@ "Key successfully promoted" - "Editing of NFC keys is not (yet) supported!" "Cannot edit keyring with stripped master key!" "Key not found!" -- cgit v1.2.3 From 3e51da3afa542c62b82bbcf9a953cdcd379950a2 Mon Sep 17 00:00:00 2001 From: Vincent Breitmoser Date: Fri, 20 Mar 2015 18:45:00 +0100 Subject: fix unit tests (for real) --- OpenKeychain/src/main/res/values/strings.xml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'OpenKeychain/src/main/res') diff --git a/OpenKeychain/src/main/res/values/strings.xml b/OpenKeychain/src/main/res/values/strings.xml index a7e9cdf7e..76514575c 100644 --- a/OpenKeychain/src/main/res/values/strings.xml +++ b/OpenKeychain/src/main/res/values/strings.xml @@ -913,7 +913,7 @@ "Fatal error decrypting master key! This is likely a programming error, please file a bug report!" "Internal OpenPGP error!" "Signature exception!" - "Diverting to card/nfc for crypto operations" + "Tried to operate on missing subkey %s!" "Modifying master certifications" "Adding empty notation packet" "Adding PIN notation packet" @@ -923,8 +923,10 @@ "Passphrase for subkey could not be changed! (Does it have a different one from the other keys?)" "Replacing certificate of previous primary user ID" "Generating new certificate for new primary user ID" + "Changing to restricted operation mode" "Modifying subkey %s" - "Tried to operate on missing subkey %s!" + "Diverting to card/nfc for crypto operations" + "Passphrase required for operations" "Adding new subkey of type %s" "New subkey ID: %s" "Expiry date cannot be in the past!" -- cgit v1.2.3 From 88ca41d55586e5084cc3f177eb12617aa640ae1d Mon Sep 17 00:00:00 2001 From: Vincent Breitmoser Date: Fri, 20 Mar 2015 18:55:16 +0100 Subject: add edit key unit test for no-op --- OpenKeychain/src/main/res/values/strings.xml | 1 + 1 file changed, 1 insertion(+) (limited to 'OpenKeychain/src/main/res') diff --git a/OpenKeychain/src/main/res/values/strings.xml b/OpenKeychain/src/main/res/values/strings.xml index 76514575c..6c8ccd340 100644 --- a/OpenKeychain/src/main/res/values/strings.xml +++ b/OpenKeychain/src/main/res/values/strings.xml @@ -910,6 +910,7 @@ "Tried to execute restricted operation without passphrase! This is a programming error, please file a bug report!" "Revoked user IDs cannot be primary!" "Expiry time cannot be "same as before" on subkey creation. This is a programming error, please file a bug report!" + "Nothing to do!" "Fatal error decrypting master key! This is likely a programming error, please file a bug report!" "Internal OpenPGP error!" "Signature exception!" -- cgit v1.2.3 From 147003123fffc84b1d658f78d0a888479ce4ff35 Mon Sep 17 00:00:00 2001 From: Vincent Breitmoser Date: Sat, 21 Mar 2015 17:13:31 +0100 Subject: first steps toward yubikey activity - move BaseActivity into new package - extract BaseNfcActivity from NfcOperationsActivity --- .../main/res/layout/create_key_start_fragment.xml | 34 ++++----- .../main/res/layout/create_yubikey_fragment.xml | 83 ++++++++++++++++++++++ 2 files changed, 100 insertions(+), 17 deletions(-) create mode 100644 OpenKeychain/src/main/res/layout/create_yubikey_fragment.xml (limited to 'OpenKeychain/src/main/res') diff --git a/OpenKeychain/src/main/res/layout/create_key_start_fragment.xml b/OpenKeychain/src/main/res/layout/create_key_start_fragment.xml index 79ffe58b1..2db147475 100644 --- a/OpenKeychain/src/main/res/layout/create_key_start_fragment.xml +++ b/OpenKeychain/src/main/res/layout/create_key_start_fragment.xml @@ -50,22 +50,22 @@ android:clickable="true" style="?android:attr/borderlessButtonStyle" /> - - - - - - - - - - - - - - - - + - \ No newline at end of file + diff --git a/OpenKeychain/src/main/res/layout/create_yubikey_fragment.xml b/OpenKeychain/src/main/res/layout/create_yubikey_fragment.xml new file mode 100644 index 000000000..d8c95c658 --- /dev/null +++ b/OpenKeychain/src/main/res/layout/create_yubikey_fragment.xml @@ -0,0 +1,83 @@ + + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file -- cgit v1.2.3 From 1ad3635d139ea5033b06e5cdd87a7b2eab5f2e75 Mon Sep 17 00:00:00 2001 From: Vincent Breitmoser Date: Sat, 21 Mar 2015 19:52:10 +0100 Subject: work on ad-hoc yubikey import support --- .../main/res/layout/create_yubikey_fragment.xml | 101 +++++++++++++++++---- 1 file changed, 85 insertions(+), 16 deletions(-) (limited to 'OpenKeychain/src/main/res') diff --git a/OpenKeychain/src/main/res/layout/create_yubikey_fragment.xml b/OpenKeychain/src/main/res/layout/create_yubikey_fragment.xml index d8c95c658..ec2505706 100644 --- a/OpenKeychain/src/main/res/layout/create_yubikey_fragment.xml +++ b/OpenKeychain/src/main/res/layout/create_yubikey_fragment.xml @@ -9,30 +9,97 @@ android:fillViewport="true" android:layout_above="@+id/create_key_buttons"> - + android:id="@+id/create_yubikey_animator" + > - + android:orientation="vertical"> + + + + + + - + android:orientation="vertical"> - + + + + + + + + + + + + + + + + + @@ -79,5 +146,7 @@ android:gravity="right|center_vertical" android:clickable="true" style="?android:attr/borderlessButtonStyle" /> + + \ No newline at end of file -- cgit v1.2.3 From 04c7639a5a9b4f85122b7d5f299ba09131ce3036 Mon Sep 17 00:00:00 2001 From: Vincent Breitmoser Date: Sat, 21 Mar 2015 22:18:58 +0100 Subject: split up wait/action yubikey fragments --- .../src/main/res/drawable-hdpi/yubi_icon.png | Bin 0 -> 2517 bytes .../src/main/res/drawable-hdpi/yubi_icon_24dp.png | Bin 0 -> 1203 bytes .../src/main/res/drawable-mdpi/yubi_icon.png | Bin 0 -> 1715 bytes .../src/main/res/drawable-mdpi/yubi_icon_24dp.png | Bin 0 -> 753 bytes .../src/main/res/drawable-xhdpi/yubi_icon.png | Bin 0 -> 4078 bytes .../src/main/res/drawable-xhdpi/yubi_icon_24dp.png | Bin 0 -> 1715 bytes .../src/main/res/drawable-xxhdpi/yubi_icon.png | Bin 0 -> 5808 bytes .../main/res/drawable-xxhdpi/yubi_icon_24dp.png | Bin 0 -> 2854 bytes .../main/res/drawable-xxxhdpi/yubi_icon_24dp.png | Bin 0 -> 4078 bytes .../main/res/layout/create_yubikey_fragment.xml | 24 ++---- .../res/layout/create_yubikey_wait_fragment.xml | 83 +++++++++++++++++++++ 11 files changed, 88 insertions(+), 19 deletions(-) create mode 100644 OpenKeychain/src/main/res/drawable-hdpi/yubi_icon.png create mode 100644 OpenKeychain/src/main/res/drawable-hdpi/yubi_icon_24dp.png create mode 100644 OpenKeychain/src/main/res/drawable-mdpi/yubi_icon.png create mode 100644 OpenKeychain/src/main/res/drawable-mdpi/yubi_icon_24dp.png create mode 100644 OpenKeychain/src/main/res/drawable-xhdpi/yubi_icon.png create mode 100644 OpenKeychain/src/main/res/drawable-xhdpi/yubi_icon_24dp.png create mode 100644 OpenKeychain/src/main/res/drawable-xxhdpi/yubi_icon.png create mode 100644 OpenKeychain/src/main/res/drawable-xxhdpi/yubi_icon_24dp.png create mode 100644 OpenKeychain/src/main/res/drawable-xxxhdpi/yubi_icon_24dp.png create mode 100644 OpenKeychain/src/main/res/layout/create_yubikey_wait_fragment.xml (limited to 'OpenKeychain/src/main/res') diff --git a/OpenKeychain/src/main/res/drawable-hdpi/yubi_icon.png b/OpenKeychain/src/main/res/drawable-hdpi/yubi_icon.png new file mode 100644 index 000000000..428ad6fad Binary files /dev/null and b/OpenKeychain/src/main/res/drawable-hdpi/yubi_icon.png differ diff --git a/OpenKeychain/src/main/res/drawable-hdpi/yubi_icon_24dp.png b/OpenKeychain/src/main/res/drawable-hdpi/yubi_icon_24dp.png new file mode 100644 index 000000000..6fb41223d Binary files /dev/null and b/OpenKeychain/src/main/res/drawable-hdpi/yubi_icon_24dp.png differ diff --git a/OpenKeychain/src/main/res/drawable-mdpi/yubi_icon.png b/OpenKeychain/src/main/res/drawable-mdpi/yubi_icon.png new file mode 100644 index 000000000..05c21c052 Binary files /dev/null and b/OpenKeychain/src/main/res/drawable-mdpi/yubi_icon.png differ diff --git a/OpenKeychain/src/main/res/drawable-mdpi/yubi_icon_24dp.png b/OpenKeychain/src/main/res/drawable-mdpi/yubi_icon_24dp.png new file mode 100644 index 000000000..753f22607 Binary files /dev/null and b/OpenKeychain/src/main/res/drawable-mdpi/yubi_icon_24dp.png differ diff --git a/OpenKeychain/src/main/res/drawable-xhdpi/yubi_icon.png b/OpenKeychain/src/main/res/drawable-xhdpi/yubi_icon.png new file mode 100644 index 000000000..cfa799e74 Binary files /dev/null and b/OpenKeychain/src/main/res/drawable-xhdpi/yubi_icon.png differ diff --git a/OpenKeychain/src/main/res/drawable-xhdpi/yubi_icon_24dp.png b/OpenKeychain/src/main/res/drawable-xhdpi/yubi_icon_24dp.png new file mode 100644 index 000000000..05c21c052 Binary files /dev/null and b/OpenKeychain/src/main/res/drawable-xhdpi/yubi_icon_24dp.png differ diff --git a/OpenKeychain/src/main/res/drawable-xxhdpi/yubi_icon.png b/OpenKeychain/src/main/res/drawable-xxhdpi/yubi_icon.png new file mode 100644 index 000000000..f20f562ec Binary files /dev/null and b/OpenKeychain/src/main/res/drawable-xxhdpi/yubi_icon.png differ diff --git a/OpenKeychain/src/main/res/drawable-xxhdpi/yubi_icon_24dp.png b/OpenKeychain/src/main/res/drawable-xxhdpi/yubi_icon_24dp.png new file mode 100644 index 000000000..9bae15a02 Binary files /dev/null and b/OpenKeychain/src/main/res/drawable-xxhdpi/yubi_icon_24dp.png differ diff --git a/OpenKeychain/src/main/res/drawable-xxxhdpi/yubi_icon_24dp.png b/OpenKeychain/src/main/res/drawable-xxxhdpi/yubi_icon_24dp.png new file mode 100644 index 000000000..cfa799e74 Binary files /dev/null and b/OpenKeychain/src/main/res/drawable-xxxhdpi/yubi_icon_24dp.png differ diff --git a/OpenKeychain/src/main/res/layout/create_yubikey_fragment.xml b/OpenKeychain/src/main/res/layout/create_yubikey_fragment.xml index ec2505706..2fb3737ba 100644 --- a/OpenKeychain/src/main/res/layout/create_yubikey_fragment.xml +++ b/OpenKeychain/src/main/res/layout/create_yubikey_fragment.xml @@ -19,26 +19,12 @@ android:id="@+id/create_yubikey_animator" > - - - - - - - + android:layout_gravity="center" + android:indeterminate="true" + /> + + + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file -- cgit v1.2.3 From a7c52a1c9f8bca83b2981347a0eceeec68a92790 Mon Sep 17 00:00:00 2001 From: Vincent Breitmoser Date: Sun, 22 Mar 2015 02:36:10 +0100 Subject: move yubikey import into viewkeyfragment --- .../main/res/layout/create_yubikey_fragment.xml | 87 ++++--------------- .../src/main/res/layout/view_key_yubikey.xml | 98 ++++++++++++++++++++++ OpenKeychain/src/main/res/values/strings.xml | 2 + 3 files changed, 117 insertions(+), 70 deletions(-) create mode 100644 OpenKeychain/src/main/res/layout/view_key_yubikey.xml (limited to 'OpenKeychain/src/main/res') diff --git a/OpenKeychain/src/main/res/layout/create_yubikey_fragment.xml b/OpenKeychain/src/main/res/layout/create_yubikey_fragment.xml index 2fb3737ba..0f5e50d42 100644 --- a/OpenKeychain/src/main/res/layout/create_yubikey_fragment.xml +++ b/OpenKeychain/src/main/res/layout/create_yubikey_fragment.xml @@ -9,83 +9,30 @@ android:fillViewport="true" android:layout_above="@+id/create_key_buttons"> - + android:orientation="vertical"> - - - - - - - + android:layout_marginTop="16dp" + android:layout_marginLeft="8dp" + android:textAppearance="?android:attr/textAppearanceMedium" + android:id="@+id/create_yubikey_unknown_fp" + android:text="(yubikey fingerprint)" /> - - - - - - - - - - - + android:layout_marginTop="16dp" + android:layout_marginLeft="8dp" + android:textAppearance="?android:attr/textAppearanceMedium" + android:text="Hit next to import this key" + /> - + diff --git a/OpenKeychain/src/main/res/layout/view_key_yubikey.xml b/OpenKeychain/src/main/res/layout/view_key_yubikey.xml new file mode 100644 index 000000000..7da1fc5c4 --- /dev/null +++ b/OpenKeychain/src/main/res/layout/view_key_yubikey.xml @@ -0,0 +1,98 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + +