From 28b9068ae03b6c17b247a1d2fdf9b20d8a11a274 Mon Sep 17 00:00:00 2001 From: Joey Castillo Date: Wed, 13 May 2015 06:01:42 -0400 Subject: Adding keytocard flag to SubkeyChange: UI sets this flag to initiate keytocard; operation unsets it and fills in dummyDivert to finish it. --- .../keychain/ui/EditKeyFragment.java | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) (limited to 'OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/EditKeyFragment.java') diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/EditKeyFragment.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/EditKeyFragment.java index bc2fbff76..acc0c32b8 100644 --- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/EditKeyFragment.java +++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/EditKeyFragment.java @@ -429,14 +429,14 @@ public class EditKeyFragment extends CryptoOperationFragment implements SubkeyChange change = mSaveKeyringParcel.getSubkeyChange(keyId); if (change == null) { - mSaveKeyringParcel.mChangeSubKeys.add(new SubkeyChange(keyId, true, null)); + mSaveKeyringParcel.mChangeSubKeys.add(new SubkeyChange(keyId, true, false)); break; } // toggle change.mDummyStrip = !change.mDummyStrip; - if (change.mDummyStrip && change.mDummyDivert != null) { + if (change.mDummyStrip && change.mMoveKeyToCard) { // User had chosen to divert key, but now wants to strip it instead. - change.mDummyDivert = null; + change.mMoveKeyToCard = false; } break; } @@ -455,17 +455,15 @@ public class EditKeyFragment extends CryptoOperationFragment implements change = mSaveKeyringParcel.getSubkeyChange(keyId); if (change == null) { mSaveKeyringParcel.mChangeSubKeys.add( - new SubkeyChange(keyId, false, null) + new SubkeyChange(keyId, false, true) ); - change = mSaveKeyringParcel.getSubkeyChange(keyId); + break; } // toggle - if (change.mDummyDivert == null) { - change.mDummyDivert = new byte[0]; - // If user had chosen to strip key, we cancel that action now. + change.mMoveKeyToCard = !change.mMoveKeyToCard; + if (change.mMoveKeyToCard && change.mDummyStrip) { + // User had chosen to strip key, but now wants to divert it. change.mDummyStrip = false; - } else { - change.mDummyDivert = null; } break; } -- cgit v1.2.3