From e83532cb19756b3c585afa9b4a49ec1288f6fd42 Mon Sep 17 00:00:00 2001
From: iseki <iseki.m.aa@gmail.com>
Date: Wed, 25 Mar 2015 04:44:53 +0900
Subject: Add a loop for multiple key export.

---
 .../keychain/ui/KeyListFragment.java               | 81 ++++++++++++++++++----
 1 file changed, 68 insertions(+), 13 deletions(-)

diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/KeyListFragment.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/KeyListFragment.java
index 861ae12d9..8ef74a15f 100644
--- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/KeyListFragment.java
+++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/KeyListFragment.java
@@ -20,6 +20,7 @@ package org.sufficientlysecure.keychain.ui;
 
 import android.animation.ObjectAnimator;
 import android.annotation.TargetApi;
+import android.app.Activity;
 import android.app.ProgressDialog;
 import android.content.Context;
 import android.content.Intent;
@@ -71,6 +72,7 @@ import org.sufficientlysecure.keychain.provider.ProviderHelper;
 import org.sufficientlysecure.keychain.service.CloudImportService;
 import org.sufficientlysecure.keychain.service.KeychainIntentService;
 import org.sufficientlysecure.keychain.service.ServiceProgressHandler;
+import org.sufficientlysecure.keychain.service.PassphraseCacheService;
 import org.sufficientlysecure.keychain.ui.dialog.DeleteKeyDialogFragment;
 import org.sufficientlysecure.keychain.ui.dialog.ProgressDialogFragment;
 import org.sufficientlysecure.keychain.ui.util.Highlighter;
@@ -97,6 +99,9 @@ public class KeyListFragment extends LoaderFragment
         implements SearchView.OnQueryTextListener, AdapterView.OnItemClickListener,
         LoaderManager.LoaderCallbacks<Cursor>, FabContainer {
 
+    static final int REQUEST_REPEAT_PASSPHRASE = 1;
+    static final int REQUEST_ACTION = 2;
+
     ExportHelper mExportHelper;
 
     private KeyListAdapter mAdapter;
@@ -109,6 +114,11 @@ public class KeyListFragment extends LoaderFragment
 
     private FloatingActionsMenu mFab;
 
+    // This ids for multiple key export.
+    private ArrayList<Long> mIdsForRepeatAskPassphrase;
+    // This index for remembering the number of master key.
+    private int mIndex;
+
     @Override
     public void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
@@ -231,8 +241,29 @@ public class KeyListFragment extends LoaderFragment
                     }
                     case R.id.menu_key_list_multi_export: {
                         ids = mAdapter.getCurrentSelectedMasterKeyIds();
-                        ExportHelper mExportHelper = new ExportHelper(getActivity());
-                        mExportHelper.showExportKeysDialog(ids, Constants.Path.APP_DIR_FILE,
+                        mIdsForRepeatAskPassphrase = new ArrayList<Long>();
+                        for(long id: ids) {
+                            try {
+                                if (PassphraseCacheService.getCachedPassphrase(
+                                        getActivity(), id, id) == null) {
+                                    mIdsForRepeatAskPassphrase.add(Long.valueOf(id));
+                                }
+                            } catch (PassphraseCacheService.KeyNotFoundException e) {
+                                // This happens when the master key is stripped
+                                // and ignore this key.
+                                continue;
+                            }
+                        }
+                        mIndex = 0;
+                        if (mIdsForRepeatAskPassphrase.size() != 0) {
+                            startPassphraseActivity();
+                            break;
+                        }
+                        long[] idsForMultiExport = new long[mIdsForRepeatAskPassphrase.size()];
+                        for(int i=0; i<mIdsForRepeatAskPassphrase.size(); ++i)
+                            idsForMultiExport[i] = mIdsForRepeatAskPassphrase.get(i).longValue();
+                        mExportHelper.showExportKeysDialog(idsForMultiExport,
+                                Constants.Path.APP_DIR_FILE,
                                 mAdapter.isAnySecretSelected());
                         break;
                     }
@@ -383,7 +414,7 @@ public class KeyListFragment extends LoaderFragment
         intent.setAction(EncryptFilesActivity.ACTION_ENCRYPT_DATA);
         intent.putExtra(EncryptFilesActivity.EXTRA_ENCRYPTION_KEY_IDS, masterKeyIds);
         // used instead of startActivity set actionbar based on callingPackage
-        startActivityForResult(intent, 0);
+        startActivityForResult(intent, REQUEST_ACTION);
 
         mode.finish();
     }
@@ -557,18 +588,18 @@ public class KeyListFragment extends LoaderFragment
     private void scanQrCode() {
         Intent scanQrCode = new Intent(getActivity(), ImportKeysProxyActivity.class);
         scanQrCode.setAction(ImportKeysProxyActivity.ACTION_SCAN_IMPORT);
-        startActivityForResult(scanQrCode, 0);
+        startActivityForResult(scanQrCode, REQUEST_ACTION);
     }
 
     private void importFile() {
         Intent intentImportExisting = new Intent(getActivity(), ImportKeysActivity.class);
         intentImportExisting.setAction(ImportKeysActivity.ACTION_IMPORT_KEY_FROM_FILE_AND_RETURN);
-        startActivityForResult(intentImportExisting, 0);
+        startActivityForResult(intentImportExisting, REQUEST_ACTION);
     }
 
     private void createKey() {
         Intent intent = new Intent(getActivity(), CreateKeyActivity.class);
-        startActivityForResult(intent, 0);
+        startActivityForResult(intent, REQUEST_ACTION);
     }
 
     private void updateAllKeys() {
@@ -697,14 +728,38 @@ public class KeyListFragment extends LoaderFragment
         getActivity().startService(intent);
     }
 
+    private void startPassphraseActivity() {
+        Intent intent = new Intent(getActivity(), PassphraseDialogActivity.class);
+        long masterKeyId = mIdsForRepeatAskPassphrase.get(mIndex++).longValue();
+        intent.putExtra(PassphraseDialogActivity.EXTRA_SUBKEY_ID, masterKeyId);
+        startActivityForResult(intent, REQUEST_REPEAT_PASSPHRASE);
+    }
+
     @Override
     public void onActivityResult(int requestCode, int resultCode, Intent data) {
-        // if a result has been returned, display a notify
-        if (data != null && data.hasExtra(OperationResult.EXTRA_RESULT)) {
-            OperationResult result = data.getParcelableExtra(OperationResult.EXTRA_RESULT);
-            result.createNotify(getActivity()).show();
-        } else {
-            super.onActivityResult(requestCode, resultCode, data);
+        if (requestCode == REQUEST_REPEAT_PASSPHRASE) {
+            if(resultCode != Activity.RESULT_OK)
+                return;
+            if (mIndex < mIdsForRepeatAskPassphrase.size()) {
+                startPassphraseActivity();
+                return;
+            }
+            long[] idsForMultiExport = new long[mIdsForRepeatAskPassphrase.size()];
+            for(int i=0; i<mIdsForRepeatAskPassphrase.size(); ++i)
+                idsForMultiExport[i] = mIdsForRepeatAskPassphrase.get(i).longValue();
+            mExportHelper.showExportKeysDialog(idsForMultiExport,
+                    Constants.Path.APP_DIR_FILE,
+                    mAdapter.isAnySecretSelected());
+        }
+
+        if (requestCode == REQUEST_ACTION) {
+            // if a result has been returned, display a notify
+            if (data != null && data.hasExtra(OperationResult.EXTRA_RESULT)) {
+                OperationResult result = data.getParcelableExtra(OperationResult.EXTRA_RESULT);
+                result.createNotify(getActivity()).show();
+            } else {
+                super.onActivityResult(requestCode, resultCode, data);
+            }
         }
     }
 
@@ -776,7 +831,7 @@ public class KeyListFragment extends LoaderFragment
                     if (holder.mMasterKeyId != null) {
                         Intent safeSlingerIntent = new Intent(getActivity(), SafeSlingerActivity.class);
                         safeSlingerIntent.putExtra(SafeSlingerActivity.EXTRA_MASTER_KEY_ID, holder.mMasterKeyId);
-                        startActivityForResult(safeSlingerIntent, 0);
+                        startActivityForResult(safeSlingerIntent, REQUEST_ACTION);
                     }
                 }
             });
-- 
cgit v1.2.3


From 59a446d7f41324ace6fbb573933d5c4f4a8350e1 Mon Sep 17 00:00:00 2001
From: iseki <iseki.m.aa@gmail.com>
Date: Thu, 26 Mar 2015 11:59:18 +0900
Subject: Add brackets for if-else constructs and externalize the procedure as
 showMultiExportDialog.

---
 .../keychain/ui/KeyListFragment.java               | 59 ++++++++++++----------
 1 file changed, 33 insertions(+), 26 deletions(-)

diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/KeyListFragment.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/KeyListFragment.java
index 8ef74a15f..9239a5466 100644
--- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/KeyListFragment.java
+++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/KeyListFragment.java
@@ -241,30 +241,7 @@ public class KeyListFragment extends LoaderFragment
                     }
                     case R.id.menu_key_list_multi_export: {
                         ids = mAdapter.getCurrentSelectedMasterKeyIds();
-                        mIdsForRepeatAskPassphrase = new ArrayList<Long>();
-                        for(long id: ids) {
-                            try {
-                                if (PassphraseCacheService.getCachedPassphrase(
-                                        getActivity(), id, id) == null) {
-                                    mIdsForRepeatAskPassphrase.add(Long.valueOf(id));
-                                }
-                            } catch (PassphraseCacheService.KeyNotFoundException e) {
-                                // This happens when the master key is stripped
-                                // and ignore this key.
-                                continue;
-                            }
-                        }
-                        mIndex = 0;
-                        if (mIdsForRepeatAskPassphrase.size() != 0) {
-                            startPassphraseActivity();
-                            break;
-                        }
-                        long[] idsForMultiExport = new long[mIdsForRepeatAskPassphrase.size()];
-                        for(int i=0; i<mIdsForRepeatAskPassphrase.size(); ++i)
-                            idsForMultiExport[i] = mIdsForRepeatAskPassphrase.get(i).longValue();
-                        mExportHelper.showExportKeysDialog(idsForMultiExport,
-                                Constants.Path.APP_DIR_FILE,
-                                mAdapter.isAnySecretSelected());
+                        showMultiExportDialog(ids);
                         break;
                     }
                     case R.id.menu_key_list_multi_select_all: {
@@ -728,6 +705,34 @@ public class KeyListFragment extends LoaderFragment
         getActivity().startService(intent);
     }
 
+    private void showMultiExportDialog(long[] masterKeyIds) {
+        mIdsForRepeatAskPassphrase = new ArrayList<Long>();
+        for(long id: masterKeyIds) {
+            try {
+                if (PassphraseCacheService.getCachedPassphrase(
+                        getActivity(), id, id) == null) {
+                    mIdsForRepeatAskPassphrase.add(Long.valueOf(id));
+                }
+            } catch (PassphraseCacheService.KeyNotFoundException e) {
+                // This happens when the master key is stripped
+                // and ignore this key.
+                continue;
+            }
+        }
+        mIndex = 0;
+        if (mIdsForRepeatAskPassphrase.size() != 0) {
+            startPassphraseActivity();
+            break;
+        }
+        long[] idsForMultiExport = new long[mIdsForRepeatAskPassphrase.size()];
+        for(int i=0; i<mIdsForRepeatAskPassphrase.size(); ++i) {
+            idsForMultiExport[i] = mIdsForRepeatAskPassphrase.get(i).longValue();
+        }
+        mExportHelper.showExportKeysDialog(idsForMultiExport,
+                Constants.Path.APP_DIR_FILE,
+                mAdapter.isAnySecretSelected());
+    }
+
     private void startPassphraseActivity() {
         Intent intent = new Intent(getActivity(), PassphraseDialogActivity.class);
         long masterKeyId = mIdsForRepeatAskPassphrase.get(mIndex++).longValue();
@@ -738,15 +743,17 @@ public class KeyListFragment extends LoaderFragment
     @Override
     public void onActivityResult(int requestCode, int resultCode, Intent data) {
         if (requestCode == REQUEST_REPEAT_PASSPHRASE) {
-            if(resultCode != Activity.RESULT_OK)
+            if(resultCode != Activity.RESULT_OK) {
                 return;
+            }
             if (mIndex < mIdsForRepeatAskPassphrase.size()) {
                 startPassphraseActivity();
                 return;
             }
             long[] idsForMultiExport = new long[mIdsForRepeatAskPassphrase.size()];
-            for(int i=0; i<mIdsForRepeatAskPassphrase.size(); ++i)
+            for(int i=0; i<mIdsForRepeatAskPassphrase.size(); ++i) {
                 idsForMultiExport[i] = mIdsForRepeatAskPassphrase.get(i).longValue();
+            }
             mExportHelper.showExportKeysDialog(idsForMultiExport,
                     Constants.Path.APP_DIR_FILE,
                     mAdapter.isAnySecretSelected());
-- 
cgit v1.2.3


From 621e7401a8e691bed3da40f19586d99ea8426e4a Mon Sep 17 00:00:00 2001
From: iseki <iseki.m.aa@gmail.com>
Date: Thu, 26 Mar 2015 12:18:41 +0900
Subject: Modify break as return.

---
 .../main/java/org/sufficientlysecure/keychain/ui/KeyListFragment.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/KeyListFragment.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/KeyListFragment.java
index 9239a5466..5035c2793 100644
--- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/KeyListFragment.java
+++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/KeyListFragment.java
@@ -722,7 +722,7 @@ public class KeyListFragment extends LoaderFragment
         mIndex = 0;
         if (mIdsForRepeatAskPassphrase.size() != 0) {
             startPassphraseActivity();
-            break;
+            return;
         }
         long[] idsForMultiExport = new long[mIdsForRepeatAskPassphrase.size()];
         for(int i=0; i<mIdsForRepeatAskPassphrase.size(); ++i) {
-- 
cgit v1.2.3