From 7366f14d32dc5df6a1035450d968eab8fcbdc5c1 Mon Sep 17 00:00:00 2001 From: moparisthebest Date: Mon, 22 Jun 2015 22:40:15 -0400 Subject: New all-white status bar icon to fix issue #1356 --- Graphics/drawables/ic_stat_notify.svg | 51 +++++++++++++++++++++ .../src/debug/res/drawable-hdpi/ic_stat_notify.png | Bin 0 -> 1818 bytes .../src/debug/res/drawable-mdpi/ic_stat_notify.png | Bin 0 -> 1181 bytes .../debug/res/drawable-xhdpi/ic_stat_notify.png | Bin 0 -> 2516 bytes .../debug/res/drawable-xxhdpi/ic_stat_notify.png | Bin 0 -> 3725 bytes .../debug/res/drawable-xxxhdpi/ic_stat_notify.png | Bin 0 -> 5052 bytes .../keychain/service/PassphraseCacheService.java | 23 +++++++++- .../src/main/res/drawable-hdpi/ic_stat_notify.png | Bin 0 -> 1818 bytes .../src/main/res/drawable-mdpi/ic_stat_notify.png | Bin 0 -> 1181 bytes .../src/main/res/drawable-xhdpi/ic_stat_notify.png | Bin 0 -> 2516 bytes .../main/res/drawable-xxhdpi/ic_stat_notify.png | Bin 0 -> 3725 bytes .../main/res/drawable-xxxhdpi/ic_stat_notify.png | Bin 0 -> 5052 bytes README.md | 9 ++-- 13 files changed, 78 insertions(+), 5 deletions(-) create mode 100644 Graphics/drawables/ic_stat_notify.svg create mode 100644 OpenKeychain/src/debug/res/drawable-hdpi/ic_stat_notify.png create mode 100644 OpenKeychain/src/debug/res/drawable-mdpi/ic_stat_notify.png create mode 100644 OpenKeychain/src/debug/res/drawable-xhdpi/ic_stat_notify.png create mode 100644 OpenKeychain/src/debug/res/drawable-xxhdpi/ic_stat_notify.png create mode 100644 OpenKeychain/src/debug/res/drawable-xxxhdpi/ic_stat_notify.png create mode 100644 OpenKeychain/src/main/res/drawable-hdpi/ic_stat_notify.png create mode 100644 OpenKeychain/src/main/res/drawable-mdpi/ic_stat_notify.png create mode 100644 OpenKeychain/src/main/res/drawable-xhdpi/ic_stat_notify.png create mode 100644 OpenKeychain/src/main/res/drawable-xxhdpi/ic_stat_notify.png create mode 100644 OpenKeychain/src/main/res/drawable-xxxhdpi/ic_stat_notify.png diff --git a/Graphics/drawables/ic_stat_notify.svg b/Graphics/drawables/ic_stat_notify.svg new file mode 100644 index 000000000..11d326e06 --- /dev/null +++ b/Graphics/drawables/ic_stat_notify.svg @@ -0,0 +1,51 @@ + +image/svg+xml \ No newline at end of file diff --git a/OpenKeychain/src/debug/res/drawable-hdpi/ic_stat_notify.png b/OpenKeychain/src/debug/res/drawable-hdpi/ic_stat_notify.png new file mode 100644 index 000000000..b31481995 Binary files /dev/null and b/OpenKeychain/src/debug/res/drawable-hdpi/ic_stat_notify.png differ diff --git a/OpenKeychain/src/debug/res/drawable-mdpi/ic_stat_notify.png b/OpenKeychain/src/debug/res/drawable-mdpi/ic_stat_notify.png new file mode 100644 index 000000000..39e799e5a Binary files /dev/null and b/OpenKeychain/src/debug/res/drawable-mdpi/ic_stat_notify.png differ diff --git a/OpenKeychain/src/debug/res/drawable-xhdpi/ic_stat_notify.png b/OpenKeychain/src/debug/res/drawable-xhdpi/ic_stat_notify.png new file mode 100644 index 000000000..af1613d40 Binary files /dev/null and b/OpenKeychain/src/debug/res/drawable-xhdpi/ic_stat_notify.png differ diff --git a/OpenKeychain/src/debug/res/drawable-xxhdpi/ic_stat_notify.png b/OpenKeychain/src/debug/res/drawable-xxhdpi/ic_stat_notify.png new file mode 100644 index 000000000..9da107396 Binary files /dev/null and b/OpenKeychain/src/debug/res/drawable-xxhdpi/ic_stat_notify.png differ diff --git a/OpenKeychain/src/debug/res/drawable-xxxhdpi/ic_stat_notify.png b/OpenKeychain/src/debug/res/drawable-xxxhdpi/ic_stat_notify.png new file mode 100644 index 000000000..5c81db8bf Binary files /dev/null and b/OpenKeychain/src/debug/res/drawable-xxxhdpi/ic_stat_notify.png differ diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/service/PassphraseCacheService.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/service/PassphraseCacheService.java index dbbfe3133..9679cb7bc 100644 --- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/service/PassphraseCacheService.java +++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/service/PassphraseCacheService.java @@ -36,6 +36,9 @@ import android.os.Messenger; import android.os.RemoteException; import android.support.v4.app.NotificationCompat; import android.support.v4.util.LongSparseArray; +import android.graphics.Bitmap; +import android.graphics.Canvas; +import android.graphics.drawable.Drawable; import org.sufficientlysecure.keychain.Constants; import org.sufficientlysecure.keychain.R; @@ -474,11 +477,26 @@ public class PassphraseCacheService extends Service { } } + // from de.azapps.mirakel.helper.Helpers from https://github.com/MirakelX/mirakel-android + private static Bitmap getBitmap(int resId, Context ctx) { + final int mLargeIconWidth = (int) ctx.getResources().getDimension( + android.R.dimen.notification_large_icon_width); + final int mLargeIconHeight = (int) ctx.getResources().getDimension( + android.R.dimen.notification_large_icon_height); + final Drawable d = ctx.getResources().getDrawable(resId); + final Bitmap b = Bitmap.createBitmap(mLargeIconWidth, mLargeIconHeight, Bitmap.Config.ARGB_8888); + final Canvas c = new Canvas(b); + d.setBounds(0, 0, mLargeIconWidth, mLargeIconHeight); + d.draw(c); + return b; + } + private Notification getNotification() { NotificationCompat.Builder builder = new NotificationCompat.Builder(this); if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN) { - builder.setSmallIcon(R.drawable.ic_launcher) + builder.setSmallIcon(R.drawable.ic_stat_notify) + .setLargeIcon(getBitmap(R.drawable.ic_launcher, getBaseContext())) .setContentTitle(getString(R.string.app_name)) .setContentText(String.format(getString(R.string.passp_cache_notif_n_keys), mPassphraseCache.size())); @@ -510,7 +528,8 @@ public class PassphraseCacheService extends Service { ); } else { // Fallback, since expandable notifications weren't available back then - builder.setSmallIcon(R.drawable.ic_launcher) + builder.setSmallIcon(R.drawable.ic_stat_notify) + .setLargeIcon(getBitmap(R.drawable.ic_launcher, getBaseContext())) .setContentTitle(String.format(getString(R.string.passp_cache_notif_n_keys), mPassphraseCache.size())) .setContentText(getString(R.string.passp_cache_notif_click_to_clear)); diff --git a/OpenKeychain/src/main/res/drawable-hdpi/ic_stat_notify.png b/OpenKeychain/src/main/res/drawable-hdpi/ic_stat_notify.png new file mode 100644 index 000000000..b31481995 Binary files /dev/null and b/OpenKeychain/src/main/res/drawable-hdpi/ic_stat_notify.png differ diff --git a/OpenKeychain/src/main/res/drawable-mdpi/ic_stat_notify.png b/OpenKeychain/src/main/res/drawable-mdpi/ic_stat_notify.png new file mode 100644 index 000000000..39e799e5a Binary files /dev/null and b/OpenKeychain/src/main/res/drawable-mdpi/ic_stat_notify.png differ diff --git a/OpenKeychain/src/main/res/drawable-xhdpi/ic_stat_notify.png b/OpenKeychain/src/main/res/drawable-xhdpi/ic_stat_notify.png new file mode 100644 index 000000000..af1613d40 Binary files /dev/null and b/OpenKeychain/src/main/res/drawable-xhdpi/ic_stat_notify.png differ diff --git a/OpenKeychain/src/main/res/drawable-xxhdpi/ic_stat_notify.png b/OpenKeychain/src/main/res/drawable-xxhdpi/ic_stat_notify.png new file mode 100644 index 000000000..9da107396 Binary files /dev/null and b/OpenKeychain/src/main/res/drawable-xxhdpi/ic_stat_notify.png differ diff --git a/OpenKeychain/src/main/res/drawable-xxxhdpi/ic_stat_notify.png b/OpenKeychain/src/main/res/drawable-xxxhdpi/ic_stat_notify.png new file mode 100644 index 000000000..5c81db8bf Binary files /dev/null and b/OpenKeychain/src/main/res/drawable-xxxhdpi/ic_stat_notify.png differ diff --git a/README.md b/README.md index 7a75b5ec8..87d8fcefd 100644 --- a/README.md +++ b/README.md @@ -204,15 +204,18 @@ See [In-app about screen](https://github.com/open-keychain/open-keychain/blob/HE ### Images * icon.svg modified version of kgpg_key2_kopete.svgz - + +* ic_stat_notify.svg + modified version of Key by Egor Culcea from the Noun Project https://thenounproject.com/term/key/2511/ + * Actionbar icons http://developer.android.com/design/downloads/index.html#action-bar-icon-pack - + * QR Code Actionbar icon https://github.com/openintents/openintents/blob/master/extensions/qrcode_ext/icons/ic_menu_qr_code/ic_menu_qr_code_holo_light/ic_menu_qr_code.svg * Key status icons by the ModernPGP working group https://github.com/ModernPGP - + * Purple color scheme http://android-holo-colors.com/ -- cgit v1.2.3 From 8cd7e295404fdfad5167b96fdf3a5cbeca8e4cd1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dominik=20Sch=C3=BCrmann?= Date: Wed, 24 Jun 2015 11:35:11 +0200 Subject: New notify icon --- Graphics/drawables/ic_stat_notify.svg | 62 +++++++++++++-------- Graphics/update-drawables.sh | 2 +- .../keychain/service/PassphraseCacheService.java | 2 +- .../src/main/res/drawable-hdpi/ic_stat_notify.png | Bin 1818 -> 0 bytes .../main/res/drawable-hdpi/ic_stat_notify_24dp.png | Bin 0 -> 919 bytes .../src/main/res/drawable-mdpi/ic_stat_notify.png | Bin 1181 -> 0 bytes .../main/res/drawable-mdpi/ic_stat_notify_24dp.png | Bin 0 -> 654 bytes .../src/main/res/drawable-xhdpi/ic_stat_notify.png | Bin 2516 -> 0 bytes .../res/drawable-xhdpi/ic_stat_notify_24dp.png | Bin 0 -> 1249 bytes .../main/res/drawable-xxhdpi/ic_stat_notify.png | Bin 3725 -> 0 bytes .../res/drawable-xxhdpi/ic_stat_notify_24dp.png | Bin 0 -> 1948 bytes .../main/res/drawable-xxxhdpi/ic_stat_notify.png | Bin 5052 -> 0 bytes .../res/drawable-xxxhdpi/ic_stat_notify_24dp.png | Bin 0 -> 2710 bytes README.md | 9 --- 14 files changed, 40 insertions(+), 35 deletions(-) delete mode 100644 OpenKeychain/src/main/res/drawable-hdpi/ic_stat_notify.png create mode 100644 OpenKeychain/src/main/res/drawable-hdpi/ic_stat_notify_24dp.png delete mode 100644 OpenKeychain/src/main/res/drawable-mdpi/ic_stat_notify.png create mode 100644 OpenKeychain/src/main/res/drawable-mdpi/ic_stat_notify_24dp.png delete mode 100644 OpenKeychain/src/main/res/drawable-xhdpi/ic_stat_notify.png create mode 100644 OpenKeychain/src/main/res/drawable-xhdpi/ic_stat_notify_24dp.png delete mode 100644 OpenKeychain/src/main/res/drawable-xxhdpi/ic_stat_notify.png create mode 100644 OpenKeychain/src/main/res/drawable-xxhdpi/ic_stat_notify_24dp.png delete mode 100644 OpenKeychain/src/main/res/drawable-xxxhdpi/ic_stat_notify.png create mode 100644 OpenKeychain/src/main/res/drawable-xxxhdpi/ic_stat_notify_24dp.png diff --git a/Graphics/drawables/ic_stat_notify.svg b/Graphics/drawables/ic_stat_notify.svg index 11d326e06..ae82d7147 100644 --- a/Graphics/drawables/ic_stat_notify.svg +++ b/Graphics/drawables/ic_stat_notify.svg @@ -1,4 +1,6 @@ + + image/svg+xml \ No newline at end of file + id="path14" + d="m 415.298,-360.17398 -79.39409,79.13921 c -47.06722,-48.09353 -70.60084,-105.92166 -70.60084,-173.48607 0,-0.28376 0,-0.53694 0,-0.76463 0.15123,-61.1806 19.69177,-114.42094 58.62164,-159.72272 3.23693,-3.76198 6.6064,-7.47128 10.11011,-11.12961 1.36784,-1.42222 2.75606,-2.83933 4.16298,-4.24795 7.6463,-7.6463 15.60525,-14.72677 23.87345,-21.23972 0.28037,-0.2209 0.56413,-0.44859 0.84959,-0.67967 0.57093,-0.44859 1.13675,-0.88697 1.69918,-1.31687 0.26167,-0.2022 0.51655,-0.3993 0.76463,-0.59471 l 22.34419,-15.20764 c 1.27778,-0.77823 2.56746,-1.54286 3.86563,-2.29389 l 0,0.0425 c 0.69666,-0.40441 1.38993,-0.81391 2.08149,-1.23191 l 2.08149,-1.14694 c 0.79692,-0.4248 1.58874,-0.84959 2.37885,-1.27438 7.68708,-4.10522 15.56108,-7.75675 23.61858,-10.9597 6.87317,-2.72039 13.88398,-5.11283 21.02732,-7.17903 1.99994,-0.57772 4.01006,-1.12995 6.03208,-1.6567 20.62972,-5.38129 42.3775,-8.07109 65.24844,-8.07109 15.63073,0 30.72623,1.27438 45.28139,3.82315 5.09753,0.84959 10.19507,1.89798 15.2926,3.14348 12.84069,3.08401 25.25828,7.18922 37.25447,12.31904 23.88359,7.88391 -10.10015,24.79841 4.817,34.16003 -4.83471,78.85212 20.58246,73.23946 -44.79016,57.68053 -0.3959,-0.11214 -0.76463,-0.1988 -1.10446,-0.25487 -2.43662,-0.56583 -4.9548,-1.07558 -7.56134,-1.52926 -0.33814,-0.0561 -0.59472,-0.085 -0.76293,-0.085 -9.00735,-1.18943 -14.01822,-1.81303 -15.03943,-1.8691 l -0.085,0 c -32.2283,-2.15286 -61.39809,4.72881 -87.50766,20.64501 -7.19262,4.36179 -14.13036,9.43044 -20.81493,15.20765 -0.16992,0.11214 -0.28376,0.25487 -0.33983,0.42479 -0.22599,0.16992 -0.48087,0.39591 -0.76463,0.67967 -0.90057,0.78502 -1.79433,1.57854 -2.67451,2.37885 -3.48501,3.17576 -6.76952,6.46197 -9.85523,9.85523 -2.0628,-2.54707 -4.00156,-5.15191 -5.81969,-7.81622 1.73147,-1.93536 3.03304,-3.9166 3.90811,-5.94712 0.73745,-1.47489 1.33216,-3.00415 1.78414,-4.58778 0.79352,-2.6762 1.18943,-5.50704 1.18943,-8.49589 0,-7.49337 -2.46381,-14.00802 -7.39143,-19.54054 l -0.25488,-0.29736 c -0.12064,-0.11215 -0.27696,-0.26847 -0.46727,-0.46727 -0.11724,-0.12914 -0.24468,-0.27017 -0.38231,-0.4248 -0.0867,-0.0867 -0.17332,-0.17162 -0.25488,-0.25488 -1.07558,-1.07558 -2.23782,-2.0679 -3.48332,-2.97356 -3.84014,-2.8801 -8.10168,-4.63535 -12.78631,-5.26745 l -0.0425,0 c -0.73404,-0.16992 -1.52586,-0.25318 -2.37885,-0.25488 -0.73744,-0.11214 -1.47318,-0.16991 -2.20893,-0.16991 -0.56583,0 -1.10446,0.0578 -1.61422,0.16991 -1.13335,0 -2.23782,0.085 -3.31339,0.25488 l -0.085,0 c -0.43499,0.0697 -0.85979,0.15463 -1.27439,0.25488 l -3.73819,1.0195 c -0.74764,0.28037 -1.48508,0.59132 -2.20893,0.93455 -0.1988,0.085 -0.39591,0.16992 -0.59471,0.25488 -2.94128,1.35594 -5.66166,3.28111 -8.15606,5.7772 -0.33983,0.33984 -0.65078,0.70856 -0.93454,1.10447 -0.10535,0.11215 -0.20391,0.22599 -0.29736,0.33984 -3.23523,3.59715 -5.40169,7.6463 -6.49936,12.14912 -0.56582,2.37885 -0.84958,4.84265 -0.84958,7.39142 0,5.9896 1.54285,11.32842 4.63026,16.01475 1.11466,1.68049 2.43152,3.28112 3.95058,4.80018 2.57766,2.57765 5.3813,4.58778 8.41093,6.03208 3.82825,1.81302 8.02012,2.71869 12.57392,2.71869 3.58357,0 6.93944,-0.55224 10.06763,-1.6567 2.71699,3.67532 5.66336,7.25719 8.83573,10.7473 0.0663,-0.0901 0.13763,-0.17502 0.21239,-0.25488 -0.6066,0.81221 -1.20302,1.63291 -1.78413,2.46381 -1.18943,1.69918 -2.29389,3.39836 -3.3134,5.09753 -2.71869,4.1358 -5.23857,8.43982 -7.56134,12.91545 -0.0272,0.0561 -0.0561,0.11215 -0.085,0.16992 -1.72297,3.56997 -3.33719,7.16544 -4.84266,10.78978 -1.07558,2.72039 -2.0662,5.49344 -2.97356,8.32597 -3.85204,11.83818 -6.25807,24.44098 -7.22151,37.80671 -2.58614,36.25366 6.46198,68.69437 27.14437,97.31872 z m 272.71805,-271.95343 c -67.56645,59.01822 -26.3037,18.5581 -51.23021,-39.29349 18.15062,10.49243 35.22566,23.59139 51.23021,39.29349 z m -170.04522,100.93117 c -0.0969,-0.11724 -0.19541,-0.23109 -0.29736,-0.33983 0.43159,0.29905 0.85638,0.61 1.27438,0.93454 -0.32284,-0.2056 -0.64738,-0.4044 -0.97702,-0.59471 z" + clip-rule="evenodd" + sodipodi:nodetypes="ccscccccccccccccccccscccccccccccccccccccscccccccccscccccccccccscscsccccccccccccccccccc" /> \ No newline at end of file diff --git a/Graphics/update-drawables.sh b/Graphics/update-drawables.sh index 61dc51099..5acfba19a 100755 --- a/Graphics/update-drawables.sh +++ b/Graphics/update-drawables.sh @@ -22,7 +22,7 @@ SRC_DIR=./drawables/ #inkscape -w 512 -h 512 -e "$PLAY_DIR/$NAME.png" $NAME.svg -for NAME in "ic_cloud_search" "ic_action_encrypt_file" "ic_action_encrypt_text" "ic_action_verified_cutout" "ic_action_encrypt_copy" "ic_action_encrypt_save" "ic_action_encrypt_share" "status_lock_closed" "status_lock_error" "status_lock_open" "status_signature_expired_cutout" "status_signature_invalid_cutout" "status_signature_revoked_cutout" "status_signature_unknown_cutout" "status_signature_unverified_cutout" "status_signature_verified_cutout" "key_flag_authenticate" "key_flag_certify" "key_flag_encrypt" "key_flag_sign" "yubi_icon" +for NAME in "ic_cloud_search" "ic_action_encrypt_file" "ic_action_encrypt_text" "ic_action_verified_cutout" "ic_action_encrypt_copy" "ic_action_encrypt_save" "ic_action_encrypt_share" "status_lock_closed" "status_lock_error" "status_lock_open" "status_signature_expired_cutout" "status_signature_invalid_cutout" "status_signature_revoked_cutout" "status_signature_unknown_cutout" "status_signature_unverified_cutout" "status_signature_verified_cutout" "key_flag_authenticate" "key_flag_certify" "key_flag_encrypt" "key_flag_sign" "yubi_icon" "ic_stat_notify" do echo $NAME inkscape -w 24 -h 24 -e "$MDPI_DIR/${NAME}_24dp.png" "$SRC_DIR/$NAME.svg" diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/service/PassphraseCacheService.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/service/PassphraseCacheService.java index 9679cb7bc..8edd657b5 100644 --- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/service/PassphraseCacheService.java +++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/service/PassphraseCacheService.java @@ -495,7 +495,7 @@ public class PassphraseCacheService extends Service { NotificationCompat.Builder builder = new NotificationCompat.Builder(this); if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN) { - builder.setSmallIcon(R.drawable.ic_stat_notify) + builder.setSmallIcon(R.drawable.ic_stat_notify_24dp) .setLargeIcon(getBitmap(R.drawable.ic_launcher, getBaseContext())) .setContentTitle(getString(R.string.app_name)) .setContentText(String.format(getString(R.string.passp_cache_notif_n_keys), diff --git a/OpenKeychain/src/main/res/drawable-hdpi/ic_stat_notify.png b/OpenKeychain/src/main/res/drawable-hdpi/ic_stat_notify.png deleted file mode 100644 index b31481995..000000000 Binary files a/OpenKeychain/src/main/res/drawable-hdpi/ic_stat_notify.png and /dev/null differ diff --git a/OpenKeychain/src/main/res/drawable-hdpi/ic_stat_notify_24dp.png b/OpenKeychain/src/main/res/drawable-hdpi/ic_stat_notify_24dp.png new file mode 100644 index 000000000..2b7f41971 Binary files /dev/null and b/OpenKeychain/src/main/res/drawable-hdpi/ic_stat_notify_24dp.png differ diff --git a/OpenKeychain/src/main/res/drawable-mdpi/ic_stat_notify.png b/OpenKeychain/src/main/res/drawable-mdpi/ic_stat_notify.png deleted file mode 100644 index 39e799e5a..000000000 Binary files a/OpenKeychain/src/main/res/drawable-mdpi/ic_stat_notify.png and /dev/null differ diff --git a/OpenKeychain/src/main/res/drawable-mdpi/ic_stat_notify_24dp.png b/OpenKeychain/src/main/res/drawable-mdpi/ic_stat_notify_24dp.png new file mode 100644 index 000000000..c24b41148 Binary files /dev/null and b/OpenKeychain/src/main/res/drawable-mdpi/ic_stat_notify_24dp.png differ diff --git a/OpenKeychain/src/main/res/drawable-xhdpi/ic_stat_notify.png b/OpenKeychain/src/main/res/drawable-xhdpi/ic_stat_notify.png deleted file mode 100644 index af1613d40..000000000 Binary files a/OpenKeychain/src/main/res/drawable-xhdpi/ic_stat_notify.png and /dev/null differ diff --git a/OpenKeychain/src/main/res/drawable-xhdpi/ic_stat_notify_24dp.png b/OpenKeychain/src/main/res/drawable-xhdpi/ic_stat_notify_24dp.png new file mode 100644 index 000000000..b9198e624 Binary files /dev/null and b/OpenKeychain/src/main/res/drawable-xhdpi/ic_stat_notify_24dp.png differ diff --git a/OpenKeychain/src/main/res/drawable-xxhdpi/ic_stat_notify.png b/OpenKeychain/src/main/res/drawable-xxhdpi/ic_stat_notify.png deleted file mode 100644 index 9da107396..000000000 Binary files a/OpenKeychain/src/main/res/drawable-xxhdpi/ic_stat_notify.png and /dev/null differ diff --git a/OpenKeychain/src/main/res/drawable-xxhdpi/ic_stat_notify_24dp.png b/OpenKeychain/src/main/res/drawable-xxhdpi/ic_stat_notify_24dp.png new file mode 100644 index 000000000..8ff2b8041 Binary files /dev/null and b/OpenKeychain/src/main/res/drawable-xxhdpi/ic_stat_notify_24dp.png differ diff --git a/OpenKeychain/src/main/res/drawable-xxxhdpi/ic_stat_notify.png b/OpenKeychain/src/main/res/drawable-xxxhdpi/ic_stat_notify.png deleted file mode 100644 index 5c81db8bf..000000000 Binary files a/OpenKeychain/src/main/res/drawable-xxxhdpi/ic_stat_notify.png and /dev/null differ diff --git a/OpenKeychain/src/main/res/drawable-xxxhdpi/ic_stat_notify_24dp.png b/OpenKeychain/src/main/res/drawable-xxxhdpi/ic_stat_notify_24dp.png new file mode 100644 index 000000000..9dad48842 Binary files /dev/null and b/OpenKeychain/src/main/res/drawable-xxxhdpi/ic_stat_notify_24dp.png differ diff --git a/README.md b/README.md index 87d8fcefd..d4bb8dfe3 100644 --- a/README.md +++ b/README.md @@ -202,12 +202,6 @@ Some parts and some libraries are Apache License v2, MIT X11 License (see below) See [In-app about screen](https://github.com/open-keychain/open-keychain/blob/HEAD/OpenKeychain/src/main/res/raw/help_about.md) ### Images -* icon.svg - modified version of kgpg_key2_kopete.svgz - -* ic_stat_notify.svg - modified version of Key by Egor Culcea from the Noun Project https://thenounproject.com/term/key/2511/ - * Actionbar icons http://developer.android.com/design/downloads/index.html#action-bar-icon-pack @@ -216,6 +210,3 @@ See [In-app about screen](https://github.com/open-keychain/open-keychain/blob/HE * Key status icons by the ModernPGP working group https://github.com/ModernPGP - -* Purple color scheme - http://android-holo-colors.com/ -- cgit v1.2.3 From 74cef32d258fc362559b13eb450581fe37496acb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dominik=20Sch=C3=BCrmann?= Date: Wed, 24 Jun 2015 13:08:37 +0200 Subject: Notification: follow design guidelines, fix #1313 --- .../keychain/service/PassphraseCacheService.java | 79 +++++++++------------- OpenKeychain/src/main/res/values/strings.xml | 9 ++- 2 files changed, 37 insertions(+), 51 deletions(-) diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/service/PassphraseCacheService.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/service/PassphraseCacheService.java index 8edd657b5..c1aa1bb3b 100644 --- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/service/PassphraseCacheService.java +++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/service/PassphraseCacheService.java @@ -493,59 +493,42 @@ public class PassphraseCacheService extends Service { private Notification getNotification() { NotificationCompat.Builder builder = new NotificationCompat.Builder(this); + builder.setSmallIcon(R.drawable.ic_stat_notify_24dp) + .setLargeIcon(getBitmap(R.drawable.ic_launcher, getBaseContext())) + .setContentTitle(getResources().getQuantityString(R.plurals.passp_cache_notif_n_keys, + mPassphraseCache.size(), mPassphraseCache.size())) + .setContentText(getString(R.string.passp_cache_notif_click_to_clear)); - if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN) { - builder.setSmallIcon(R.drawable.ic_stat_notify_24dp) - .setLargeIcon(getBitmap(R.drawable.ic_launcher, getBaseContext())) - .setContentTitle(getString(R.string.app_name)) - .setContentText(String.format(getString(R.string.passp_cache_notif_n_keys), - mPassphraseCache.size())); + NotificationCompat.InboxStyle inboxStyle = new NotificationCompat.InboxStyle(); - NotificationCompat.InboxStyle inboxStyle = new NotificationCompat.InboxStyle(); + inboxStyle.setBigContentTitle(getString(R.string.passp_cache_notif_keys)); - inboxStyle.setBigContentTitle(getString(R.string.passp_cache_notif_keys)); + // Moves events into the big view + for (int i = 0; i < mPassphraseCache.size(); i++) { + inboxStyle.addLine(mPassphraseCache.valueAt(i).getPrimaryUserID()); + } - // Moves events into the big view - for (int i = 0; i < mPassphraseCache.size(); i++) { - inboxStyle.addLine(mPassphraseCache.valueAt(i).getPrimaryUserID()); - } + // Moves the big view style object into the notification object. + builder.setStyle(inboxStyle); - // Moves the big view style object into the notification object. - builder.setStyle(inboxStyle); - - // Add purging action - Intent intent = new Intent(getApplicationContext(), PassphraseCacheService.class); - intent.setAction(ACTION_PASSPHRASE_CACHE_CLEAR); - builder.addAction( - R.drawable.abc_ic_clear_mtrl_alpha, - getString(R.string.passp_cache_notif_clear), - PendingIntent.getService( - getApplicationContext(), - 0, - intent, - PendingIntent.FLAG_UPDATE_CURRENT - ) - ); - } else { - // Fallback, since expandable notifications weren't available back then - builder.setSmallIcon(R.drawable.ic_stat_notify) - .setLargeIcon(getBitmap(R.drawable.ic_launcher, getBaseContext())) - .setContentTitle(String.format(getString(R.string.passp_cache_notif_n_keys), - mPassphraseCache.size())) - .setContentText(getString(R.string.passp_cache_notif_click_to_clear)); - - Intent intent = new Intent(getApplicationContext(), PassphraseCacheService.class); - intent.setAction(ACTION_PASSPHRASE_CACHE_CLEAR); - - builder.setContentIntent( - PendingIntent.getService( - getApplicationContext(), - 0, - intent, - PendingIntent.FLAG_UPDATE_CURRENT - ) - ); - } + Intent intent = new Intent(getApplicationContext(), PassphraseCacheService.class); + intent.setAction(ACTION_PASSPHRASE_CACHE_CLEAR); + PendingIntent clearCachePi = PendingIntent.getService( + getApplicationContext(), + 0, + intent, + PendingIntent.FLAG_UPDATE_CURRENT + ); + + // Add cache clear PI to normal touch + builder.setContentIntent(clearCachePi); + + // Add clear PI action below text + builder.addAction( + R.drawable.abc_ic_clear_mtrl_alpha, + getString(R.string.passp_cache_notif_clear), + clearCachePi + ); return builder.build(); } diff --git a/OpenKeychain/src/main/res/values/strings.xml b/OpenKeychain/src/main/res/values/strings.xml index da632d2d5..65ef1e687 100644 --- a/OpenKeychain/src/main/res/values/strings.xml +++ b/OpenKeychain/src/main/res/values/strings.xml @@ -1221,9 +1221,12 @@ "Log exported successfully!" - "Click to clear cached passwords" - "OpenKeychain has cached %d passwords" - "Cached Passwords:" + "Touch to clear password cache." + + "%d password cached" + "%d passwords cached" + + "Cached passwords" "Clear Cache" "Password" -- cgit v1.2.3 From c748b3e89696db07c0c4baa995184f6fdf2925f9 Mon Sep 17 00:00:00 2001 From: Adithya Abraham Philip Date: Thu, 25 Jun 2015 08:40:07 +0530 Subject: fixed fingerprint mismatch issue --- .../main/java/org/sufficientlysecure/keychain/pgp/UncachedKeyRing.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/pgp/UncachedKeyRing.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/pgp/UncachedKeyRing.java index ecf68890e..7be61d9c8 100644 --- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/pgp/UncachedKeyRing.java +++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/pgp/UncachedKeyRing.java @@ -219,7 +219,7 @@ public class UncachedKeyRing { Iterator it = mRing.getPublicKeys(); while (it.hasNext()) { if (KeyFormattingUtils.convertFingerprintToHex( - it.next().getFingerprint()).equals(expectedFingerprint)) { + it.next().getFingerprint()).equalsIgnoreCase(expectedFingerprint)) { return true; } } -- cgit v1.2.3 From 3af5ba034399eb6b468de35708e051b52289b3a1 Mon Sep 17 00:00:00 2001 From: Vincent Breitmoser Date: Wed, 24 Jun 2015 16:24:08 +0200 Subject: fix warnings in PassphraseCacheService --- .../keychain/service/PassphraseCacheService.java | 38 ++++++++++++++-------- 1 file changed, 25 insertions(+), 13 deletions(-) diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/service/PassphraseCacheService.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/service/PassphraseCacheService.java index c1aa1bb3b..a0b470add 100644 --- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/service/PassphraseCacheService.java +++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/service/PassphraseCacheService.java @@ -17,6 +17,9 @@ package org.sufficientlysecure.keychain.service; + +import java.util.Date; + import android.app.AlarmManager; import android.app.Notification; import android.app.PendingIntent; @@ -25,8 +28,13 @@ import android.content.BroadcastReceiver; import android.content.Context; import android.content.Intent; import android.content.IntentFilter; +import android.graphics.Bitmap; +import android.graphics.Canvas; +import android.graphics.drawable.Drawable; import android.os.Binder; import android.os.Build; +import android.os.Build.VERSION; +import android.os.Build.VERSION_CODES; import android.os.Bundle; import android.os.Handler; import android.os.HandlerThread; @@ -36,9 +44,6 @@ import android.os.Messenger; import android.os.RemoteException; import android.support.v4.app.NotificationCompat; import android.support.v4.util.LongSparseArray; -import android.graphics.Bitmap; -import android.graphics.Canvas; -import android.graphics.drawable.Drawable; import org.sufficientlysecure.keychain.Constants; import org.sufficientlysecure.keychain.R; @@ -49,8 +54,6 @@ import org.sufficientlysecure.keychain.util.Log; import org.sufficientlysecure.keychain.util.Passphrase; import org.sufficientlysecure.keychain.util.Preferences; -import java.util.Date; - /** * This service runs in its own process, but is available to all other processes as the main * passphrase cache. Use the static methods addCachedPassphrase and getCachedPassphrase for @@ -320,7 +323,7 @@ public class PassphraseCacheService extends Service { if (action.equals(BROADCAST_ACTION_PASSPHRASE_CACHE_SERVICE)) { long keyId = intent.getLongExtra(EXTRA_KEY_ID, -1); - timeout(context, keyId); + timeout(keyId); } } }; @@ -455,7 +458,7 @@ public class PassphraseCacheService extends Service { /** * Called when one specific passphrase for keyId timed out */ - private void timeout(Context context, long keyId) { + private void timeout(long keyId) { CachedPassphrase cPass = mPassphraseCache.get(keyId); // clean internal char[] from memory! cPass.getPassphrase().removeFromMemory(); @@ -478,14 +481,23 @@ public class PassphraseCacheService extends Service { } // from de.azapps.mirakel.helper.Helpers from https://github.com/MirakelX/mirakel-android - private static Bitmap getBitmap(int resId, Context ctx) { - final int mLargeIconWidth = (int) ctx.getResources().getDimension( + private static Bitmap getBitmap(int resId, Context context) { + int mLargeIconWidth = (int) context.getResources().getDimension( android.R.dimen.notification_large_icon_width); - final int mLargeIconHeight = (int) ctx.getResources().getDimension( + int mLargeIconHeight = (int) context.getResources().getDimension( android.R.dimen.notification_large_icon_height); - final Drawable d = ctx.getResources().getDrawable(resId); - final Bitmap b = Bitmap.createBitmap(mLargeIconWidth, mLargeIconHeight, Bitmap.Config.ARGB_8888); - final Canvas c = new Canvas(b); + Drawable d; + if (VERSION.SDK_INT < VERSION_CODES.LOLLIPOP) { + // noinspection deprecation (can't help it at this api level) + d = context.getResources().getDrawable(resId); + } else { + d = context.getDrawable(resId); + } + if (d == null) { + return null; + } + Bitmap b = Bitmap.createBitmap(mLargeIconWidth, mLargeIconHeight, Bitmap.Config.ARGB_8888); + Canvas c = new Canvas(b); d.setBounds(0, 0, mLargeIconWidth, mLargeIconHeight); d.draw(c); return b; -- cgit v1.2.3 From 88c86e19455471b30096c1a705eb8ea8b00ab7fb Mon Sep 17 00:00:00 2001 From: Vincent Breitmoser Date: Fri, 26 Jun 2015 01:57:36 +0200 Subject: use KeyAdapter for AllowedKeysListFragment --- .../ui/AppSettingsAllowedKeysListFragment.java | 152 +++------------------ .../keychain/ui/adapter/KeyAdapter.java | 9 +- .../keychain/ui/adapter/KeySelectableAdapter.java | 87 ++++++++++++ .../main/res/layout/key_list_selectable_item.xml | 22 +++ 4 files changed, 135 insertions(+), 135 deletions(-) create mode 100644 OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/adapter/KeySelectableAdapter.java create mode 100644 OpenKeychain/src/main/res/layout/key_list_selectable_item.xml diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/remote/ui/AppSettingsAllowedKeysListFragment.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/remote/ui/AppSettingsAllowedKeysListFragment.java index b880525ca..caa173f03 100644 --- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/remote/ui/AppSettingsAllowedKeysListFragment.java +++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/remote/ui/AppSettingsAllowedKeysListFragment.java @@ -17,10 +17,11 @@ package org.sufficientlysecure.keychain.remote.ui; -import android.content.Context; + +import java.util.Set; + import android.content.OperationApplicationException; import android.database.Cursor; -import android.database.DatabaseUtils; import android.net.Uri; import android.os.Bundle; import android.os.RemoteException; @@ -35,23 +36,17 @@ import android.widget.ListView; import org.sufficientlysecure.keychain.Constants; import org.sufficientlysecure.keychain.R; import org.sufficientlysecure.keychain.compatibility.ListFragmentWorkaround; -import org.sufficientlysecure.keychain.provider.KeychainContract.KeyRings; -import org.sufficientlysecure.keychain.provider.KeychainDatabase.Tables; +import org.sufficientlysecure.keychain.provider.KeychainContract; import org.sufficientlysecure.keychain.provider.ProviderHelper; -import org.sufficientlysecure.keychain.ui.adapter.SelectKeyCursorAdapter; +import org.sufficientlysecure.keychain.ui.adapter.KeyAdapter; +import org.sufficientlysecure.keychain.ui.adapter.KeySelectableAdapter; import org.sufficientlysecure.keychain.ui.widget.FixedListView; import org.sufficientlysecure.keychain.util.Log; -import java.util.HashSet; -import java.util.Iterator; -import java.util.Set; -import java.util.Vector; - public class AppSettingsAllowedKeysListFragment extends ListFragmentWorkaround implements LoaderManager.LoaderCallbacks { private static final String ARG_DATA_URI = "uri"; - private SelectKeyCursorAdapter mAdapter; - private Set mSelectedMasterKeyIds; + private KeySelectableAdapter mAdapter; private ProviderHelper mProviderHelper; private Uri mDataUri; @@ -80,8 +75,7 @@ public class AppSettingsAllowedKeysListFragment extends ListFragmentWorkaround i @Override public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { - View layout = super.onCreateView(inflater, container, - savedInstanceState); + View layout = super.onCreateView(inflater, container, savedInstanceState); ListView lv = (ListView) layout.findViewById(android.R.id.list); ViewGroup parent = (ViewGroup) lv.getParent(); @@ -109,67 +103,29 @@ public class AppSettingsAllowedKeysListFragment extends ListFragmentWorkaround i mDataUri = getArguments().getParcelable(ARG_DATA_URI); - getListView().setChoiceMode(ListView.CHOICE_MODE_MULTIPLE); - // Give some text to display if there is no data. In a real // application this would come from a resource. setEmptyText(getString(R.string.list_empty)); - mAdapter = new SecretKeyCursorAdapter(getActivity(), null, 0, getListView()); - + Set checked = mProviderHelper.getAllKeyIdsForApp(mDataUri); + mAdapter = new KeySelectableAdapter(getActivity(), null, 0, checked); setListAdapter(mAdapter); + getListView().setOnItemClickListener(mAdapter); // Start out with a progress indicator. setListShown(false); - mSelectedMasterKeyIds = mProviderHelper.getAllKeyIdsForApp(mDataUri); - Log.d(Constants.TAG, "allowed: " + mSelectedMasterKeyIds.toString()); - // Prepare the loader. Either re-connect with an existing one, // or start a new one. getLoaderManager().initLoader(0, null, this); - } - /** - * Selects items based on master key ids in list view - * - * @param masterKeyIds - */ - private void preselectMasterKeyIds(Set masterKeyIds) { - for (int i = 0; i < getListView().getCount(); ++i) { - long listKeyId = mAdapter.getMasterKeyId(i); - for (long keyId : masterKeyIds) { - if (listKeyId == keyId) { - getListView().setItemChecked(i, true); - break; - } - } - } } - - /** - * Returns all selected master key ids - * - * @return - */ + /** Returns all selected master key ids. */ public Set getSelectedMasterKeyIds() { - // mListView.getCheckedItemIds() would give the row ids of the KeyRings not the master key - // ids! - Set keyIds = new HashSet<>(); - for (int i = 0; i < getListView().getCount(); ++i) { - if (getListView().isItemChecked(i)) { - keyIds.add(mAdapter.getMasterKeyId(i)); - } - } - - return keyIds; + return mAdapter.getSelectedMasterKeyIds(); } - /** - * Returns all selected user ids - * - * @return - */ + /** Returns all selected user ids. public String[] getSelectedUserIds() { Vector userIds = new Vector<>(); for (int i = 0; i < getListView().getCount(); ++i) { @@ -181,7 +137,7 @@ public class AppSettingsAllowedKeysListFragment extends ListFragmentWorkaround i // make empty array to not return null String userIdArray[] = new String[0]; return userIds.toArray(userIdArray); - } + } */ public void saveAllowedKeys() { try { @@ -192,46 +148,11 @@ public class AppSettingsAllowedKeysListFragment extends ListFragmentWorkaround i } @Override - public Loader onCreateLoader(int id, Bundle args) { - Uri baseUri = KeyRings.buildUnifiedKeyRingsUri(); - - // These are the rows that we will retrieve. - String[] projection = new String[]{ - KeyRings._ID, - KeyRings.MASTER_KEY_ID, - KeyRings.USER_ID, - KeyRings.IS_EXPIRED, - KeyRings.IS_REVOKED, - KeyRings.HAS_ENCRYPT, - KeyRings.VERIFIED, - KeyRings.HAS_ANY_SECRET, - KeyRings.HAS_DUPLICATE_USER_ID, - KeyRings.CREATION, - }; - - String inMasterKeyList = null; - if (mSelectedMasterKeyIds != null && mSelectedMasterKeyIds.size() > 0) { - inMasterKeyList = Tables.KEYS + "." + KeyRings.MASTER_KEY_ID + " IN ("; - Iterator iter = mSelectedMasterKeyIds.iterator(); - while (iter.hasNext()) { - inMasterKeyList += DatabaseUtils.sqlEscapeString("" + iter.next()); - if (iter.hasNext()) { - inMasterKeyList += ", "; - } - } - inMasterKeyList += ")"; - } - - String selection = KeyRings.HAS_ANY_SECRET + " != 0"; + public Loader onCreateLoader(int loaderId, Bundle data) { + Uri baseUri = KeychainContract.KeyRings.buildUnifiedKeyRingsUri(); + String where = KeychainContract.KeyRings.HAS_ANY_SECRET + " = 1"; - String orderBy = KeyRings.USER_ID + " ASC"; - if (inMasterKeyList != null) { - // sort by selected master keys - orderBy = inMasterKeyList + " DESC, " + orderBy; - } - // Now create and return a CursorLoader that will take care of - // creating a Cursor for the data being displayed. - return new CursorLoader(getActivity(), baseUri, projection, selection, null, orderBy); + return new CursorLoader(getActivity(), baseUri, KeyAdapter.PROJECTION, where, null, null); } @Override @@ -246,9 +167,6 @@ public class AppSettingsAllowedKeysListFragment extends ListFragmentWorkaround i } else { setListShownNoAnimation(true); } - - // preselect given master keys - preselectMasterKeyIds(mSelectedMasterKeyIds); } @Override @@ -259,36 +177,4 @@ public class AppSettingsAllowedKeysListFragment extends ListFragmentWorkaround i mAdapter.swapCursor(null); } - private class SecretKeyCursorAdapter extends SelectKeyCursorAdapter { - - public SecretKeyCursorAdapter(Context context, Cursor c, int flags, ListView listView) { - super(context, c, flags, listView); - } - - @Override - protected void initIndex(Cursor cursor) { - super.initIndex(cursor); - } - - @Override - public void bindView(View view, Context context, Cursor cursor) { - super.bindView(view, context, cursor); - ViewHolderItem h = (ViewHolderItem) view.getTag(); - - // We care about the checkbox - h.selected.setVisibility(View.VISIBLE); - // the getListView works because this is not a static subclass! - h.selected.setChecked(getListView().isItemChecked(cursor.getPosition())); - - boolean enabled = false; - if ((Boolean) h.statusIcon.getTag()) { - h.statusIcon.setVisibility(View.GONE); - enabled = true; - } - - h.setEnabled(enabled); - } - - } - } diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/adapter/KeyAdapter.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/adapter/KeyAdapter.java index 1fc24775b..e545b007b 100644 --- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/adapter/KeyAdapter.java +++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/adapter/KeyAdapter.java @@ -95,6 +95,8 @@ public class KeyAdapter extends CursorAdapter { public View mSlinger; public ImageButton mSlingerButton; + public KeyItem mDisplayedItem; + public KeyItemViewHolder(View view) { mView = view; mMainUserId = (TextView) view.findViewById(R.id.key_list_item_name); @@ -107,6 +109,8 @@ public class KeyAdapter extends CursorAdapter { public void setData(Context context, KeyItem item, Highlighter highlighter) { + mDisplayedItem = item; + { // set name and stuff, common to both key types KeyRing.UserId userIdSplit = item.mUserId; if (userIdSplit.name != null) { @@ -143,6 +147,9 @@ public class KeyAdapter extends CursorAdapter { } else if (item.mIsSecret) { mStatus.setVisibility(View.GONE); if (mSlingerButton.hasOnClickListeners()) { + mSlingerButton.setColorFilter( + context.getResources().getColor(R.color.tertiary_text_light), + PorterDuff.Mode.SRC_IN); mSlinger.setVisibility(View.VISIBLE); } else { mSlinger.setVisibility(View.GONE); @@ -192,8 +199,6 @@ public class KeyAdapter extends CursorAdapter { View view = mInflater.inflate(R.layout.key_list_item, parent, false); KeyItemViewHolder holder = new KeyItemViewHolder(view); view.setTag(holder); - holder.mSlingerButton.setColorFilter(context.getResources().getColor(R.color.tertiary_text_light), - PorterDuff.Mode.SRC_IN); return view; } diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/adapter/KeySelectableAdapter.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/adapter/KeySelectableAdapter.java new file mode 100644 index 000000000..471a20411 --- /dev/null +++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/adapter/KeySelectableAdapter.java @@ -0,0 +1,87 @@ +package org.sufficientlysecure.keychain.ui.adapter; + + +import java.util.Collections; +import java.util.HashSet; +import java.util.Set; + +import android.content.Context; +import android.database.Cursor; +import android.support.v7.internal.widget.AdapterViewCompat; +import android.view.View; +import android.view.ViewGroup; +import android.widget.AdapterView; +import android.widget.AdapterView.OnItemClickListener; +import android.widget.CheckBox; + +import org.sufficientlysecure.keychain.Constants; +import org.sufficientlysecure.keychain.R; +import org.sufficientlysecure.keychain.util.Log; + + +public class KeySelectableAdapter extends KeyAdapter implements OnItemClickListener { + + HashSet mSelectedItems = new HashSet<>(); + + public KeySelectableAdapter(Context context, Cursor c, int flags, Set initialChecked) { + super(context, c, flags); + if (initialChecked != null) { + mSelectedItems.addAll(initialChecked); + } + } + + public static class KeySelectableItemViewHolder extends KeyItemViewHolder { + + public CheckBox mCheckbox; + + public KeySelectableItemViewHolder(View view) { + super(view); + mCheckbox = (CheckBox) view.findViewById(R.id.selected); + } + + public void setCheckedState(boolean checked) { + mCheckbox.setChecked(checked); + } + + } + + @Override + public View newView(Context context, Cursor cursor, ViewGroup parent) { + View view = mInflater.inflate(R.layout.key_list_selectable_item, parent, false); + KeySelectableItemViewHolder holder = new KeySelectableItemViewHolder(view); + view.setTag(holder); + return view; + } + + @Override + public void bindView(View view, Context context, Cursor cursor) { + super.bindView(view, context, cursor); + + KeySelectableItemViewHolder h = (KeySelectableItemViewHolder) view.getTag(); + h.setCheckedState(mSelectedItems.contains(h.mDisplayedItem.mKeyId)); + + } + + public void setCheckedStates(Set checked) { + mSelectedItems.clear(); + mSelectedItems.addAll(checked); + notifyDataSetChanged(); + } + + public Set getSelectedMasterKeyIds() { + return Collections.unmodifiableSet(mSelectedItems); + } + + @Override + public void onItemClick(AdapterView parent, View view, int position, long id) { + Log.d(Constants.TAG, "clicked id: " + id); + long masterKeyId = getMasterKeyId(position); + if (mSelectedItems.contains(masterKeyId)) { + mSelectedItems.remove(masterKeyId); + } else { + mSelectedItems.add(masterKeyId); + } + notifyDataSetChanged(); + } + +} diff --git a/OpenKeychain/src/main/res/layout/key_list_selectable_item.xml b/OpenKeychain/src/main/res/layout/key_list_selectable_item.xml new file mode 100644 index 000000000..311eaabd6 --- /dev/null +++ b/OpenKeychain/src/main/res/layout/key_list_selectable_item.xml @@ -0,0 +1,22 @@ + + + + + + + + -- cgit v1.2.3 From 51d35c7a834bce7c49e74ded61b9434ffd94a911 Mon Sep 17 00:00:00 2001 From: Vincent Breitmoser Date: Fri, 26 Jun 2015 01:58:51 +0200 Subject: instrument: first couple of tests for OpenPGP API --- .../sufficientlysecure/keychain/TestHelpers.java | 15 +- .../keychain/remote/OpenPgpServiceTest.java | 171 +++++++++++++++++++++ .../keychain/provider/KeychainDatabase.java | 3 + 3 files changed, 188 insertions(+), 1 deletion(-) create mode 100644 OpenKeychain/src/androidTest/java/org/sufficientlysecure/keychain/remote/OpenPgpServiceTest.java diff --git a/OpenKeychain/src/androidTest/java/org/sufficientlysecure/keychain/TestHelpers.java b/OpenKeychain/src/androidTest/java/org/sufficientlysecure/keychain/TestHelpers.java index 4c058940b..7915ec5db 100644 --- a/OpenKeychain/src/androidTest/java/org/sufficientlysecure/keychain/TestHelpers.java +++ b/OpenKeychain/src/androidTest/java/org/sufficientlysecure/keychain/TestHelpers.java @@ -26,7 +26,9 @@ import android.support.annotation.StringRes; import org.hamcrest.CoreMatchers; import org.sufficientlysecure.keychain.pgp.UncachedKeyRing; import org.sufficientlysecure.keychain.pgp.UncachedKeyRing.IteratorWithIOThrow; +import org.sufficientlysecure.keychain.provider.KeychainDatabase; import org.sufficientlysecure.keychain.provider.ProviderHelper; +import org.sufficientlysecure.keychain.service.PassphraseCacheService; import org.sufficientlysecure.keychain.ui.util.Notify.Style; import org.sufficientlysecure.keychain.util.ProgressScaler; @@ -55,7 +57,7 @@ public class TestHelpers { } - static void importKeysFromResource(Context context, String name) throws Exception { + public static void importKeysFromResource(Context context, String name) throws Exception { IteratorWithIOThrow stream = UncachedKeyRing.fromStream( getInstrumentation().getContext().getAssets().open(name)); @@ -82,5 +84,16 @@ public class TestHelpers { return passbuilder.toString(); } + public static void cleanupForTests(Context context) throws Exception { + + new KeychainDatabase(context).clearDatabase(); + + // import these two, make sure they're there + importKeysFromResource(context, "x.sec.asc"); + + // make sure no passphrases are cached + PassphraseCacheService.clearCachedPassphrases(context); + + } } diff --git a/OpenKeychain/src/androidTest/java/org/sufficientlysecure/keychain/remote/OpenPgpServiceTest.java b/OpenKeychain/src/androidTest/java/org/sufficientlysecure/keychain/remote/OpenPgpServiceTest.java new file mode 100644 index 000000000..aaf7499b7 --- /dev/null +++ b/OpenKeychain/src/androidTest/java/org/sufficientlysecure/keychain/remote/OpenPgpServiceTest.java @@ -0,0 +1,171 @@ +package org.sufficientlysecure.keychain.remote; + + +import java.io.ByteArrayInputStream; +import java.io.ByteArrayOutputStream; + +import android.app.PendingIntent; +import android.content.Intent; +import android.os.IBinder; +import android.support.test.InstrumentationRegistry; +import android.support.test.rule.ServiceTestRule; +import android.support.test.runner.AndroidJUnit4; +import android.test.suitebuilder.annotation.LargeTest; +import android.widget.AdapterView; + +import org.junit.Before; +import org.junit.Rule; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.openintents.openpgp.IOpenPgpService; +import org.openintents.openpgp.util.OpenPgpApi; +import org.sufficientlysecure.keychain.R; + +import static android.support.test.espresso.Espresso.onData; +import static android.support.test.espresso.Espresso.onView; +import static android.support.test.espresso.action.ViewActions.click; +import static android.support.test.espresso.action.ViewActions.typeText; +import static android.support.test.espresso.matcher.ViewMatchers.isAssignableFrom; +import static android.support.test.espresso.matcher.ViewMatchers.withId; +import static android.support.test.espresso.matcher.ViewMatchers.withText; +import static org.hamcrest.core.Is.is; +import static org.junit.Assert.assertThat; +import static org.sufficientlysecure.keychain.TestHelpers.cleanupForTests; +import static org.sufficientlysecure.keychain.matcher.CustomMatchers.withKeyItemId; + + +@RunWith(AndroidJUnit4.class) +@LargeTest +public class OpenPgpServiceTest { + + @Rule + public final ServiceTestRule mServiceRule = new ServiceTestRule(); + + OpenPgpApi mApi; + + @Before + public void setUp() throws Exception { + + cleanupForTests(InstrumentationRegistry.getTargetContext()); + + Intent serviceIntent = new Intent(InstrumentationRegistry.getTargetContext(), OpenPgpService.class); + IBinder binder = mServiceRule.bindService(serviceIntent); + + mApi = new OpenPgpApi(InstrumentationRegistry.getTargetContext(), + IOpenPgpService.Stub.asInterface(binder)); + + } + + @Test + public void testStuff() throws Exception { + + // TODO why does this not ask for general usage permissions?! + + { + Intent intent = new Intent(); + intent.setAction(OpenPgpApi.ACTION_ENCRYPT); + intent.putExtra(OpenPgpApi.EXTRA_REQUEST_ASCII_ARMOR, true); + intent.putExtra(OpenPgpApi.EXTRA_KEY_IDS, new long[] { 0x9D604D2F310716A3L }); + + ByteArrayInputStream is = new ByteArrayInputStream("swag".getBytes()); + ByteArrayOutputStream os = new ByteArrayOutputStream(); + + Intent result = mApi.executeApi(intent, is, os); + + assertThat("result is pending accept", + result.getIntExtra(OpenPgpApi.RESULT_CODE, OpenPgpApi.RESULT_CODE_ERROR), + is(OpenPgpApi.RESULT_CODE_USER_INTERACTION_REQUIRED)); + + PendingIntent pi = result.getParcelableExtra(OpenPgpApi.RESULT_INTENT); + pi.send(); + + onView(withText(R.string.api_register_allow)).perform(click()); + + } + + byte[] ciphertext; + { + Intent intent = new Intent(); + intent.setAction(OpenPgpApi.ACTION_ENCRYPT); + intent.putExtra(OpenPgpApi.EXTRA_REQUEST_ASCII_ARMOR, true); + intent.putExtra(OpenPgpApi.EXTRA_KEY_IDS, new long[] { 0x9D604D2F310716A3L }); + + ByteArrayInputStream is = new ByteArrayInputStream("swag".getBytes()); + ByteArrayOutputStream os = new ByteArrayOutputStream(); + + Intent result = mApi.executeApi(intent, is, os); + + assertThat("result is ok", + result.getIntExtra(OpenPgpApi.RESULT_CODE, OpenPgpApi.RESULT_CODE_ERROR), + is(OpenPgpApi.RESULT_CODE_SUCCESS)); + + ciphertext = os.toByteArray(); + } + + { // decrypt + Intent intent = new Intent(); + intent.setAction(OpenPgpApi.ACTION_DECRYPT_VERIFY); + + ByteArrayInputStream is = new ByteArrayInputStream(ciphertext); + ByteArrayOutputStream os = new ByteArrayOutputStream(); + + Intent result = mApi.executeApi(intent, is, os); + + assertThat("result is pending input", + result.getIntExtra(OpenPgpApi.RESULT_CODE, OpenPgpApi.RESULT_CODE_ERROR), + is(OpenPgpApi.RESULT_CODE_USER_INTERACTION_REQUIRED)); + + PendingIntent pi = result.getParcelableExtra(OpenPgpApi.RESULT_INTENT); + pi.send(); + + onData(withKeyItemId(0x9D604D2F310716A3L)) + .inAdapterView(isAssignableFrom(AdapterView.class)) + .perform(click()); + + onView(withText(R.string.api_settings_save)).perform(click()); + + // unfortunately, getting the activity result from the + + } + + { // decrypt again, this time pending passphrase + Intent intent = new Intent(); + intent.setAction(OpenPgpApi.ACTION_DECRYPT_VERIFY); + + ByteArrayInputStream is = new ByteArrayInputStream(ciphertext); + ByteArrayOutputStream os = new ByteArrayOutputStream(); + + Intent result = mApi.executeApi(intent, is, os); + + assertThat("result is pending passphrase", + result.getIntExtra(OpenPgpApi.RESULT_CODE, OpenPgpApi.RESULT_CODE_ERROR), + is(OpenPgpApi.RESULT_CODE_USER_INTERACTION_REQUIRED)); + + PendingIntent pi = result.getParcelableExtra(OpenPgpApi.RESULT_INTENT); + pi.send(); + + onView(withId(R.id.passphrase_passphrase)).perform(typeText("x")); + onView(withText(R.string.btn_unlock)).perform(click()); + } + + { // decrypt again, NOW it should work with passphrase cached =) + Intent intent = new Intent(); + intent.setAction(OpenPgpApi.ACTION_DECRYPT_VERIFY); + + ByteArrayInputStream is = new ByteArrayInputStream(ciphertext); + ByteArrayOutputStream os = new ByteArrayOutputStream(); + + Intent result = mApi.executeApi(intent, is, os); + + assertThat("result is pending passphrase", + result.getIntExtra(OpenPgpApi.RESULT_CODE, OpenPgpApi.RESULT_CODE_ERROR), + is(OpenPgpApi.RESULT_CODE_SUCCESS)); + + byte[] plaintext = os.toByteArray(); + assertThat("decrypted plaintext matches plaintext", new String(plaintext), is("swag")); + + } + + } + +} diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/provider/KeychainDatabase.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/provider/KeychainDatabase.java index a91eca453..3346926ec 100644 --- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/provider/KeychainDatabase.java +++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/provider/KeychainDatabase.java @@ -430,6 +430,9 @@ public class KeychainDatabase extends SQLiteOpenHelper { // DANGEROUS, use in test code ONLY! public void clearDatabase() { getWritableDatabase().execSQL("delete from " + Tables.KEY_RINGS_PUBLIC); + getWritableDatabase().execSQL("delete from " + Tables.API_ACCOUNTS); + getWritableDatabase().execSQL("delete from " + Tables.API_ALLOWED_KEYS); + getWritableDatabase().execSQL("delete from " + Tables.API_APPS); } } -- cgit v1.2.3