From 0e83df21cfae2a1e792af9e02c006305b24fb530 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dominik=20Sch=C3=BCrmann?= Date: Sun, 7 Sep 2014 15:30:32 +0200 Subject: More UI rework --- .../org/sufficientlysecure/keychain/Constants.java | 4 +- .../keychain/ui/DrawerActivity.java | 5 +- .../ui/widget/EncryptKeyCompletionView.java | 6 +- .../keychain/ui/widget/KeySpinner.java | 4 +- .../res/layout/api_account_settings_fragment.xml | 118 ++++++++++++++------- .../res/layout/encrypt_asymmetric_fragment.xml | 3 +- .../src/main/res/layout/keyspinner_item.xml | 39 +++++++ .../src/main/res/layout/keyspinner_key.xml | 39 ------- .../src/main/res/layout/recipient_box_entry.xml | 33 +++--- .../res/layout/recipient_selection_list_entry.xml | 95 +++++++++-------- OpenKeychain/src/main/res/values/strings.xml | 13 ++- 11 files changed, 202 insertions(+), 157 deletions(-) create mode 100644 OpenKeychain/src/main/res/layout/keyspinner_item.xml delete mode 100644 OpenKeychain/src/main/res/layout/keyspinner_key.xml diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/Constants.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/Constants.java index 1563932a5..5d5f0ab1a 100644 --- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/Constants.java +++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/Constants.java @@ -88,14 +88,14 @@ public final class Constants { public static final class DrawerItems { public static final Class KEY_LIST = KeyListActivity.class; - public static final Class ENCRYPT_FILE = EncryptFileActivity.class; public static final Class ENCRYPT_TEXT = EncryptTextActivity.class; + public static final Class ENCRYPT_FILE = EncryptFileActivity.class; public static final Class DECRYPT = DecryptActivity.class; public static final Class REGISTERED_APPS_LIST = AppsListActivity.class; public static final Class[] ARRAY = new Class[]{ KEY_LIST, - ENCRYPT_FILE, ENCRYPT_TEXT, + ENCRYPT_FILE, DECRYPT, REGISTERED_APPS_LIST }; diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/DrawerActivity.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/DrawerActivity.java index 9e82f48f4..7132518ae 100644 --- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/DrawerActivity.java +++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/DrawerActivity.java @@ -83,8 +83,8 @@ public class DrawerActivity extends ActionBarActivity { NavItem mItemIconTexts[] = new NavItem[]{ new NavItem(R.drawable.ic_action_person, getString(R.string.nav_keys)), - new NavItem(R.drawable.ic_action_secure, getString(R.string.nav_encrypt_files)), new NavItem(R.drawable.ic_action_secure, getString(R.string.nav_encrypt_text)), + new NavItem(R.drawable.ic_action_secure, getString(R.string.nav_encrypt_files)), new NavItem(R.drawable.ic_action_not_secure, getString(R.string.nav_decrypt)), new NavItem(R.drawable.ic_action_view_as_list, getString(R.string.nav_apps))}; @@ -248,7 +248,8 @@ public class DrawerActivity extends ActionBarActivity { /** * NavItem constructor - * @param icon The icons resource-id + * + * @param icon The icons resource-id * @param title The title of the menu entry */ public NavItem(int icon, String title) { diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/widget/EncryptKeyCompletionView.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/widget/EncryptKeyCompletionView.java index 76d8fb2dc..f3ead3faa 100644 --- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/widget/EncryptKeyCompletionView.java +++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/widget/EncryptKeyCompletionView.java @@ -210,9 +210,7 @@ public class EncryptKeyCompletionView extends TokenCompleteTextView { } public String getPrimary() { - if (mUserId[0] != null && mUserId[2] != null) { - return mUserId[0] + " (" + mUserId[2] + ")"; - } else if (mUserId[0] != null) { + if (mUserId[0] != null) { return mUserId[0]; } else { return mUserId[1]; @@ -220,7 +218,7 @@ public class EncryptKeyCompletionView extends TokenCompleteTextView { } public String getSecondary() { - if (mUserId[0] != null) { + if (mUserId[1] != null) { return mUserId[1]; } else { return getKeyIdHex(); diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/widget/KeySpinner.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/widget/KeySpinner.java index cde22615c..56e01d541 100644 --- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/widget/KeySpinner.java +++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/widget/KeySpinner.java @@ -133,7 +133,7 @@ public abstract class KeySpinner extends Spinner implements LoaderManager.Loader inner = new CursorAdapter(null, null, 0) { @Override public View newView(Context context, Cursor cursor, ViewGroup parent) { - return View.inflate(getContext(), R.layout.keyspinner_key, null); + return View.inflate(getContext(), R.layout.keyspinner_item, null); } @Override @@ -210,7 +210,7 @@ public abstract class KeySpinner extends Spinner implements LoaderManager.Loader } else { v = convertView; } - ((TextView) v.findViewById(R.id.keyspinner_key_name)).setText("None"); + ((TextView) v.findViewById(R.id.keyspinner_key_name)).setText(R.string.choice_none); v.findViewById(R.id.keyspinner_key_email).setVisibility(View.GONE); v.findViewById(R.id.keyspinner_key_id).setVisibility(View.GONE); } else { diff --git a/OpenKeychain/src/main/res/layout/api_account_settings_fragment.xml b/OpenKeychain/src/main/res/layout/api_account_settings_fragment.xml index 0da4d7f36..cd74255c7 100644 --- a/OpenKeychain/src/main/res/layout/api_account_settings_fragment.xml +++ b/OpenKeychain/src/main/res/layout/api_account_settings_fragment.xml @@ -41,19 +41,29 @@ android:layout_height="wrap_content" android:text="@string/api_settings_settings" /> - + android:padding="0dp" + android:layout_margin="0dp"> - + + + + + - - - - - + + + + + + + + - - - - + + + + + + + + - - + android:padding="0dp" + android:layout_margin="0dp"> + + + + + + diff --git a/OpenKeychain/src/main/res/layout/encrypt_asymmetric_fragment.xml b/OpenKeychain/src/main/res/layout/encrypt_asymmetric_fragment.xml index 5eecaac2a..51891155c 100644 --- a/OpenKeychain/src/main/res/layout/encrypt_asymmetric_fragment.xml +++ b/OpenKeychain/src/main/res/layout/encrypt_asymmetric_fragment.xml @@ -22,8 +22,6 @@ diff --git a/OpenKeychain/src/main/res/layout/keyspinner_item.xml b/OpenKeychain/src/main/res/layout/keyspinner_item.xml new file mode 100644 index 000000000..346d09113 --- /dev/null +++ b/OpenKeychain/src/main/res/layout/keyspinner_item.xml @@ -0,0 +1,39 @@ + + + + + + + + + \ No newline at end of file diff --git a/OpenKeychain/src/main/res/layout/keyspinner_key.xml b/OpenKeychain/src/main/res/layout/keyspinner_key.xml deleted file mode 100644 index 346d09113..000000000 --- a/OpenKeychain/src/main/res/layout/keyspinner_key.xml +++ /dev/null @@ -1,39 +0,0 @@ - - - - - - - - - \ No newline at end of file diff --git a/OpenKeychain/src/main/res/layout/recipient_box_entry.xml b/OpenKeychain/src/main/res/layout/recipient_box_entry.xml index 72a0bee48..ab7e5c54f 100644 --- a/OpenKeychain/src/main/res/layout/recipient_box_entry.xml +++ b/OpenKeychain/src/main/res/layout/recipient_box_entry.xml @@ -1,24 +1,23 @@ + - - + android:id="@android:id/text1" + android:layout_gravity="center_vertical" + android:padding="4dp" /> + android:id="@android:id/icon" + android:layout_width="32dip" + android:layout_height="32dip" + android:layout_marginLeft="12dip" + android:cropToPadding="true" + android:background="#ccc" + android:scaleType="centerCrop" /> \ No newline at end of file diff --git a/OpenKeychain/src/main/res/layout/recipient_selection_list_entry.xml b/OpenKeychain/src/main/res/layout/recipient_selection_list_entry.xml index 9d2d1e9a9..85ed92ef7 100644 --- a/OpenKeychain/src/main/res/layout/recipient_selection_list_entry.xml +++ b/OpenKeychain/src/main/res/layout/recipient_selection_list_entry.xml @@ -1,51 +1,58 @@ + - + + + + + + - - - + android:paddingLeft="16dip" + android:singleLine="true" + android:ellipsize="end" + android:typeface="monospace" + android:layout_marginTop="-4dip" /> + + android:id="@android:id/icon" + android:layout_width="56dip" + android:layout_height="56dip" + android:layout_marginLeft="12dip" + android:cropToPadding="true" + android:background="#ccc" + android:scaleType="centerCrop" /> \ No newline at end of file diff --git a/OpenKeychain/src/main/res/values/strings.xml b/OpenKeychain/src/main/res/values/strings.xml index afab18686..e39bca63c 100644 --- a/OpenKeychain/src/main/res/values/strings.xml +++ b/OpenKeychain/src/main/res/values/strings.xml @@ -90,19 +90,18 @@ Repeat Passphrase Algorithm File ASCII Armor - Files: ASCII Armor + Enable ASCII Armor Let others know that you\'re using OpenKeychain Writes \'OpenKeychain v2.7\' to OpenPGP signatures, ciphertext, and exported keys Use default Yubikey PIN Uses default PIN (123456) to access Yubikeys over NFC Signed by: Encrypt to: - Files: Delete After Encryption + Delete File After Encryption Delete After Decryption Encryption Algorithm Hash Algorithm - With Public Key - With Passphrase + Encrypt With Passphrase Passphrase Cache Message Compression File Compression @@ -416,7 +415,7 @@ SHA-256 of Package Signature Accounts Settings - My key for this account + Account key: No accounts attached to this app. "The app requests the creation of a new account. Please select one of your existing keys or create a new one.\nApps are restricted to the usage of keys you select here!" "The key saved for this account has been deleted. Please select a different one!\nApps are restricted to the usage of keys you select here!" @@ -512,7 +511,7 @@ My Keys - The message entered here will be signed using the key selected in \'Signed by\' and encrypted for all recipients selected in \'Encrypt to\'. + Type text Enter ciphertext here to decrypt and/or verify… @@ -755,7 +754,7 @@ OpenKeychain has cached %d passphrases Cached Passphrases: Clear Cache - Password + Passphrase Certifier -- cgit v1.2.3