From e169dd914f99c4a0253b578c044f8d17714210e7 Mon Sep 17 00:00:00 2001 From: Kenny Root Date: Wed, 23 Sep 2015 17:37:47 -0700 Subject: Only use host if it is not null Since we null check the host, we should make sure not to dereference it later on. --- app/src/main/java/org/connectbot/HostListActivity.java | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/app/src/main/java/org/connectbot/HostListActivity.java b/app/src/main/java/org/connectbot/HostListActivity.java index fe5207a..d844c50 100644 --- a/app/src/main/java/org/connectbot/HostListActivity.java +++ b/app/src/main/java/org/connectbot/HostListActivity.java @@ -500,14 +500,17 @@ public class HostListActivity extends AppCompatListActivity implements OnHostSta */ private int getConnectedState(HostBean host) { // always disconnected if we don't have backend service - if (this.manager == null) + if (this.manager == null || host == null) { return STATE_UNKNOWN; + } - if (manager.getConnectedBridge(host) != null) + if (manager.getConnectedBridge(host) != null) { return STATE_CONNECTED; + } - if (manager.disconnected.contains(host)) + if (manager.disconnected.contains(host)) { return STATE_DISCONNECTED; + } return STATE_UNKNOWN; } @@ -525,16 +528,14 @@ public class HostListActivity extends AppCompatListActivity implements OnHostSta HostViewHolder hostHolder = (HostViewHolder) holder; HostBean host = hosts.get(position); + hostHolder.host = host; if (host == null) { // Well, something bad happened. We can't continue. Log.e("HostAdapter", "Host bean is null!"); - hostHolder.nickname.setText("Error during lookup"); - hostHolder.caption.setText("see 'adb logcat' for more"); + } else { + hostHolder.nickname.setText(host.getNickname()); } - hostHolder.host = host; - - hostHolder.nickname.setText(host.getNickname()); switch (this.getConnectedState(host)) { case STATE_UNKNOWN: -- cgit v1.2.3 From 057843e78e2af41909049b9245c834509eecd1aa Mon Sep 17 00:00:00 2001 From: Kenny Root Date: Wed, 23 Sep 2015 17:42:42 -0700 Subject: Only use pubkey if it is not null Since we null check the pubkey, we should make sure not to dereference it later on. --- app/src/main/java/org/connectbot/PubkeyListActivity.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/org/connectbot/PubkeyListActivity.java b/app/src/main/java/org/connectbot/PubkeyListActivity.java index d25411f..9f8521f 100644 --- a/app/src/main/java/org/connectbot/PubkeyListActivity.java +++ b/app/src/main/java/org/connectbot/PubkeyListActivity.java @@ -629,16 +629,15 @@ public class PubkeyListActivity extends AppCompatListActivity implements EventLi PubkeyViewHolder pubkeyHolder = (PubkeyViewHolder) holder; PubkeyBean pubkey = pubkeys.get(position); + pubkeyHolder.pubkey = pubkey; if (pubkey == null) { // Well, something bad happened. We can't continue. Log.e("PubkeyAdapter", "Pubkey bean is null!"); pubkeyHolder.nickname.setText("Error during lookup"); - pubkeyHolder.caption.setText("see 'adb logcat' for more"); + } else { + pubkeyHolder.nickname.setText(pubkey.getNickname()); } - pubkeyHolder.pubkey = pubkey; - - pubkeyHolder.nickname.setText(pubkey.getNickname()); boolean imported = PubkeyDatabase.KEY_TYPE_IMPORTED.equals(pubkey.getType()); -- cgit v1.2.3