CURSOR_INFO-when-the-cursor-content.patch « patches-4.19 « bcm27xx « linux « target - openwrt/upstream - upstream openwrt</title>
<meta name='generator' content='cgit v1.2.3'/>
<meta name='robots' content='index, nofollow'/>
<link rel='stylesheet' type='text/css' href='/cgit.css'/>
<link rel='shortcut icon' href='/favicon.ico'/>
<link rel='alternate' title='Atom feed' href='http://git.panaceas.org/cgit/openwrt/upstream/atom/target/linux/bcm27xx/patches-4.19/950-0113-drm-vc4-Skip-SET_CURSOR_INFO-when-the-cursor-content.patch?h=upstream' type='application/atom+xml'/>
<link rel='vcs-git' href='git://git.panaceas.org/openwrt/upstream' title='openwrt/upstream Git repository'/>
<link rel='vcs-git' href='ssh://git@git.panaceas.org/git/openwrt/upstream' title='openwrt/upstream Git repository'/>
</head>
<body>
<div id='cgit'><table id='header'>
<tr>
<td class='logo' rowspan='2'><a href='/cgit/'><img src='/cgit.png' alt='cgit logo'/></a></td>
<td class='main'><a href='/cgit/'>index</a> : <a title='openwrt/upstream' href='/cgit/openwrt/upstream/'>openwrt/upstream</a></td><td class='form'><form method='get'>
<input type='hidden' name='id' value='a2ae9a07d2d4843665d04ddcc1357ee22a72216a'/><select name='h' onchange='this.form.submit();'>
<option value='attitude_adjustment'>attitude_adjustment</option>
<option value='barrier_breaker'>barrier_breaker</option>
<option value='chaos_calmer'>chaos_calmer</option>
<option value='lede-17.01'>lede-17.01</option>
<option value='less-old-master'>less-old-master</option>
<option value='master'>master</option>
<option value='old-master'>old-master</option>
<option value='openwrt-18.06'>openwrt-18.06</option>
<option value='openwrt-19.07'>openwrt-19.07</option>
<option value='upstream' selected='selected'>upstream</option>
</select> <input type='submit' value='switch'/></form></td></tr>
<tr><td class='sub'>upstream openwrt</td><td class='sub right'>James</td></tr></table>
<table class='tabs'><tr><td>
<a href='/cgit/openwrt/upstream/about/?h=upstream'>about</a><a href='/cgit/openwrt/upstream/?h=upstream'>summary</a><a href='/cgit/openwrt/upstream/refs/?h=upstream&amp;id=a2ae9a07d2d4843665d04ddcc1357ee22a72216a'>refs</a><a href='/cgit/openwrt/upstream/log/target/linux/bcm27xx/patches-4.19/950-0113-drm-vc4-Skip-SET_CURSOR_INFO-when-the-cursor-content.patch?h=upstream'>log</a><a class='active' href='/cgit/openwrt/upstream/tree/target/linux/bcm27xx/patches-4.19/950-0113-drm-vc4-Skip-SET_CURSOR_INFO-when-the-cursor-content.patch?h=upstream&amp;id=a2ae9a07d2d4843665d04ddcc1357ee22a72216a'>tree</a><a href='/cgit/openwrt/upstream/commit/target/linux/bcm27xx/patches-4.19/950-0113-drm-vc4-Skip-SET_CURSOR_INFO-when-the-cursor-content.patch?h=upstream&amp;id=a2ae9a07d2d4843665d04ddcc1357ee22a72216a'>commit</a><a href='/cgit/openwrt/upstream/diff/target/linux/bcm27xx/patches-4.19/950-0113-drm-vc4-Skip-SET_CURSOR_INFO-when-the-cursor-content.patch?h=upstream&amp;id=a2ae9a07d2d4843665d04ddcc1357ee22a72216a'>diff</a><a href='/cgit/openwrt/upstream/stats/target/linux/bcm27xx/patches-4.19/950-0113-drm-vc4-Skip-SET_CURSOR_INFO-when-the-cursor-content.patch?h=upstream'>stats</a></td><td class='form'><form class='right' method='get' action='/cgit/openwrt/upstream/log/target/linux/bcm27xx/patches-4.19/950-0113-drm-vc4-Skip-SET_CURSOR_INFO-when-the-cursor-content.patch'>
<input type='hidden' name='h' value='upstream'/><input type='hidden' name='id' value='a2ae9a07d2d4843665d04ddcc1357ee22a72216a'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/cgit/openwrt/upstream/tree/?h=upstream&amp;id=a2ae9a07d2d4843665d04ddcc1357ee22a72216a'>root</a>/<a href='/cgit/openwrt/upstream/tree/target?h=upstream&amp;id=a2ae9a07d2d4843665d04ddcc1357ee22a72216a'>target</a>/<a href='/cgit/openwrt/upstream/tree/target/linux?h=upstream&amp;id=a2ae9a07d2d4843665d04ddcc1357ee22a72216a'>linux</a>/<a href='/cgit/openwrt/upstream/tree/target/linux/bcm27xx?h=upstream&amp;id=a2ae9a07d2d4843665d04ddcc1357ee22a72216a'>bcm27xx</a>/<a href='/cgit/openwrt/upstream/tree/target/linux/bcm27xx/patches-4.19?h=upstream&amp;id=a2ae9a07d2d4843665d04ddcc1357ee22a72216a'>patches-4.19</a>/<a href='/cgit/openwrt/upstream/tree/target/linux/bcm27xx/patches-4.19/950-0113-drm-vc4-Skip-SET_CURSOR_INFO-when-the-cursor-content.patch?h=upstream&amp;id=a2ae9a07d2d4843665d04ddcc1357ee22a72216a'>950-0113-drm-vc4-Skip-SET_CURSOR_INFO-when-the-cursor-content.patch</a></div><div class='content'>blob: 0b9398fda7f5652e39fb4f2d484f2d2f8ebbaefc (<a href='/cgit/openwrt/upstream/plain/target/linux/bcm27xx/patches-4.19/950-0113-drm-vc4-Skip-SET_CURSOR_INFO-when-the-cursor-content.patch?h=upstream&amp;id=a2ae9a07d2d4843665d04ddcc1357ee22a72216a'>plain</a>)
<table summary='blob content' class='blob'>
<tr><td class='linenumbers'><pre><a id='n1' href='#n1'>1</a>
<a id='n2' href='#n2'>2</a>
<a id='n3' href='#n3'>3</a>
<a id='n4' href='#n4'>4</a>
<a id='n5' href='#n5'>5</a>
<a id='n6' href='#n6'>6</a>
<a id='n7' href='#n7'>7</a>
<a id='n8' href='#n8'>8</a>
<a id='n9' href='#n9'>9</a>
<a id='n10' href='#n10'>10</a>
<a id='n11' href='#n11'>11</a>
<a id='n12' href='#n12'>12</a>
<a id='n13' href='#n13'>13</a>
<a id='n14' href='#n14'>14</a>
<a id='n15' href='#n15'>15</a>
<a id='n16' href='#n16'>16</a>
<a id='n17' href='#n17'>17</a>
<a id='n18' href='#n18'>18</a>
<a id='n19' href='#n19'>19</a>
<a id='n20' href='#n20'>20</a>
<a id='n21' href='#n21'>21</a>
<a id='n22' href='#n22'>22</a>
<a id='n23' href='#n23'>23</a>
<a id='n24' href='#n24'>24</a>
<a id='n25' href='#n25'>25</a>
<a id='n26' href='#n26'>26</a>
<a id='n27' href='#n27'>27</a>
<a id='n28' href='#n28'>28</a>
<a id='n29' href='#n29'>29</a>
<a id='n30' href='#n30'>30</a>
<a id='n31' href='#n31'>31</a>
<a id='n32' href='#n32'>32</a>
<a id='n33' href='#n33'>33</a>
<a id='n34' href='#n34'>34</a>
<a id='n35' href='#n35'>35</a>
<a id='n36' href='#n36'>36</a>
<a id='n37' href='#n37'>37</a>
<a id='n38' href='#n38'>38</a>
<a id='n39' href='#n39'>39</a>
<a id='n40' href='#n40'>40</a>
<a id='n41' href='#n41'>41</a>
<a id='n42' href='#n42'>42</a>
<a id='n43' href='#n43'>43</a>
<a id='n44' href='#n44'>44</a>
<a id='n45' href='#n45'>45</a>
<a id='n46' href='#n46'>46</a>
<a id='n47' href='#n47'>47</a>
<a id='n48' href='#n48'>48</a>
<a id='n49' href='#n49'>49</a>
<a id='n50' href='#n50'>50</a>
<a id='n51' href='#n51'>51</a>
<a id='n52' href='#n52'>52</a>
<a id='n53' href='#n53'>53</a>
<a id='n54' href='#n54'>54</a>
<a id='n55' href='#n55'>55</a>
<a id='n56' href='#n56'>56</a>
<a id='n57' href='#n57'>57</a>
</pre></td>
<td class='lines'><pre><code><style>pre { line-height: 125%; margin: 0; }
td.linenos pre { color: #000000; background-color: #f0f0f0; padding: 0 5px 0 5px; }
span.linenos { color: #000000; background-color: #f0f0f0; padding: 0 5px 0 5px; }
td.linenos pre.special { color: #000000; background-color: #ffffc0; padding: 0 5px 0 5px; }
span.linenos.special { color: #000000; background-color: #ffffc0; padding: 0 5px 0 5px; }
.highlight .hll { background-color: #ffffcc }
.highlight { background: #ffffff; }
.highlight .c { color: #888888 } /* Comment */
.highlight .err { color: #a61717; background-color: #e3d2d2 } /* Error */
.highlight .k { color: #008800; font-weight: bold } /* Keyword */
.highlight .ch { color: #888888 } /* Comment.Hashbang */
.highlight .cm { color: #888888 } /* Comment.Multiline */
.highlight .cp { color: #cc0000; font-weight: bold } /* Comment.Preproc */
.highlight .cpf { color: #888888 } /* Comment.PreprocFile */
.highlight .c1 { color: #888888 } /* Comment.Single */
.highlight .cs { color: #cc0000; font-weight: bold; background-color: #fff0f0 } /* Comment.Special */
.highlight .gd { color: #000000; background-color: #ffdddd } /* Generic.Deleted */
.highlight .ge { font-style: italic } /* Generic.Emph */
.highlight .gr { color: #aa0000 } /* Generic.Error */
.highlight .gh { color: #333333 } /* Generic.Heading */
.highlight .gi { color: #000000; background-color: #ddffdd } /* Generic.Inserted */
.highlight .go { color: #888888 } /* Generic.Output */
.highlight .gp { color: #555555 } /* Generic.Prompt */
.highlight .gs { font-weight: bold } /* Generic.Strong */
.highlight .gu { color: #666666 } /* Generic.Subheading */
.highlight .gt { color: #aa0000 } /* Generic.Traceback */
.highlight .kc { color: #008800; font-weight: bold } /* Keyword.Constant */
.highlight .kd { color: #008800; font-weight: bold } /* Keyword.Declaration */
.highlight .kn { color: #008800; font-weight: bold } /* Keyword.Namespace */
.highlight .kp { color: #008800 } /* Keyword.Pseudo */
.highlight .kr { color: #008800; font-weight: bold } /* Keyword.Reserved */
.highlight .kt { color: #888888; font-weight: bold } /* Keyword.Type */
.highlight .m { color: #0000DD; font-weight: bold } /* Literal.Number */
.highlight .s { color: #dd2200; background-color: #fff0f0 } /* Literal.String */
.highlight .na { color: #336699 } /* Name.Attribute */
.highlight .nb { color: #003388 } /* Name.Builtin */
.highlight .nc { color: #bb0066; font-weight: bold } /* Name.Class */
.highlight .no { color: #003366; font-weight: bold } /* Name.Constant */
.highlight .nd { color: #555555 } /* Name.Decorator */
.highlight .ne { color: #bb0066; font-weight: bold } /* Name.Exception */
.highlight .nf { color: #0066bb; font-weight: bold } /* Name.Function */
.highlight .nl { color: #336699; font-style: italic } /* Name.Label */
.highlight .nn { color: #bb0066; font-weight: bold } /* Name.Namespace */
.highlight .py { color: #336699; font-weight: bold } /* Name.Property */
.highlight .nt { color: #bb0066; font-weight: bold } /* Name.Tag */
.highlight .nv { color: #336699 } /* Name.Variable */
.highlight .ow { color: #008800 } /* Operator.Word */
.highlight .w { color: #bbbbbb } /* Text.Whitespace */
.highlight .mb { color: #0000DD; font-weight: bold } /* Literal.Number.Bin */
.highlight .mf { color: #0000DD; font-weight: bold } /* Literal.Number.Float */
.highlight .mh { color: #0000DD; font-weight: bold } /* Literal.Number.Hex */
.highlight .mi { color: #0000DD; font-weight: bold } /* Literal.Number.Integer */
.highlight .mo { color: #0000DD; font-weight: bold } /* Literal.Number.Oct */
.highlight .sa { color: #dd2200; background-color: #fff0f0 } /* Literal.String.Affix */
.highlight .sb { color: #dd2200; background-color: #fff0f0 } /* Literal.String.Backtick */
.highlight .sc { color: #dd2200; background-color: #fff0f0 } /* Literal.String.Char */
.highlight .dl { color: #dd2200; background-color: #fff0f0 } /* Literal.String.Delimiter */
.highlight .sd { color: #dd2200; background-color: #fff0f0 } /* Literal.String.Doc */
.highlight .s2 { color: #dd2200; background-color: #fff0f0 } /* Literal.String.Double */
.highlight .se { color: #0044dd; background-color: #fff0f0 } /* Literal.String.Escape */
.highlight .sh { color: #dd2200; background-color: #fff0f0 } /* Literal.String.Heredoc */
.highlight .si { color: #3333bb; background-color: #fff0f0 } /* Literal.String.Interpol */
.highlight .sx { color: #22bb22; background-color: #f0fff0 } /* Literal.String.Other */
.highlight .sr { color: #008800; background-color: #fff0ff } /* Literal.String.Regex */
.highlight .s1 { color: #dd2200; background-color: #fff0f0 } /* Literal.String.Single */
.highlight .ss { color: #aa6600; background-color: #fff0f0 } /* Literal.String.Symbol */
.highlight .bp { color: #003388 } /* Name.Builtin.Pseudo */
.highlight .fm { color: #0066bb; font-weight: bold } /* Name.Function.Magic */
.highlight .vc { color: #336699 } /* Name.Variable.Class */
.highlight .vg { color: #dd7700 } /* Name.Variable.Global */
.highlight .vi { color: #3333bb } /* Name.Variable.Instance */
.highlight .vm { color: #336699 } /* Name.Variable.Magic */
.highlight .il { color: #0000DD; font-weight: bold } /* Literal.Number.Integer.Long */</style><div class="highlight"><pre><span></span>From a87af130d6feadfea3146a78c58408a8be9a0635 Mon Sep 17 00:00:00 2001
From: Eric Anholt &lt;eric@anholt.net&gt;
Date: Mon, 5 Feb 2018 18:02:30 +0000
Subject: [PATCH] drm/vc4: Skip SET_CURSOR_INFO when the cursor
 contents didn&#39;t change.

Signed-off-by: Eric Anholt &lt;eric@anholt.net&gt;
<span class="gd">---</span>
 drivers/gpu/drm/vc4/vc4_firmware_kms.c | 30 +++++++++++++++++---------
 1 file changed, 20 insertions(+), 10 deletions(-)

<span class="gd">--- a/drivers/gpu/drm/vc4/vc4_firmware_kms.c</span>
<span class="gi">+++ b/drivers/gpu/drm/vc4/vc4_firmware_kms.c</span>
<span class="gu">@@ -204,10 +204,6 @@ static void vc4_cursor_plane_atomic_upda</span>
 		state-&gt;crtc_y,
 		0
 	};
<span class="gd">-	u32 packet_info[] = { state-&gt;crtc_w, state-&gt;crtc_h,</span>
<span class="gd">-			      0, /* unused */</span>
<span class="gd">-			      bo-&gt;paddr + fb-&gt;offsets[0],</span>
<span class="gd">-			      0, 0, /* hotx, hoty */};</span>
 	WARN_ON_ONCE(fb-&gt;pitches[0] != state-&gt;crtc_w * 4);
 
 	DRM_DEBUG_ATOMIC(&quot;[PLANE:%d:%s] update %dx%d cursor at %d,%d (0x%08x/%d)&quot;,
<span class="gu">@@ -232,12 +228,26 @@ static void vc4_cursor_plane_atomic_upda</span>
 	if (ret || packet_state[0] != 0)
 		DRM_ERROR(&quot;Failed to set cursor state: 0x%08x\n&quot;, packet_state[0]);
 
<span class="gd">-	ret = rpi_firmware_property(vc4-&gt;firmware,</span>
<span class="gd">-				    RPI_FIRMWARE_SET_CURSOR_INFO,</span>
<span class="gd">-				    &amp;packet_info,</span>
<span class="gd">-				    sizeof(packet_info));</span>
<span class="gd">-	if (ret || packet_info[0] != 0)</span>
<span class="gd">-		DRM_ERROR(&quot;Failed to set cursor info: 0x%08x\n&quot;, packet_info[0]);</span>
<span class="gi">+	/* Note: When the cursor contents change, the modesetting</span>
<span class="gi">+	 * driver calls drm_mode_cursor_univeral() with</span>
<span class="gi">+	 * DRM_MODE_CURSOR_BO, which means a new fb will be allocated.</span>
<span class="gi">+	 */</span>
<span class="gi">+	if (!old_state ||</span>
<span class="gi">+	    state-&gt;crtc_w != old_state-&gt;crtc_w ||</span>
<span class="gi">+	    state-&gt;crtc_h != old_state-&gt;crtc_h ||</span>
<span class="gi">+	    fb != old_state-&gt;fb) {</span>
<span class="gi">+		u32 packet_info[] = { state-&gt;crtc_w, state-&gt;crtc_h,</span>
<span class="gi">+				      0, /* unused */</span>
<span class="gi">+				      bo-&gt;paddr + fb-&gt;offsets[0],</span>
<span class="gi">+				      0, 0, /* hotx, hoty */};</span>
<span class="gi">+</span>
<span class="gi">+		ret = rpi_firmware_property(vc4-&gt;firmware,</span>
<span class="gi">+					    RPI_FIRMWARE_SET_CURSOR_INFO,</span>
<span class="gi">+					    &amp;packet_info,</span>
<span class="gi">+					    sizeof(packet_info));</span>
<span class="gi">+		if (ret || packet_info[0] != 0)</span>
<span class="gi">+			DRM_ERROR(&quot;Failed to set cursor info: 0x%08x\n&quot;, packet_info[0]);</span>
<span class="gi">+	}</span>
 }
 
 static void vc4_cursor_plane_atomic_disable(struct drm_plane *plane,
</pre></div>
