From 2ba0791810cc7f843c49249c1107a9886da66f0f Mon Sep 17 00:00:00 2001 From: Maximilian Hils Date: Thu, 1 Jun 2017 23:35:00 +0200 Subject: fix #2329 --- test/mitmproxy/proxy/test_server.py | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) (limited to 'test') diff --git a/test/mitmproxy/proxy/test_server.py b/test/mitmproxy/proxy/test_server.py index b4bb46bb..8381e511 100644 --- a/test/mitmproxy/proxy/test_server.py +++ b/test/mitmproxy/proxy/test_server.py @@ -1009,6 +1009,40 @@ class TestUpstreamProxySSL( assert len(self.chain[0].tmaster.state.flows) == 0 assert len(self.chain[1].tmaster.state.flows) == 1 + def test_connect_https_to_http(self): + """ + https://github.com/mitmproxy/mitmproxy/issues/2329 + + Client <- HTTPS -> Proxy <- HTTP -> Proxy <- HTTPS -> Server + """ + self.proxy.tmaster.addons.add(RewriteToHttp()) + self.chain[1].tmaster.addons.add(RewriteToHttps()) + p = self.pathoc() + with p.connect(): + resp = p.request("get:'/p/418'") + + assert self.proxy.tmaster.state.flows[0].client_conn.tls_established + assert not self.proxy.tmaster.state.flows[0].server_conn.tls_established + assert not self.chain[1].tmaster.state.flows[0].client_conn.tls_established + assert self.chain[1].tmaster.state.flows[0].server_conn.tls_established + assert resp.status_code == 418 + + +class RewriteToHttp: + def http_connect(self, f): + f.request.scheme = "http" + + def request(self, f): + f.request.scheme = "http" + + +class RewriteToHttps: + def http_connect(self, f): + f.request.scheme = "https" + + def request(self, f): + f.request.scheme = "https" + class UpstreamProxyChanger: def __init__(self, addr): -- cgit v1.2.3 From 5e17b5f62e87970d4cdb7ef1c5176f3e295eb16e Mon Sep 17 00:00:00 2001 From: Maximilian Hils Date: Thu, 1 Jun 2017 23:35:18 +0200 Subject: minor improvements --- test/mitmproxy/proxy/test_server.py | 21 ++++++++++----------- test/mitmproxy/test_log.py | 7 ++++++- 2 files changed, 16 insertions(+), 12 deletions(-) (limited to 'test') diff --git a/test/mitmproxy/proxy/test_server.py b/test/mitmproxy/proxy/test_server.py index 8381e511..bd61f600 100644 --- a/test/mitmproxy/proxy/test_server.py +++ b/test/mitmproxy/proxy/test_server.py @@ -1,28 +1,27 @@ import os import socket import time -import pytest from unittest import mock -from mitmproxy.test import tutils -from mitmproxy import options -from mitmproxy.addons import script -from mitmproxy.addons import proxyauth -from mitmproxy import http -from mitmproxy.proxy.config import HostMatcher +import pytest + import mitmproxy.net.http -from mitmproxy.net import tcp -from mitmproxy.net import socks from mitmproxy import certs from mitmproxy import exceptions +from mitmproxy import http +from mitmproxy import options +from mitmproxy.addons import proxyauth +from mitmproxy.addons import script +from mitmproxy.net import socks +from mitmproxy.net import tcp from mitmproxy.net.http import http1 +from mitmproxy.proxy.config import HostMatcher +from mitmproxy.test import tutils from pathod import pathoc from pathod import pathod - from .. import tservers from ...conftest import skip_appveyor - """ Note that the choice of response code in these tests matters more than you might think. libcurl treats a 304 response code differently from, say, a diff --git a/test/mitmproxy/test_log.py b/test/mitmproxy/test_log.py index 777ab4dd..cde679ed 100644 --- a/test/mitmproxy/test_log.py +++ b/test/mitmproxy/test_log.py @@ -1 +1,6 @@ -# TODO: write tests +from mitmproxy import log + + +def test_logentry(): + e = log.LogEntry("foo", "info") + assert repr(e) == "LogEntry(foo, info)" -- cgit v1.2.3