From 9f16a84a9e771dbbc3314daafaf63449de73d3eb Mon Sep 17 00:00:00 2001 From: Aldo Cortesi Date: Fri, 11 Mar 2011 15:16:31 +1300 Subject: Make mitmdump handle invalid serialized data gracefully. --- libmproxy/dump.py | 3 +-- libmproxy/flow.py | 13 ++++++++++--- 2 files changed, 11 insertions(+), 5 deletions(-) (limited to 'libmproxy') diff --git a/libmproxy/dump.py b/libmproxy/dump.py index 2eb0035e..97232ac7 100644 --- a/libmproxy/dump.py +++ b/libmproxy/dump.py @@ -93,7 +93,7 @@ class DumpMaster(flow.FlowMaster): try: f = file(path, "r") flows = list(flow.FlowReader(f).stream()) - except IOError, v: + except (IOError, flow.FlowReadError), v: raise DumpError(v.strerror) return flows @@ -182,7 +182,6 @@ class DumpMaster(flow.FlowMaster): return f - # begin nocover def run(self): try: diff --git a/libmproxy/flow.py b/libmproxy/flow.py index 60a6ebd2..d555c926 100644 --- a/libmproxy/flow.py +++ b/libmproxy/flow.py @@ -560,6 +560,10 @@ class FlowWriter: s = json.dumps(d) self.ns.write(s) +class FlowReadError(Exception): + @property + def strerror(self): + return self.args[0] class FlowReader: def __init__(self, fo): @@ -570,7 +574,10 @@ class FlowReader: """ Yields Flow objects from the dump. """ - for i in self.ns: - data = json.loads(i) - yield Flow.from_state(data) + try: + for i in self.ns: + data = json.loads(i) + yield Flow.from_state(data) + except netstring.DecoderError: + raise FlowReadError("Invalid data format.") -- cgit v1.2.3