From d1ff52755007703cd2b7d12001091d5fea112245 Mon Sep 17 00:00:00 2001 From: Aldo Cortesi Date: Sun, 4 Sep 2011 10:50:00 +1200 Subject: Reset exit flag when proxy starts. --- libmproxy/controller.py | 2 ++ 1 file changed, 2 insertions(+) (limited to 'libmproxy') diff --git a/libmproxy/controller.py b/libmproxy/controller.py index 756e51e6..67ce2460 100644 --- a/libmproxy/controller.py +++ b/libmproxy/controller.py @@ -80,6 +80,8 @@ class Master: return changed def run(self): + global should_exit + should_exit = False if self.server: slave = Slave(self.masterq, self.server) slave.start() -- cgit v1.2.3 From e5bded7deecb396bef33ebc0a5e345e4d8cf7928 Mon Sep 17 00:00:00 2001 From: Aldo Cortesi Date: Mon, 5 Sep 2011 07:47:47 +1200 Subject: Improve robustness against invalid data. --- libmproxy/proxy.py | 6 ++++-- libmproxy/utils.py | 7 +++++-- 2 files changed, 9 insertions(+), 4 deletions(-) (limited to 'libmproxy') diff --git a/libmproxy/proxy.py b/libmproxy/proxy.py index 5a2a4f43..f0640f23 100644 --- a/libmproxy/proxy.py +++ b/libmproxy/proxy.py @@ -104,7 +104,6 @@ def parse_request_line(request): return method, scheme, host, port, path, minor - class FileLike: def __init__(self, o): self.o = o @@ -197,7 +196,10 @@ class ServerConnection: if not len(parts) == 3: raise ProxyError(502, "Invalid server response: %s."%line) proto, code, msg = parts - code = int(code) + try: + code = int(code) + except ValueError: + raise ProxyError(502, "Invalid server response: %s."%line) headers = flow.Headers() headers.read(self.rfile) if code >= 100 and code <= 199: diff --git a/libmproxy/utils.py b/libmproxy/utils.py index ecf77263..37b751dc 100644 --- a/libmproxy/utils.py +++ b/libmproxy/utils.py @@ -393,8 +393,11 @@ def parse_url(url): if not scheme: return None if ':' in netloc: - host, port = string.split(netloc, ':') - port = int(port) + host, port = string.rsplit(netloc, ':', maxsplit=1) + try: + port = int(port) + except ValueError: + return None else: host = netloc if scheme == "https": -- cgit v1.2.3