From e535985a73a6aee349ac08b07ebe4f652b2eeb29 Mon Sep 17 00:00:00 2001
From: Paul Kehrer <paul.l.kehrer@gmail.com>
Date: Wed, 13 Sep 2017 09:30:51 +0800
Subject: coverage pin test part deux (#3908)

* we pinned coverage for xml generation...let's try everywhere

* add so many comments
---
 .travis/install.sh | 1 +
 Jenkinsfile        | 3 +++
 tox.ini            | 3 ++-
 3 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/.travis/install.sh b/.travis/install.sh
index e65030f1..6090e076 100755
--- a/.travis/install.sh
+++ b/.travis/install.sh
@@ -78,4 +78,5 @@ fi
 
 python -m virtualenv ~/.venv
 source ~/.venv/bin/activate
+# This coverage pin must be kept in sync with tox.ini
 pip install tox codecov coverage==4.3.4
diff --git a/Jenkinsfile b/Jenkinsfile
index b79a407b..93819ab1 100644
--- a/Jenkinsfile
+++ b/Jenkinsfile
@@ -246,6 +246,7 @@ def build(toxenv, label, imageName, artifacts, artifactExcludes) {
                             IF %ERRORLEVEL% NEQ 0 EXIT /B %ERRORLEVEL%
                             virtualenv .codecov
                             call .codecov/Scripts/activate
+                            REM this pin must be kept in sync with tox.ini
                             pip install coverage==4.3.4
                             pip install codecov
                             codecov -e JOB_BASE_NAME,LABEL,TOXENV
@@ -264,6 +265,7 @@ def build(toxenv, label, imageName, artifacts, artifactExcludes) {
                                     tox -r --  --color=yes
                                 virtualenv .venv
                                 source .venv/bin/activate
+                                # This pin must be kept in sync with tox.ini
                                 pip install coverage==4.3.4
                                 bash <(curl -s https://codecov.io/bash) -e JOB_BASE_NAME,LABEL,TOXENV
                             """
@@ -283,6 +285,7 @@ def build(toxenv, label, imageName, artifacts, artifactExcludes) {
                                 fi
                                 virtualenv .venv
                                 source .venv/bin/activate
+                                # This pin must be kept in sync with tox.ini
                                 pip install coverage==4.3.4
                                 bash <(curl -s https://codecov.io/bash) -e JOB_BASE_NAME,LABEL,TOXENV,IMAGE_NAME
                             """
diff --git a/tox.ini b/tox.ini
index 777e9b89..51d81d2c 100644
--- a/tox.ini
+++ b/tox.ini
@@ -6,7 +6,8 @@ envlist = py26,py27,pypy,py33,py34,py35,py36,docs,pep8,py3pep8
 extras =
    test
 deps =
-    coverage
+    # This must be kept in sync with Jenkinsfile and .travis/install.sh
+    coverage==4.3.4
     ./vectors
 passenv = ARCHFLAGS LDFLAGS CFLAGS INCLUDE LIB LD_LIBRARY_PATH USERNAME
 commands =
-- 
cgit v1.2.3