From b3010839385f81c0f62c379aa3bb62862c26ddbb Mon Sep 17 00:00:00 2001 From: Dean Camera Date: Sun, 9 Dec 2018 13:24:51 +1100 Subject: Fix static analysis warnings. --- BuildTests/StaticAnalysisTest/makefile | 3 ++- Demos/Device/LowLevel/RNDISEthernet/Lib/DHCP.c | 4 ++-- LUFA/DoxygenPages/ChangeLog.txt | 20 ++++++++++++++------ 3 files changed, 18 insertions(+), 9 deletions(-) diff --git a/BuildTests/StaticAnalysisTest/makefile b/BuildTests/StaticAnalysisTest/makefile index 9e65e8a3c..199019064 100644 --- a/BuildTests/StaticAnalysisTest/makefile +++ b/BuildTests/StaticAnalysisTest/makefile @@ -13,7 +13,8 @@ LUFA_PATH := ../../LUFA/ CPPCHECK_EXCLUDES := FATFs/ \ PetiteFATFs/ \ - uip/ + uip/ \ + HID/HostLoaderApp/ CPPCHECK_INCLUDES := $(patsubst %/,%,$(LUFA_PATH))/CodeTemplates/ \ $(patsubst %/,%,$(LUFA_PATH))/../Projects/AVRISP-MKII/ diff --git a/Demos/Device/LowLevel/RNDISEthernet/Lib/DHCP.c b/Demos/Device/LowLevel/RNDISEthernet/Lib/DHCP.c index 44849fbff..6fcab3b7d 100644 --- a/Demos/Device/LowLevel/RNDISEthernet/Lib/DHCP.c +++ b/Demos/Device/LowLevel/RNDISEthernet/Lib/DHCP.c @@ -54,8 +54,8 @@ int16_t DHCP_ProcessDHCPPacket(void* IPHeaderInStart, DHCP_Header_t* DHCPHeaderIN = (DHCP_Header_t*)DHCPHeaderInStart; DHCP_Header_t* DHCPHeaderOUT = (DHCP_Header_t*)DHCPHeaderOutStart; - uint8_t* DHCPOptionsINStart = (uint8_t*)(DHCPHeaderInStart + sizeof(DHCP_Header_t)); - uint8_t* DHCPOptionsOUTStart = (uint8_t*)(DHCPHeaderOutStart + sizeof(DHCP_Header_t)); + uint8_t* DHCPOptionsINStart = ((uint8_t*)DHCPHeaderInStart + sizeof(DHCP_Header_t)); + uint8_t* DHCPOptionsOUTStart = ((uint8_t*)DHCPHeaderOutStart + sizeof(DHCP_Header_t)); DecodeDHCPHeader(DHCPHeaderInStart); diff --git a/LUFA/DoxygenPages/ChangeLog.txt b/LUFA/DoxygenPages/ChangeLog.txt index 228e236aa..0880224ad 100644 --- a/LUFA/DoxygenPages/ChangeLog.txt +++ b/LUFA/DoxygenPages/ChangeLog.txt @@ -15,8 +15,12 @@ * - Added Microsoft OS Compatibility descriptors to the RNDIS demos for driverless install on Windows 7 and newer * * Changed: + * - Core: * - Moved the functional descriptor types DTYPE_CSInterface and DTYPE_CSEndpoint to their respective CDC and Audio class * drivers, as they are class-defined rather than general descriptor types. + * - Reduced compiled size of the Endpoint_Discard_Stream() and Endpoint_Null_Stream() functions. + * - Library Applications: + * - Updated Printer class bootloader to not store 32-bit HEX parser flash offsets on small flash devices. * * Fixed: * - Core: @@ -31,6 +35,7 @@ * - Fixed bootloaders not disabling global interrupts during erase and write operations (thanks to Zoltan) * - Fixed bootloaders accepting flash writes to the bootloader region (thanks to NicoHood) * - Fixed bootloaders incorrectly checking the BOOTRST fuse on start (thanks to Braden Kell) + * - Fixed void pointer arithmetic in the low level RNDIS demo protocol decoders * * \section Sec_ChangeLog170418 Version 170418 * New: @@ -46,19 +51,22 @@ * in a user application (thanks to Matlo) * - Fixed missing \c va_end() calls in the HID bootloader CLI app which could cause portability issues * - Fixed void pointer arithmetic in the \c Serial_SendData() functions for AVR8 and XMEGA architectures - * - Fixed void pointer arithmetic in the low level and class driver RNDIS demo protocol decoders - * - Fixed low level RNDIS demo incorrectly setting the RNDIS state when a null packet filter was requested - * - Fixed missing entries in several project's Atmel Studio integration files, such as driver INF files * - Fixed invalid endpoint indexes causing memory corruption in device Clear/Set Feature standard requests (thanks to Peter Popovec) * - Fixed incorrect serialization in USB_SetHIDReportItemInfo() function (thanks to e-chip) + * - Library Applications: + * - Fixed low level RNDIS demo incorrectly setting the RNDIS state when a null packet filter was requested + * - Fixed void pointer arithmetic in the low level and class driver RNDIS demo protocol decoders + * - Fixed missing entries in several project's Atmel Studio integration files, such as driver INF files * * Changed: - * - Added signed alternative libUSB driver for the AVRISP-MKII clone project, to support Atmel Studio 7 (thanks to Atmel) - * - Removed no longer required LIBUSB_DRIVER_COMPAT and RESET_TOGGLES_LIBUSB_COMPAT configuration options from the AVRISP-MKII - * clone project, as the new libUSB driver works for AVRDUDE and Atmel Studio 7 under Windows + * - Core: * - Replaced the LUFA build system with its (compatible) successor, DMBS (Dean's Makefile Build System) * - Removed obsolete library TAR export and associated documentation * - Fixed incorrect HID_DESCRIPTOR_KEYBOARD() macro definition (thanks to Eric Tang) + * - Library Applications: + * - Added signed alternative libUSB driver for the AVRISP-MKII clone project, to support Atmel Studio 7 (thanks to Atmel) + * - Removed no longer required LIBUSB_DRIVER_COMPAT and RESET_TOGGLES_LIBUSB_COMPAT configuration options from the AVRISP-MKII + * clone project, as the new libUSB driver works for AVRDUDE and Atmel Studio 7 under Windows * * \section Sec_ChangeLog151115 Version 151115 * New: -- cgit v1.2.3