aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--googlemock/test/gmock_output_test_.cc8
-rw-r--r--googletest/include/gtest/gtest.h7
2 files changed, 9 insertions, 6 deletions
diff --git a/googlemock/test/gmock_output_test_.cc b/googlemock/test/gmock_output_test_.cc
index 59ea51bd..1b59eb3f 100644
--- a/googlemock/test/gmock_output_test_.cc
+++ b/googlemock/test/gmock_output_test_.cc
@@ -39,14 +39,12 @@
#include "gtest/gtest.h"
-
-// Silence C4100 (unreferenced formal parameter) for MSVC
+// Silence C4100 (unreferenced formal parameter)
#ifdef _MSC_VER
# pragma warning(push)
# pragma warning(disable:4100)
#endif
-
using testing::_;
using testing::AnyNumber;
using testing::Ge;
@@ -306,3 +304,7 @@ int main(int argc, char **argv) {
TestCatchesLeakedMocksInAdHocTests();
return RUN_ALL_TESTS();
}
+
+#ifdef _MSC_VER
+# pragma warning(pop)
+#endif
diff --git a/googletest/include/gtest/gtest.h b/googletest/include/gtest/gtest.h
index cbab121a..a0592a82 100644
--- a/googletest/include/gtest/gtest.h
+++ b/googletest/include/gtest/gtest.h
@@ -82,11 +82,12 @@
namespace testing {
-// Silence C4100 (unreferenced formal parameter) for MSVC
+// Silence C4100 (unreferenced formal parameter) and 4805
+// unsafe mix of type 'const int' and type 'const bool'
#ifdef _MSC_VER
# pragma warning(push)
-# pragma warning(disable:4100)
# pragma warning(disable:4805)
+# pragma warning(disable:4100)
#endif
@@ -2307,7 +2308,7 @@ bool StaticAssertTypeEq() {
GTEST_API_ std::string TempDir();
#ifdef _MSC_VER
-# pragma warning(pop)
+# pragma warning(pop)
#endif
} // namespace testing