aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | [Pulse4k] Various improvementsMaxr19982020-05-174-76/+66
| | | | | | | | Rework led adjustment combo (have it defined by keymap now), reformat code, update copyright
* | DZ60: update to current template & code style (#9113)Ryan2020-05-167-172/+139
| |
* | Adding unit tests for list-keymaps command (#7711)codecoffeecode2020-05-161-10/+26
| | | | | | | | Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com> Co-Authored-By: Erovia <Erovia@users.noreply.github.com>
* | [Keymap] Add Via support to the Melody96 (#9050)Vincent Lee2020-05-165-3/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add files needed to The Via support on Melody 96 * Remove manufacture name from product name * replace blank key with Transparent keys * Update keyboards/melody96/rules.mk * Update keyboards/melody96/keymaps/via/keymap.c * Change Product ID to "M" + 96 * Update keyboards/melody96/keymaps/via/rules.mk * add LTO to via's local file * Update keyboards/melody96/rules.mk
* | [Keymap] VIA Support: Exclusive E7-V1 (#9038)MechMerlin2020-05-164-5/+58
| | | | | | | | | | | | | | | | | | | | * add a VIA Keymap * update VID and PID * update readme * Update keyboards/exclusive/e7v1/readme.md
* | [Docs] Clarify layer transparency keymap.md (#9081)Nick Blyumberg2020-05-161-4/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Revised the grammar and clarity of the Layer Precedence and Transparency * Update docs/keymap.md * Update docs/keymap.md * Update docs/keymap.md * Update docs/keymap.md * Update docs/keymap.md * Update docs/keymap.md * Update docs/keymap.md
* | [Keyboard] Rebound rev3 (#9101)Rossman3602020-05-1612-6/+514
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * more stoof * readme update * reverting keymap * re-adding userspace * new userspace needed * no want 0 under thumb * gettin fancier with my knob * macro fix * had pins for oled ver * wait, these are the right pins * reduntant line * image fix * get highest layer every day * whoops * correct rev name in json * a few good catches * what I had planned
* | [Phoebe] Keymap improvements (#9092)Max Rumpf2020-05-153-49/+71
| | | | | | Enable leader key with some useful macros, use fancier design for keymap previews in code, other smaller tweaks
* | [Keymap] Update personal userspace and keymaps (#9082)Konstantin Đorđević2020-05-1512-29/+75
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Replace custom RCTRL implementation with built-in LM Caveat: sends LCtrl instead of RCtrl * Enable VIA support in KBD6X keymap * Disable LTO on ChibiOS boards * Disable locking support and Magic keycodes for all keymaps * Organize and annotate rules.mk and config.h files * Enable Console for Melody96 keymap * L_RANGE_KEYMAP → LAYERS_KEYMAP * Revert "Replace custom RCTRL implementation with built-in LM" This reverts commit 17d706a82d7e31b53cd84efeb9b2ddb9922a2368. * Set DYNAMIC_KEYMAP_LAYER_COUNT to 3 in Doro67 and Wasdat keymaps * Enable Bootmagic Lite for all VIA keymaps
* | [Keymap] Added the K.O,Y layout for the xd75 and atreus62 boards (#9079)Paul Scheikl2020-05-159-0/+342
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * added koy layout to qmk on xd75 board * added koy keymap for the atreus62 board * reduced time for autoshift * added documentation * changed layer 7 to a tap toggle and adjusted mouse speed a little * Update keyboards/xd75/keymaps/ScheiklP/koy_keys_on_quertz_de_latin1.h * Update keyboards/xd75/keymaps/ScheiklP/koy_keys_on_quertz_de_latin1.h * Update keyboards/xd75/keymaps/ScheiklP/koy_common.h * Update keyboards/atreus62/keymaps/ScheiklP/koy_common.h * Update keyboards/atreus62/keymaps/ScheiklP/koy_keys_on_quertz_de_latin1.h * Update keyboards/atreus62/keymaps/ScheiklP/koy_keys_on_quertz_de_latin1.h * changed keymap to lowercase name to conform with qmk guidelines * Update keyboards/xd75/keymaps/scheiklp/rules.mk remove unnecessary rules * Update keyboards/atreus62/keymaps/scheiklp/rules.mk remove unnecessary rules * moved common files for koy layouts to the users folder and removed empty file * Update keyboards/atreus62/keymaps/scheiklp/keymap.c * Update keyboards/xd75/keymaps/scheiklp/readme.md * Update keyboards/xd75/keymaps/scheiklp/readme.md * Update keyboards/atreus62/keymaps/scheiklp/readme.md * Update keyboards/atreus62/keymaps/scheiklp/readme.md
* | [Keymap] adds pvillano's preonic keymap (#9106)Peter (Rocky) Villano2020-05-154-0/+171
| | | | | | | | | | | | * adds pvillano's preonic keymap * Remove unnecessary "\" (tested - ok)
* | [Keyboard] Added wilba.tech WT60-C (#9025)Wilba2020-05-159-0/+297
| |
* | CLI: Tune doctor's udev rule checking to match #8750Erovia2020-05-152-10/+42
| |
* | [kle2info] Trim the code in `kle2xy` (#8955)Keenan Brock2020-05-151-28/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | * [kle2jinfo] use min/max instead of if This is a slight change. Before, the key_skel would keep the invalid value for future keys. I think this is what was actually intended. * [kle2info] calculate x x is the current_x * key_size + (key_size/2) y is the current_y * key_size + (key_size/2) no reason to track both
* | Update j3rn keymap (#9100)Jonathan Arnett2020-05-162-20/+24
| |
* | update dlg's tada68 keymap (#9098)dlgoodr2020-05-162-18/+58
| |
* | stanrc85 userspace and keymap updates (#9103)stanrc852020-05-153-6/+7
| | | | | | | | | | * Update flash command in userspace * Switch to BackspaceFN on split spacebar
* | [Keyboard] Added wilba.tech WT80-BC (#9024)Wilba2020-05-159-0/+245
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Added WT80-BC * Update keyboards/wilba_tech/wt80_bc/info.json * Update keyboards/wilba_tech/wt80_bc/info.json * Update keyboards/wilba_tech/wt80_bc/rules.mk * Update keyboards/wilba_tech/wt80_bc/rules.mk * Update keyboards/wilba_tech/wt80_bc/rules.mk * Update keyboards/wilba_tech/wt80_bc/wt80_bc.h
* | Fixed Murciélago info.json to work with qmk configurator -> wrong ↵Adrian2020-05-152-5/+70
| | | | | | | | | | | | | | | | | | | | | | assignments (#9095) * fixed json to work with qmk configurator updates to readme * Change spacing of keys * changed overall size of keymap
* | avoid 'Entering|Leaving directory' messages (#9061)Joel Challis2020-05-141-0/+3
| |
* | Fix bad key labels in ascii art (#9094)Conor Fischer2020-05-141-1/+1
| |
* | Improve stock bootloader list (#9067)Ryan2020-05-137-418/+678
| | | | | | | | | | | | | | | | | | | | | | | | | | * Improve stock bootloader list * Switch version numbers on USB64/128 bootloaders * Unix line endings for PS2AVRGB bootloader * Update PS2AVRGB bootloader to 1.0.1 * Also mention bootloader rule * Didn't need to change the links
* | V-USB Interface reorder (#9090)yiancar2020-05-142-73/+79
| |
* | One shot support for swap hands (#8590)Zsolt Parragi2020-05-147-1/+93
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commits add the SH_OS keycode, which works similarly to one shot layers: * while pressed, the keyboard is swapped * if no keys were pressed while it was pressed, the next key press is swapped SH_OS also supports chaining with one shot layers: OSL(x) + SH_OS + key interprets the key press on the oneshot layer. The ONESHOT_TIMEOUT setting used by one shot keys and layers is also used by oneshot swap hands. In the above chaining scenario the timeout of the oneshot layer is reset when swap hands is activated. Resolves #2682
* | Allow expanding from 8 to 32 RGB Lighting Layers (#8941)Joshua Diamond2020-05-134-4/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Allow 16 lighting layers * Require #define RGBLIGHT_LAYERS_16 to enable 16 layers * Override RGBLIGHT_MAX_LAYERS to set maximum number of lighting layers * Enforce lower bound on RGBLIGHT_MAX_LAYERS Co-Authored-By: Takeshi ISHII <2170248+mtei@users.noreply.github.com> * Fix an error in the check for valid RGBLIGHT_MAX_LAYERS * Don't use bitfield / PACKED, as it causes bloat * Update documentation re: up to 32 lighting layers * Run cformat * Add note about increasing FW size in docs/config_options.md Co-authored-by: Drashna Jaelre <drashna@live.com> * Remove no-longer-valid comment * Add doc note that split sync will be slower Co-authored-by: Takeshi ISHII <2170248+mtei@users.noreply.github.com> Co-authored-by: Drashna Jaelre <drashna@live.com>
* | added murcielago keyboard (#8920)Adrian2020-05-1310-0/+483
| | | | | | | | | | * Squashed pull request for murcielago * removed rotation prior to creating info.json
* | optimize source code for size. reduce compiled binary size 292 bytes (#8428)bottilabo2020-05-141-63/+77
| | | | | | | | | | * optimize source code for size. reduce compiled binary size 292 bytes * more size optimization
* | Fix incorrect key sizes in Configurator (#9073)James Young2020-05-135-13/+13
| | | | | | | | | | | | | | | | | | | | | | * fix key size: exclusive/e6v2/le_bmc * fix key size: exclusive/e6v2/oe_bmc * fix key sizes: flx/lodestone * fix key size: handwired/prime_exl * fix key sizes: massdrop/ctrl
* | [Keyboard] Added support for Aves 65 (#8880)Hund2020-05-137-0/+233
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * First commit. * Apply suggestions from code review Co-Authored-By: Drashna Jaelre <drashna@live.com> Co-Authored-By: Ryan <fauxpark@gmail.com> * Update keyboards/aves65/rules.mk Co-Authored-By: Joel Challis <git@zvecr.com> * Update keyboards/aves65/aves65.h Co-Authored-By: Joel Challis <git@zvecr.com> * Update keyboards/aves65/keymaps/default/keymap.c Co-Authored-By: Joel Challis <git@zvecr.com> * Update keyboards/aves65/rules.mk Co-Authored-By: Joel Challis <git@zvecr.com> * Changes. * Changes * Changes * Update keyboards/aves65/rules.mk Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Hund <hund@ubuntu.com> Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Joel Challis <git@zvecr.com>
* | Update Neo2 keymap (#9063)Ryan2020-05-131-58/+122
| |
* | Update Canadian Multilingual keymap and add sendstring LUT (#8786)Ryan2020-05-132-236/+510
| |
* | Updated rules.mk to allow for audio control in VIA (#9087)eniigmakeyboards2020-05-131-1/+1
| |
* | fixed typo for clear lcd screen function in hd44780 docs (#9086)floookay2020-05-132-2/+2
| | | | | | | | | | | | | | * fixed typo for clear lcd screen function brought to attention by #9085 * fixed typo for clear lcd screen function (ja docs)
* | Added defines for RAISE and LOWER (#9083)Xyverz2020-05-131-1/+3
| | | | | | | | I like being able to use layers. This fixes my screw-up from my last code overhaul.
* | Optimization for scanning less layers. (#8311)Alex Ong2020-05-112-3/+14
| | | | | | | | | | * Optimization for scanning less layers. * Rename NUM_LAYERS to MAX_LAYER.
* | [Keyboard] Add P40, P20 and P18 Keyboards by pabile (#8759)pabile2020-05-0920-0/+466
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add files via upload * removed * Add files via upload * Rename pabile40.c to p40.c * Rename pabile40.h to p40.h * Add files via upload * Update p40.c * Update p40.h * Update README.md * Update README.md * Update README.md * Update README.md * Updated readme file * Updated readme file * Add files via upload * modified: keyboards/pabile/p18/config.h modified: keyboards/pabile/p18/keymaps/default/keymap.c modified: keyboards/pabile/p18/p18.h modified: keyboards/pabile/p18/rules.mk modified: keyboards/pabile/p40/config.h modified: keyboards/pabile/p40/keymaps/default/keymap.c * config update * Delete README.md.save * Delete keymap.c.save * Delete keymaps.c * modified: keyboards/pabile/p18/keymaps/default/keymap.c * Update p18.h * testing layout config * Create info.json * Create info.json * Create readme.md * Update readme.md * Updated description * Updated description * Update config.h updated vendor ID to 0000 * Update keymap.c removed unnecessary comments * Update keyboards/pabile/p18/p18.h * Update keyboards/pabile/p18/p18.h * Update p18.h removed unnecessary comments * Update keyboards/pabile/p18/rules.mk * Update keyboards/pabile/p18/rules.mk * Update config.h updated vendor id and removed unnecessary comments * Update keyboards/pabile/p40/info.json * Update keyboards/pabile/p40/keymaps/default/keymap.c * Update keyboards/pabile/p40/p40.h * Update keyboards/pabile/p40/p40.h * Update keyboards/pabile/p40/p40.h * Update keyboards/pabile/p40/rules.mk * Update keyboards/pabile/p40/rules.mk * Added p20 macropad * Update README.md * Updated VID and PID * Updated VID and PID * Update rules.mk * Update config.h * Update config.h * Update config.h * Update keymap.c * Replaced blank keys with KC_NO * Update keyboards/pabile/p18/keymaps/default/keymap.c * Update keyboards/pabile/p18/p18.h * Update keyboards/pabile/p18/rules.mk * Update keyboards/pabile/p20/keymaps/default/keymap.c * Update keymap.c * Update keymap.c * Update keyboards/pabile/p20/rules.mk * Update keyboards/pabile/p40/info.json * Update keyboards/pabile/p20/p20.h * Updated product ID * Updated product ID * Update keyboards/pabile/p20/config.h * Update keyboards/pabile/p20/p20.h * Update keyboards/pabile/p20/p20.h * Update keyboards/pabile/p20/keymaps/default/keymap.c * Update keyboards/pabile/p18/readme.md * Update keyboards/pabile/p20/README.md * Update keyboards/pabile/p20/rules.mk * Update keyboards/pabile/p20/rules.mk * Update keyboards/pabile/p20/rules.mk * Update keyboards/pabile/p20/rules.mk * Update keyboards/pabile/p40/README.md * Update keyboards/pabile/p40/rules.mk * Update keyboards/pabile/p40/rules.mk * Update keyboards/pabile/p18/rules.mk * Update keyboards/pabile/p18/rules.mk * Update keyboards/pabile/p40/config.h * Update keyboards/pabile/p40/config.h * Update keyboards/pabile/p18/readme.md * Changed to lowercase filename * Rename README.md to readme.md * Update keyboards/pabile/p18/rules.mk
* | Add one-handed Viterbi layout for gaming (#8963)Chuck Lauer Vose2020-05-104-1/+152
| | | | | | | | | | | | | | | | | | | | | | * Add one-handed Viterbi layout for gaming * fixes for pr feedback * Update keyboards/keebio/viterbi/keymaps/vosechu/config.h Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Joel Challis <git@zvecr.com>
* | Fix off by one error with oled_write_raw_P (#9045)Brian Mock2020-05-101-1/+1
| |
* | Improve security of avrdude by eliminating the use of well-known names. (#9026)Zach White2020-05-101-5/+8
| | | | | | | | | | | | | | | | | | * Improve security by eliminating the use of well-known names. * Add an additional $ so the shell expands $TMP1 and $TMP2 Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Joel Challis <git@zvecr.com>
* | [Keymap] Added MACLOCK macro (#9037)Xyverz2020-05-092-9/+8
| | | | | | | | | | | | | | | | | | * Added MACLOCK macro Added my MACLOCK macro to my Atreus keymap. * Updated comments & readme Documented where in the layout I added the MACLOCK macro.
* | [Keymap] added shifted symbols support (#9059)TheFourthCow2020-05-091-3/+3
| | | | | | * added shifted symbols to default keymap
* | [Keymap] Add nblyumberg 1upkeyboards super16 keymap (#8902)Nick Blyumberg2020-05-094-0/+148
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Updated with my super16 version for my keypad * Added my folder to super16 * Set max LED brightness to 50% * Added custom keycodes for enter/shift+enter and copy/paste on one key * Fixed the boot up layer color * Renamed folder * Revert changes to root super16 files * Update keymap config.h and rules.mk files * Restore deleted 15game keymap files * Corrected the hold keycode for CCCV * Removed unnecessary comments * Update keyboards/1upkeyboards/super16/keymaps/nblyumberg/keymap.c Co-Authored-By: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/1upkeyboards/super16/keymaps/nblyumberg/config.h Co-Authored-By: ridingqwerty <george.g.koenig@gmail.com> * Update keyboards/1upkeyboards/super16/keymaps/nblyumberg/keymap.c Co-Authored-By: ridingqwerty <george.g.koenig@gmail.com> * Rewriting the layer color functionality * Revisions * Fixed the layer switching * Fixed the default layer color problem * Added a function suggested by Drashna but it won't compile * Cleaned up the code for PR * Removed unnecessary define for layer colors Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
* | Docs: fix links in feature_hd44780.md (#9053)James Young2020-05-091-2/+2
| | | | | | The referenced site was moved.
* | [Keymap] Add Chidori OLED-enabled sample keymap (#8446)1m382020-05-093-0/+220
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * create chidori/oled_sample keymap * Implement OLED enabled keymap * Update readme.md * Update keyboards/chidori/keymaps/oled_sample/keymap.c * Update keyboards/chidori/keymaps/oled_sample/keymap.c * delete chidori:oled_sample/config.h * use oled_write_ln_P to print layer state * delete unnecessary include * merge nested switches in oled_write_layer_state()
* | [Keyboard] add adelais PCB (#8945)mechlovin2020-05-0915-0/+384
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * add adelais PCB * clean up * merger * update * Update readme.md * Update config.h * update * update * move keymap folder * Update info.json * Update info.json * Update info.json Co-authored-by: vuhopkep <boy9x0@gmail.com>
* | format code according to conventions [skip ci]QMK Bot2020-05-092-15/+14
| |
* | New RGB Lighting effect: Twinkle (#8887)Joshua Diamond2020-05-094-4/+100
| | | | | | | | | | | | | | | | | | | | | | | | | | * Add twinkle RGB Lighting effect * 2nd twinkle algo - double-buffering * Further refinement: Per-LED twinkle * Add documentation for Twinkle RBG Lighting mode * Bias twinkle saturation closer to the set value * Fix whitespace
* | Add ability to blink lighting layer for a specified duration (#8760)Joshua Diamond2020-05-094-3/+79
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Implement momentarily blink of lighting layers * Refactor spidey3 userspace to use rgb layer blink * Remove un-necessary line from example in documentation * Revert "Refactor spidey3 userspace to use rgb layer blink" This reverts commit 831649bb680c41c6d663ae6fa86d13f4f8bebdd8. * Adds a missing bit of documentation about lighting layer blink * Update docs/feature_rgblight.md per suggestions Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com> * Update docs/feature_rgblight.md per suggestions Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com> * Update docs/feature_rgblight.md per suggestions Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com> * cformat, as suggested Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
* | Fix bug in UC_RMOD, add shift and audio support for UC_MOD/UC_RMOD(#8674)Konstantin Đorđević2020-05-094-51/+74
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Invert UC_MOD/UC_RMOD direction when Shift is held Also use MOD_MASK_SHIFT in process_rgb.c * Allow audio to be played for UC_MOD, UC_RMOD keycodes as well * Fix signedness bug in reverse input mode cycling * Misc formatting in process_unicode_common.c * Address clang-format issues * Make decode_utf8 helper function file-local (static)
* | [Keyboard] Added D48 keyboard (#8548)Andrew Dunai2020-05-0821-0/+1348
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * [Keyboard] Added D48 keyboard. * Updated README. * Cleanups. * Moved d48 to handwired/ * Added link to build process album. * Coding conventions cleanups. * Added DS1307 RTC! * Minor cleanups. * Apply suggestions from code review Co-Authored-By: Drashna Jaelre <drashna@live.com> * Minor refactoring. * Readme fix. * Moved leftover keymap-specific code from keyboard space into keymap. * Added encoder button pins to extra matrix row. * Updated README, updated pinout & cleaned up the glcdfont * Apply suggestions from code review Co-Authored-By: Drashna Jaelre <drashna@live.com> * Update config.h * Apply suggestions from code review Co-Authored-By: Ryan <fauxpark@gmail.com> * Added default keymap. Refactored existing keymap. * Update keyboards/handwired/d48/README.md Co-Authored-By: Ryan <fauxpark@gmail.com> * Apply suggestions from code review Co-Authored-By: Joel Challis <git@zvecr.com> * Minor alignment fix. * Update keyboards/handwired/d48/glcdfont_d48.c Co-Authored-By: Ryan <fauxpark@gmail.com> * Changes as per PR. * Apply suggestions from code review Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com> Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>