From 41504f2f4adec1cef7db08293c616c6ace7f895f Mon Sep 17 00:00:00 2001
From: Giovanni Di Sirio <gdisirio@gmail.com>
Date: Wed, 20 Sep 2017 17:12:38 +0000
Subject: Improved OpenOCD launch configurations.

git-svn-id: svn://svn.code.sf.net/p/chibios/svn/trunk@10655 35acf78f-673a-0410-8e92-d51de3d6d3f4
---
 readme.txt                                            |  4 +++-
 ...OCD (prompts for .cfg target configuration).launch | 19 +++++++++----------
 ... V1 (prompts for .cfg target configuration).launch | 19 +++++++++----------
 ... V2 (prompts for .cfg target configuration).launch | 19 +++++++++----------
 ...2-1 (prompts for .cfg target configuration).launch | 19 +++++++++----------
 5 files changed, 39 insertions(+), 41 deletions(-)

diff --git a/readme.txt b/readme.txt
index 6d44c2da4..8b925b0be 100644
--- a/readme.txt
+++ b/readme.txt
@@ -112,7 +112,9 @@
        ./tools/eclipse/debug. Now it is no more required to re-create
        those each time a new workspace is created, just import the global
        ChibiOS project in it. The configurations will appear under the
-       Eclipse Tools menu.
+       Eclipse Tools menu. It is required to create an OPENOCD environment
+       variable pointing to the OpenOCD executable. It will be done in
+       ChibiStudio 20 by default.
 - NEW: Improved the various rules.mk to handle "touching" of all
        included makefiles, now the makefile is no more assumed to
        be called "Makefile".
diff --git a/tools/eclipse/debug/OpenOCD on Olimex ARM-USB-OCD (prompts for .cfg target configuration).launch b/tools/eclipse/debug/OpenOCD on Olimex ARM-USB-OCD (prompts for .cfg target configuration).launch
index 1f94272fa..fd552ce4b 100644
--- a/tools/eclipse/debug/OpenOCD on Olimex ARM-USB-OCD (prompts for .cfg target configuration).launch	
+++ b/tools/eclipse/debug/OpenOCD on Olimex ARM-USB-OCD (prompts for .cfg target configuration).launch	
@@ -1,10 +1,9 @@
-<?xml version="1.0" encoding="UTF-8" standalone="no"?>
-<launchConfiguration type="org.eclipse.ui.externaltools.ProgramLaunchConfigurationType">
-<listAttribute key="org.eclipse.debug.ui.favoriteGroups">
-<listEntry value="org.eclipse.ui.externaltools.launchGroup"/>
-</listAttribute>
-<stringAttribute key="org.eclipse.ui.externaltools.ATTR_LAUNCH_CONFIGURATION_BUILD_SCOPE" value="${none}"/>
-<stringAttribute key="org.eclipse.ui.externaltools.ATTR_LOCATION" value="${eclipse_home}\..\tools\openocd\bin\openocd.exe"/>
-<stringAttribute key="org.eclipse.ui.externaltools.ATTR_TOOL_ARGUMENTS" value="-c &quot;telnet_port 4444&quot; -f &quot;interface/olimex-arm-usb-ocd.cfg&quot; -f &quot;${file_prompt}&quot;"/>
-<stringAttribute key="org.eclipse.ui.externaltools.ATTR_WORKING_DIRECTORY" value="${eclipse_home}\..\tools\openocd\bin\"/>
-</launchConfiguration>
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<launchConfiguration type="org.eclipse.ui.externaltools.ProgramLaunchConfigurationType">
+<listAttribute key="org.eclipse.debug.ui.favoriteGroups">
+<listEntry value="org.eclipse.ui.externaltools.launchGroup"/>
+</listAttribute>
+<stringAttribute key="org.eclipse.ui.externaltools.ATTR_LAUNCH_CONFIGURATION_BUILD_SCOPE" value="${none}"/>
+<stringAttribute key="org.eclipse.ui.externaltools.ATTR_LOCATION" value="${env_var:OPENOCD}"/>
+<stringAttribute key="org.eclipse.ui.externaltools.ATTR_TOOL_ARGUMENTS" value="-c &quot;telnet_port 4444&quot; -f &quot;interface/olimex-arm-usb-ocd.cfg&quot; -f &quot;${file_prompt}&quot;"/>
+</launchConfiguration>
diff --git a/tools/eclipse/debug/OpenOCD on ST-Link V1 (prompts for .cfg target configuration).launch b/tools/eclipse/debug/OpenOCD on ST-Link V1 (prompts for .cfg target configuration).launch
index c3778ea7b..9c0956353 100644
--- a/tools/eclipse/debug/OpenOCD on ST-Link V1 (prompts for .cfg target configuration).launch	
+++ b/tools/eclipse/debug/OpenOCD on ST-Link V1 (prompts for .cfg target configuration).launch	
@@ -1,10 +1,9 @@
-<?xml version="1.0" encoding="UTF-8" standalone="no"?>
-<launchConfiguration type="org.eclipse.ui.externaltools.ProgramLaunchConfigurationType">
-<listAttribute key="org.eclipse.debug.ui.favoriteGroups">
-<listEntry value="org.eclipse.ui.externaltools.launchGroup"/>
-</listAttribute>
-<stringAttribute key="org.eclipse.ui.externaltools.ATTR_LAUNCH_CONFIGURATION_BUILD_SCOPE" value="${none}"/>
-<stringAttribute key="org.eclipse.ui.externaltools.ATTR_LOCATION" value="${eclipse_home}\..\tools\openocd\bin\openocd.exe"/>
-<stringAttribute key="org.eclipse.ui.externaltools.ATTR_TOOL_ARGUMENTS" value="-c &quot;telnet_port 4444&quot; -f &quot;interface/stlink-v1.cfg&quot; -f &quot;${file_prompt}&quot;"/>
-<stringAttribute key="org.eclipse.ui.externaltools.ATTR_WORKING_DIRECTORY" value="${eclipse_home}\..\tools\openocd\bin\"/>
-</launchConfiguration>
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<launchConfiguration type="org.eclipse.ui.externaltools.ProgramLaunchConfigurationType">
+<listAttribute key="org.eclipse.debug.ui.favoriteGroups">
+<listEntry value="org.eclipse.ui.externaltools.launchGroup"/>
+</listAttribute>
+<stringAttribute key="org.eclipse.ui.externaltools.ATTR_LAUNCH_CONFIGURATION_BUILD_SCOPE" value="${none}"/>
+<stringAttribute key="org.eclipse.ui.externaltools.ATTR_LOCATION" value="${env_var:OPENOCD}"/>
+<stringAttribute key="org.eclipse.ui.externaltools.ATTR_TOOL_ARGUMENTS" value="-c &quot;telnet_port 4444&quot; -f &quot;interface/stlink-v1.cfg&quot; -f &quot;${file_prompt}&quot;"/>
+</launchConfiguration>
diff --git a/tools/eclipse/debug/OpenOCD on ST-Link V2 (prompts for .cfg target configuration).launch b/tools/eclipse/debug/OpenOCD on ST-Link V2 (prompts for .cfg target configuration).launch
index 01728ced6..52a239749 100644
--- a/tools/eclipse/debug/OpenOCD on ST-Link V2 (prompts for .cfg target configuration).launch	
+++ b/tools/eclipse/debug/OpenOCD on ST-Link V2 (prompts for .cfg target configuration).launch	
@@ -1,10 +1,9 @@
-<?xml version="1.0" encoding="UTF-8" standalone="no"?>
-<launchConfiguration type="org.eclipse.ui.externaltools.ProgramLaunchConfigurationType">
-<listAttribute key="org.eclipse.debug.ui.favoriteGroups">
-<listEntry value="org.eclipse.ui.externaltools.launchGroup"/>
-</listAttribute>
-<stringAttribute key="org.eclipse.ui.externaltools.ATTR_LAUNCH_CONFIGURATION_BUILD_SCOPE" value="${none}"/>
-<stringAttribute key="org.eclipse.ui.externaltools.ATTR_LOCATION" value="${eclipse_home}\..\tools\openocd\bin\openocd.exe"/>
-<stringAttribute key="org.eclipse.ui.externaltools.ATTR_TOOL_ARGUMENTS" value="-c &quot;telnet_port 4444&quot; -s &quot;/ChibiStudio/tools/openocd/scripts&quot; -f &quot;interface/stlink-v2.cfg&quot; -f &quot;${file_prompt}&quot;"/>
-<stringAttribute key="org.eclipse.ui.externaltools.ATTR_WORKING_DIRECTORY" value="${eclipse_home}\..\tools\openocd\bin\"/>
-</launchConfiguration>
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<launchConfiguration type="org.eclipse.ui.externaltools.ProgramLaunchConfigurationType">
+<listAttribute key="org.eclipse.debug.ui.favoriteGroups">
+<listEntry value="org.eclipse.ui.externaltools.launchGroup"/>
+</listAttribute>
+<stringAttribute key="org.eclipse.ui.externaltools.ATTR_LAUNCH_CONFIGURATION_BUILD_SCOPE" value="${none}"/>
+<stringAttribute key="org.eclipse.ui.externaltools.ATTR_LOCATION" value="${env_var:OPENOCD}"/>
+<stringAttribute key="org.eclipse.ui.externaltools.ATTR_TOOL_ARGUMENTS" value="-c &quot;telnet_port 4444&quot; -s &quot;/ChibiStudio/tools/openocd/scripts&quot; -f &quot;interface/stlink-v2.cfg&quot; -f &quot;${file_prompt}&quot;"/>
+</launchConfiguration>
diff --git a/tools/eclipse/debug/OpenOCD on ST-Link V2-1 (prompts for .cfg target configuration).launch b/tools/eclipse/debug/OpenOCD on ST-Link V2-1 (prompts for .cfg target configuration).launch
index 18cf5f345..f316e62f8 100644
--- a/tools/eclipse/debug/OpenOCD on ST-Link V2-1 (prompts for .cfg target configuration).launch	
+++ b/tools/eclipse/debug/OpenOCD on ST-Link V2-1 (prompts for .cfg target configuration).launch	
@@ -1,10 +1,9 @@
-<?xml version="1.0" encoding="UTF-8" standalone="no"?>
-<launchConfiguration type="org.eclipse.ui.externaltools.ProgramLaunchConfigurationType">
-<listAttribute key="org.eclipse.debug.ui.favoriteGroups">
-<listEntry value="org.eclipse.ui.externaltools.launchGroup"/>
-</listAttribute>
-<stringAttribute key="org.eclipse.ui.externaltools.ATTR_LAUNCH_CONFIGURATION_BUILD_SCOPE" value="${none}"/>
-<stringAttribute key="org.eclipse.ui.externaltools.ATTR_LOCATION" value="${eclipse_home}\..\tools\openocd\bin\openocd.exe"/>
-<stringAttribute key="org.eclipse.ui.externaltools.ATTR_TOOL_ARGUMENTS" value="-c &quot;telnet_port 4444&quot; -s &quot;/ChibiStudio/tools/openocd/scripts&quot; -f &quot;interface/stlink-v2-1.cfg&quot; -f &quot;${file_prompt}&quot;"/>
-<stringAttribute key="org.eclipse.ui.externaltools.ATTR_WORKING_DIRECTORY" value="${eclipse_home}\..\tools\openocd\bin\"/>
-</launchConfiguration>
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<launchConfiguration type="org.eclipse.ui.externaltools.ProgramLaunchConfigurationType">
+<listAttribute key="org.eclipse.debug.ui.favoriteGroups">
+<listEntry value="org.eclipse.ui.externaltools.launchGroup"/>
+</listAttribute>
+<stringAttribute key="org.eclipse.ui.externaltools.ATTR_LAUNCH_CONFIGURATION_BUILD_SCOPE" value="${none}"/>
+<stringAttribute key="org.eclipse.ui.externaltools.ATTR_LOCATION" value="${env_var:OPENOCD}"/>
+<stringAttribute key="org.eclipse.ui.externaltools.ATTR_TOOL_ARGUMENTS" value="-c &quot;telnet_port 4444&quot; -s &quot;/ChibiStudio/tools/openocd/scripts&quot; -f &quot;interface/stlink-v2-1.cfg&quot; -f &quot;${file_prompt}&quot;"/>
+</launchConfiguration>
-- 
cgit v1.2.3