From 1fa657d77dde43a9c283a67bf86c57531f624437 Mon Sep 17 00:00:00 2001 From: gdisirio Date: Sun, 22 Feb 2009 08:43:49 +0000 Subject: Removed unused port functionality port_puts(). git-svn-id: svn://svn.code.sf.net/p/chibios/svn/trunk@800 35acf78f-673a-0410-8e92-d51de3d6d3f4 --- demos/Win32-MinGW/chcore.c | 8 -------- demos/Win32-MinGW/chcore.h | 1 - ports/ARM7/chcore.c | 10 ---------- ports/ARM7/chcore.h | 1 - ports/ARMCM3/chcore.c | 13 ------------- ports/ARMCM3/chcore.h | 1 - ports/AVR/chcore.c | 13 ------------- ports/AVR/chcore.h | 1 - ports/MSP430/chcore.c | 13 ------------- ports/MSP430/chcore.h | 1 - readme.txt | 2 ++ src/templates/chcore.c | 8 -------- src/templates/chcore.h | 1 - todo.txt | 3 +-- 14 files changed, 3 insertions(+), 73 deletions(-) diff --git a/demos/Win32-MinGW/chcore.c b/demos/Win32-MinGW/chcore.c index 446508e3c..a2194336c 100644 --- a/demos/Win32-MinGW/chcore.c +++ b/demos/Win32-MinGW/chcore.c @@ -93,14 +93,6 @@ void ChkIntSources(void) { } } -/** - * Prints a message on the system console. - * @param msg pointer to the message - */ -__attribute__((fastcall)) -void port_puts(char *msg) { -} - /** * Performs a context switch between two threads. * @param otp the thread to be switched out diff --git a/demos/Win32-MinGW/chcore.h b/demos/Win32-MinGW/chcore.h index 97f248a54..276b935da 100644 --- a/demos/Win32-MinGW/chcore.h +++ b/demos/Win32-MinGW/chcore.h @@ -192,7 +192,6 @@ struct context { #ifdef __cplusplus extern "C" { #endif - __attribute__((fastcall)) void port_puts(char *msg); __attribute__((fastcall)) void port_switch(Thread *otp, Thread *ntp); __attribute__((fastcall)) void port_halt(void); void InitCore(void); diff --git a/ports/ARM7/chcore.c b/ports/ARM7/chcore.c index fd7661373..d0e0071bf 100644 --- a/ports/ARM7/chcore.c +++ b/ports/ARM7/chcore.c @@ -26,16 +26,6 @@ #include -/** - * Prints a message on the system console. - * @param msg pointer to the message - */ -/** @cond never */ -__attribute__((weak)) -/** @endcond */ -void port_puts(char *msg) { -} - /** * Halts the system. */ diff --git a/ports/ARM7/chcore.h b/ports/ARM7/chcore.h index 5cc6fc276..3dfef7d80 100644 --- a/ports/ARM7/chcore.h +++ b/ports/ARM7/chcore.h @@ -310,7 +310,6 @@ struct context { #ifdef __cplusplus extern "C" { #endif - void port_puts(char *msg); void port_halt(void); #ifdef THUMB void _port_switch_thumb(Thread *otp, Thread *ntp); diff --git a/ports/ARMCM3/chcore.c b/ports/ARMCM3/chcore.c index 2e247289a..4c23b2da4 100644 --- a/ports/ARMCM3/chcore.c +++ b/ports/ARMCM3/chcore.c @@ -27,19 +27,6 @@ #include #include -/** - * The default implementation of this function is void so no messages are - * actually printed. - * @note The function is declared as a weak symbol, it is possible to redefine - * it in your application code. - * @param msg pointer to the message string - */ -/** @cond never */ -__attribute__((weak)) -/** @endcond */ -void port_puts(char *msg) { -} - /** * Halts the system. * @note The function is declared as a weak symbol, it is possible to redefine diff --git a/ports/ARMCM3/chcore.h b/ports/ARMCM3/chcore.h index 4c3843e56..dd810df36 100644 --- a/ports/ARMCM3/chcore.h +++ b/ports/ARMCM3/chcore.h @@ -302,7 +302,6 @@ struct context { #ifdef __cplusplus extern "C" { #endif - void port_puts(char *msg); void port_halt(void); void threadstart(void); #ifdef __cplusplus diff --git a/ports/AVR/chcore.c b/ports/AVR/chcore.c index 41888ca3f..2050360f8 100644 --- a/ports/AVR/chcore.c +++ b/ports/AVR/chcore.c @@ -26,19 +26,6 @@ #include -/** - * The default implementation of this function is void so no messages are - * actually printed. - * @note The function is declared as a weak symbol, it is possible to redefine - * it in your application code. - * @param msg pointer to the message string - */ -/** @cond never */ -__attribute__((weak)) -/** @endcond */ -void port_puts(char *msg) { -} - /** * Performs a context switch between two threads. * @param otp the thread to be switched out diff --git a/ports/AVR/chcore.h b/ports/AVR/chcore.h index 187a8463c..1bb142b55 100644 --- a/ports/AVR/chcore.h +++ b/ports/AVR/chcore.h @@ -250,7 +250,6 @@ asm ("" : : : "r18", "r19", "r20", "r21", "r22", "r23", "r24", \ #ifdef __cplusplus extern "C" { #endif - void port_puts(char *msg); void port_switch(Thread *otp, Thread *ntp); void port_halt(void); void threadstart(void); diff --git a/ports/MSP430/chcore.c b/ports/MSP430/chcore.c index 4a9857494..45d52726a 100644 --- a/ports/MSP430/chcore.c +++ b/ports/MSP430/chcore.c @@ -26,19 +26,6 @@ #include -/** - * The default implementation of this function is void so no messages are - * actually printed. - * @note The function is declared as a weak symbol, it is possible to redefine - * it in your application code. - * @param msg pointer to the message string - */ -/** @cond never */ -__attribute__((weak)) -/** @endcond */ -void port_puts(char *msg) { -} - /** * Performs a context switch between two threads. * @param otp the thread to be switched out diff --git a/ports/MSP430/chcore.h b/ports/MSP430/chcore.h index c36fdd5c4..b7998371d 100644 --- a/ports/MSP430/chcore.h +++ b/ports/MSP430/chcore.h @@ -221,7 +221,6 @@ struct context { #ifdef __cplusplus extern "C" { #endif - void port_puts(char *msg); void port_switch(Thread *otp, Thread *ntp); void port_halt(void); void threadstart(void); diff --git a/readme.txt b/readme.txt index 26f545b37..c5b66d8f0 100644 --- a/readme.txt +++ b/readme.txt @@ -98,6 +98,8 @@ Win32-MinGW - ChibiOS/RT simulator and demo into a WIN32 process, option can be overriden from outside. - CHANGE: Changed the chSemFastWaitS() macro in chSemFastWaitI() and chSemGetCounter() in chSemGetCounterI(). +- CHANGE: Removed the port_puts() function from the port templates. It was not + implemented on all ports. - Improvements to the test suite, added a new level of indirection that allows to make tests depend on the configuration options without have to put #ifs into the test main module. diff --git a/src/templates/chcore.c b/src/templates/chcore.c index 9d09784ef..b788d356c 100644 --- a/src/templates/chcore.c +++ b/src/templates/chcore.c @@ -130,12 +130,4 @@ void port_halt(void) { void port_switch(Thread *otp, Thread *ntp) { } -/** - * @brief Prints a message on the system console. - * - * @param msg pointer to the message - */ -void port_puts(char *msg) { -} - /** @} */ diff --git a/src/templates/chcore.h b/src/templates/chcore.h index 78fa3abac..c5d750cfb 100644 --- a/src/templates/chcore.h +++ b/src/templates/chcore.h @@ -145,7 +145,6 @@ extern "C" { void port_wait_for_interrupt(void); void port_halt(void); void port_switch(Thread *otp, Thread *ntp); - void port_puts(char *msg); #ifdef __cplusplus } #endif diff --git a/todo.txt b/todo.txt index 31a24af48..876a5d58c 100644 --- a/todo.txt +++ b/todo.txt @@ -15,12 +15,11 @@ After 1.0.0: * Multiple debug switches. * Split asserts from parameters checks. * Add checks to all APIs. - X Stack checks option. + * Stack checks option. * Threads profiling option. * Idle loop hook macro. * Switch the configuration options to TRUE/FALSE rather than def/undef. X Remove port_puts() from all the ports. -- Look into the wrong mutex assert. After 1.2.0: - Threads Pools manager in the library. -- cgit v1.2.3